Move excessive python code from the template into the controller.

debexpo/controllers/package.py

@@ -109,6 +109,13 @@ class PackageController(BaseController):
         else:
             c.user = None
 
+        c.plugins = dict()
+        for package_version in package.package_versions:
+            pv_plugins = Plugins('qa', package_version)
+            pv_plugins.load_plugins()
+            pv_plugins.load_results()
+            c.plugins[package_version.id] = pv_plugins
+
         log.debug('Rendering page')
         return render('/package/index.mako')
 

debexpo/templates/package/index.mako

@@ -147,20 +147,16 @@
 % endif
 </table>
 
-<%
-    plugins = c.plugins('qa', package_version)
-    plugins.load_results()
-%>
-% if len(plugins.results) > 0:
+% if len(c.plugins[package_version.id]) > 0:
 <h3 class="qa-toplevel-header">${ _('QA information') }</h3>
 
 
 <ul class="qa">
     ## Print result from plugins
-    % for plugin in plugins.results:
-     <li class="severity-${ h.constants.PLUGIN_SEVERITY[1].lower() }">
-       <span class="visibility" title="${h.constants.PLUGIN_SEVERITY[1]}">–</span>
-       ${ plugins.plugins[plugin].render(plugins.results[plugin], 'html') | n }
+    % for name, plugin in c.plugins[package_version.id].iteritems():
+     <li class="severity-${ h.constants.PLUGIN_SEVERITY[plugin.test_severity].lower() }">
+       <span class="visibility" title="${h.constants.PLUGIN_SEVERITY[plugin.test_severity]}">–</span>
+       ${ plugin.render('html') | n }
      </li>
     % endfor
 </ul>