Verified Commit 7f1391be authored by Baptiste Beauplat's avatar Baptiste Beauplat
Browse files

Remove always true condition in EmailChangeConfirmView's form_valid

In a class-based view, form_valid is only called when the form has been
validated. Moreover, we only call the dispatch parent class if the reset
link has been validated. Checking it again in form_valid is not needed.
parent d0a962c8
...@@ -308,7 +308,6 @@ class EmailChangeConfirmView(PasswordResetConfirmView): ...@@ -308,7 +308,6 @@ class EmailChangeConfirmView(PasswordResetConfirmView):
return self.render_to_response(self.get_context_data()) return self.render_to_response(self.get_context_data())
def form_valid(self, form): def form_valid(self, form):
if self.validlink:
self.user.email = self.email self.user.email = self.email
self.user.full_clean() self.user.full_clean()
self.user.save() self.user.save()
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment