comments: fix imports, some of them can be removed but need more test/time

security check for db

debexpo/controllers/index.py

@@ -6,7 +6,7 @@
 #
 #   Copyright © 2008 Jonny Lamb <jonny@debian.org>
 #   Copyright © 2010 Jan Dittberner <jandd@debian.org>
-#
+#               2012 Baptiste Mouterde <baptiste.mouterde@gmail.com>
 #   Permission is hereby granted, free of charge, to any person
 #   obtaining a copy of this software and associated documentation
 #   files (the "Software"), to deal in the Software without
@@ -31,9 +31,6 @@
 """
 Holds the IndexController.
 """
-from sqlalchemy.sql.expression import desc
-from debexpo.controllers.comments import CommentsController
-from debexpo.model.package_comments import PackageComment
 
 __author__ = 'Jonny Lamb'
 __copyright__ = 'Copyright © 2008 Jonny Lamb, Copyright © 2010 Jan Dittberner'
@@ -41,6 +38,9 @@ __license__ = 'MIT'
 
 import logging
 
+from sqlalchemy.sql.expression import desc
+from debexpo.controllers.comments import CommentsController
+from debexpo.model.package_comments import PackageComment
 from debexpo.lib.base import BaseController, c, config, render, session
 from debexpo.lib import constants
 from debexpo.controllers.packages import PackagesController, PackageGroups
@@ -60,11 +60,19 @@ class IndexController(BaseController):
 
         c.config = config
         # getting comments stuff
-        c.best_comment = CommentsController.build_comment_render(filter(lambda x: isinstance(x.score, int),
+        try:
+            c.best_comment = CommentsController.build_comment_render(filter(lambda x: isinstance(x.score, int),
             meta.session.query(PackageComment).order_by(PackageComment.score).all())[-1])
-        c.last_comment = CommentsController.build_comment_render(
-            meta.session.query(PackageComment).order_by(desc(PackageComment.time)).first())
 
+        except AttributeError:
+            # this mean that there is no comments rated
+            c.best_comment=None
+        try:
+            c.last_comment = CommentsController.build_comment_render(
+            meta.session.query(PackageComment).order_by(desc(PackageComment.time)).first())
+        except AttributeError:
+            #same as upper
+            c.last_comment=None
         c.packages = pkg_controller._get_packages(
             package_version_filter=(PackageVersion.uploaded >= (datetime.today() - timedelta(days=30))),
             package_filter=(Package.needs_sponsor == 1)