From d9ebbcae2851db85e4f2664e84c169e1224e21ec Mon Sep 17 00:00:00 2001 From: Baptiste Beauplat Date: Sat, 6 Nov 2021 14:03:08 +0100 Subject: [PATCH] Fail the maintainer email plugin on invalid email Prevent getaddresses from having to process invalid values. --- debexpo/plugins/maintaineremail.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/debexpo/plugins/maintaineremail.py b/debexpo/plugins/maintaineremail.py index 6a01f0fa..c9ba9780 100644 --- a/debexpo/plugins/maintaineremail.py +++ b/debexpo/plugins/maintaineremail.py @@ -43,11 +43,12 @@ class PluginMaintainerEmail(BasePlugin): """ Tests whether the maintainer email is the same as the uploader email. """ + if not changes.maintainer: + self.failed('No maintainer address found') + uploader_emails = [] maintainer_emails = email.utils.getaddresses([changes.maintainer]) - - if maintainer_emails: - maintainer_email = maintainer_emails[0][1] + maintainer_email = maintainer_emails[0][1] if changes.dsc.uploaders: for _, uploader_email in \ -- GitLab