Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D debexpo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 42
    • Issues 42
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mentors.debian.net
  • debexpo
  • Issues
  • #95
Closed
Open
Issue created Apr 02, 2020 by Baptiste Beauplat@lyknodeOwner

Worker crash on emtpy email in Changed-By field in changes

The worker crashed with the following trace:

Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,266 INFO  [debexpo.worker] Importing upload: /var/cache/debexpo/incoming/pub/pub/UploadQueue/debfact_1.0-1_amd64.changes
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,275 INFO  [debexpo.importer.23002] Changing dir to /var/cache/debexpo/incoming/                           
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,276 DEBUG [debexpo.importer.23002] Determining user from 'Changed-By:' field: <>                          
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,278 DEBUG [debexpo.importer.23002] Changed-By's email address is:                                         
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,283 DEBUG [debexpo.lib.filesystem] Looking whether debfact_1.0-1.dsc was actually uploaded                
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,283 DEBUG [debexpo.lib.filesystem] debfact_1.0-1.dsc is present                                           
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,283 DEBUG [debexpo.lib.filesystem] Looking whether debfact_1.0.orig.tar.gz was actually uploaded          
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,283 DEBUG [debexpo.lib.filesystem] debfact_1.0.orig.tar.gz is present                                     
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,283 DEBUG [debexpo.lib.filesystem] Looking whether debfact_1.0-1.debian.tar.xz was actually uploaded      
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,283 DEBUG [debexpo.lib.filesystem] debfact_1.0-1.debian.tar.xz is present                                 
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,283 DEBUG [debexpo.lib.filesystem] Looking whether debfact-dbgsym_1.0-1_amd64.deb was actually uploaded   
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,283 DEBUG [debexpo.lib.filesystem] debfact-dbgsym_1.0-1_amd64.deb is present                              
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,283 DEBUG [debexpo.lib.filesystem] Looking whether debfact_1.0-1_amd64.buildinfo was actually uploaded    
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,283 DEBUG [debexpo.lib.filesystem] debfact_1.0-1_amd64.buildinfo is present                               
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,284 DEBUG [debexpo.lib.filesystem] Looking whether debfact_1.0-1_amd64.deb was actually uploaded          
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,284 DEBUG [debexpo.lib.filesystem] debfact_1.0-1_amd64.deb is present                                     
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,284 DEBUG [debexpo.lib.filesystem] Checking md5sum of debfact_1.0-1.dsc                                   
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,284 DEBUG [debexpo.lib.filesystem] Checking md5sum of debfact_1.0.orig.tar.gz                             
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,284 DEBUG [debexpo.lib.filesystem] Checking md5sum of debfact_1.0-1.debian.tar.xz                         
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,284 DEBUG [debexpo.lib.filesystem] Checking md5sum of debfact-dbgsym_1.0-1_amd64.deb                      
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,284 DEBUG [debexpo.lib.filesystem] Checking md5sum of debfact_1.0-1_amd64.buildinfo                       
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,284 DEBUG [debexpo.lib.filesystem] Checking md5sum of debfact_1.0-1_amd64.deb                             
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,403 ERROR [debexpo.importer.23002] Rejected: Your upload does not contain a valid signature. Output was:  
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: gpg: Signature made Wed 01 Apr 2020 10:55:33 AM UTC                                                                                 
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: gpg:                using RSA key FA181301E26184F36BAA33DF65482D0AD22D52B4                                                          
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: gpg: Can't check signature: No public key                                                                                           
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,404 DEBUG [debexpo.lib.email] Getting mail template: importer_reject_maintainer                           
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,411 DEBUG [debexpo.lib.email] Starting SMTP session to localhost:25                                       
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: 2020-04-02 +0000 14:13:08,425 DEBUG [debexpo.lib.email] Sending email to                                                            
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: Traceback (most recent call last):
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:   File "/var/www/debexpo/bin/debexpo_worker.py", line 256, in <module>                                                              
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:     worker.run()
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:   File "/var/www/debexpo/bin/debexpo_worker.py", line 231, in run                                                                   
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:     self.jobs[job]['module'].invoke()
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:   File "/home/expo/debexpo/debexpo/cronjobs/importuploads.py", line 113, in invoke                                                  
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:     returncode = importer.main(no_env=True)                                                                                         
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:   File "/home/expo/debexpo/debexpo/importer/importer.py", line 710, in main                                                         
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:     'Output was:\n%s' % (gpg_out))
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:   File "/home/expo/debexpo/debexpo/importer/importer.py", line 295, in _reject                                                      
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:     message=reason)
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:   File "/home/expo/debexpo/debexpo/importer/importer.py", line 123, in send_email                                                   
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:     email.send(*args, **kwargs)
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:   File "/home/expo/debexpo/debexpo/lib/email.py", line 175, in send                                                                 
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:     self._send_as_mail(recipients, message)                                                                                         
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:   File "/home/expo/debexpo/debexpo/lib/email.py", line 192, in _send_as_mail                                                        
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:     recipients, message)
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:   File "/usr/lib/python2.7/smtplib.py", line 748, in sendmail                                                                       
Apr 02 14:13:08 wv-debian-mentors1 python[23002]:     raise SMTPRecipientsRefused(senderrs)                                                                                           
Apr 02 14:13:08 wv-debian-mentors1 python[23002]: smtplib.SMTPRecipientsRefused: {'': (501, '5.1.3 Bad recipient address syntax')}                                                    
Apr 02 14:13:08 wv-debian-mentors1 systemd[376]: worker.service: Main process exited, code=exited, status=1/FAILURE                                                                   
Apr 02 14:13:08 wv-debian-mentors1 systemd[376]: worker.service: Failed with result 'exit-code'.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking