Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D debexpo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 43
    • Issues 43
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mentors.debian.net
  • debexpo
  • Merge requests
  • !186

Limit madison results to source packages

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Baptiste Beauplat requested to merge lyknode/debexpo:version-check into live Dec 07, 2021
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

In a few rare case in debian (104 source packages according to udd), source and binary packages don't share the same version. In a even smaller subset of those case (22 source packages), the binary and source package are the same. Finally, out of those 22 packages, some of them have a higher binary version than the source one.

For those specific cases, the request we send to madison will return the binary packages and debexpo will wrongly reject the upload.

By explicitly asking madison to return results only matching source packages, we prevent such case to occur.

I have tested locally this change but I did not add a test (change for an external api).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: version-check