Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D debexpo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 42
    • Issues 42
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mentors.debian.net
  • debexpo
  • Merge requests
  • !20

Unify

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Baptiste Beauplat requested to merge lyknode/debexpo:unify into live Dec 09, 2018
  • Overview 2
  • Commits 0
  • Pipelines 1
  • Changes 0

This MR does not contain any changes.

DMUP acceptance did not qualify for production.

From #debexpo@irc.oftc.net:

14:22 < lyknode> It's the addition of DMUP acceptance before uploading package
14:24 < lyknode> I have mixed feeling about this feature.
14:26 < lyknode> Given that mentors is not maintained by DSA team
14:27 < lyknode> and that the DMUP seems to be more relevant on system where users can login, not just use the service hosted
14:30 < lyknode> Also, having a ToS would be nice, I think mentors should have its own.
14:31 < lyknode> What you do think?
17:52 < mapreri> lyknode: I also dislike that thing.  Also the "dmup" name for the database object is horrible.  maybe we can think of adding a "tos" column.
                 Anyway, I don't think I ever heard of misusing mentors.d.n in all these years, so I think it's ok the way it is for now…
17:53 < mapreri> may I suggest to not merge that (IOW: merge that commit and then revert the merge commit, so you can then continue merging the rest, I *think* it
                 should work as one would expect, git-wise)
17:54 < mapreri> pabs, olasd: ↑ comments?
17:54 < mapreri> maybe also filing a bug noting down that commit saying it needs extra thoughts again, or something.
19:28 < lyknode> sound good to me
Day changed to 09 Dec 2018
00:11 < pabs> mapreri, lyknode: agreed re the ToS comments

Relates to #5 (closed)

Edited Dec 09, 2018 by Baptiste Beauplat
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: unify