Commit 2fdec639 authored by Tiago Bortoletto Vaz's avatar Tiago Bortoletto Vaz

Add debian/patches/05_fix_segfault.diff to fix a segfault on startup. Thanks...

Add debian/patches/05_fix_segfault.diff to fix a segfault on startup. Thanks to Stefan Potyra for the patch. (Closes: #892077)
parent 9c7e8ee0
rakarrack (0.6.1-5) unstable; urgency=medium
* Add debian/patches/05_fix_segfault.diff to fix a segfault on
startup. Thanks to Stefan Potyra for the patch. (Closes: #892077)
-- Tiago Bortoletto Vaz <tiago@debian.org> Mon, 03 Sep 2018 21:22:52 -0400
rakarrack (0.6.1-4) unstable; urgency=low
* Switch to dpkg-source 3.0 (quilt) format
* Fixes format-security issue in rakarrack.cxx. Thanks to Mònica Ramírez
Arceda and Daniel T Chen. (Closes: #652164)
-- Tiago Bortoletto Vaz <tiago@debian.org> Tue, 27 Dec 2011 11:51:00 -0500
rakarrack (0.6.1-3) unstable; urgency=low
* debian/rules: Remove src/config.h before the invocation of configure.
Since configure is called out-of-tree, the upstream provided config.h
is used instead of the freshly created config.h. Thanks to Stefan Potyra
for the patch. (Closes: #632149)
-- Tiago Bortoletto Vaz <tiago@debian.org> Mon, 25 Jul 2011 09:29:53 -0300
rakarrack (0.6.1-2) unstable; urgency=low
* Adding support for x86 CPUs with no support for sse2 instructions.
Thanks to Hans-Juergen Becker for reporting this. (Closes: #557550)
-- Tiago Bortoletto Vaz <tiago@debian.org> Sun, 19 Jun 2011 03:36:17 -0300
rakarrack (0.6.1-1) unstable; urgency=low
* New upstream version. (Closes: #611304)
......
......@@ -3,7 +3,6 @@ Section: sound
Priority: extra
Maintainer: Tiago Bortoletto Vaz <tiago@debian.org>
Build-Depends: debhelper (>= 7),
cdbs,
libfltk1.1-dev,
alsa-utils,
libasound2-dev,
......@@ -12,8 +11,8 @@ Build-Depends: debhelper (>= 7),
libxft-dev,
libsndfile1-dev,
libsamplerate0-dev,
dpatch
Standards-Version: 3.9.1
quilt (>= 0.40)
Standards-Version: 3.9.2
Homepage: http://rakarrack.sourceforge.net
Vcs-Git: git://git.debian.org/collab-maint/rakarrack.git
Vcs-Browser: http://git.debian.org/git/collab-maint/rakarrack.git
......
usr/lib/rakarrack
#! /bin/sh /usr/share/dpatch/dpatch-run
## 01_fix_manpage.dpatch by <tiago@debian-ba.org>
##
## DP: Fixes manpage
@DPATCH@
diff -urNad rakarrack~/man/rakarrack.1 rakarrack/man/rakarrack.1
--- rakarrack~/man/rakarrack.1 2009-11-21 09:54:12.000000000 -0200
+++ rakarrack/man/rakarrack.1 2009-11-21 09:55:44.000000000 -0200
@@ -1,22 +1,7 @@
-.\" Hey, EMACS: -*- nroff -*-
-.\" First parameter, NAME, should be all caps
-.\" Second parameter, SECTION, should be 1-8, maybe w/ subsection
-.\" other parameters are allowed: see man(7), man(1)
-.TH RACKARRACK SECTION "abril 24, 2008"
-.\" Please adjust this date whenever revising the manpage.
-.\"
-.\" Some roff macros, for reference:
-.\" .nh disable hyphenation
-.\" .hy enable hyphenation
-.\" .ad l left justify
-.\" .ad b justify to both left and right margins
-.\" .nf disable filling
-.\" .fi enable filling
-.\" .br insert line break
-.\" .sp <n> insert n+1 empty lines
-.\" for manpage-specific macros, see man(7)
+.TH RACKARRACK "1" "March 12, 2009"
+
.SH NAME
-rackarrack \- for guitar players and musicians ...
+rackarrack \- guitar effects processor for GNU/Linux
.SH SYNOPSIS
.B rakarrack
.RI [ options ] " files" ...
@@ -24,32 +9,29 @@
.SH DESCRIPTION
.B Rakarrack is a jack multi effect emulator.
.TP
-his manual page was written for the Debian distribution and only lists the
-options that are available for Rakarrack when starting it from the command line.
+This manual page lists the options that are available for Rakarrack when
+starting it from the command line.
.PP
-.\" TeX users may be more comfortable with the \fB<whatever>\fP and
-.\" \fI<whatever>\fP escape sequences to invode bold face and italics,
-.\" respectively.
-
.SH OPTIONS
-These programs follow the usual GNU command line syntax, with long
-options starting with two dashes (`-').
-A summary of options is included below.
+These programs follow the usual GNU command line syntax, with long options
+starting with two dashes (`-'). A summary of options is included below.
+
.TP
.B \-h, \-\-help
Show summary of options.
.TP
.B \-n, \-\-no-gui
-disable GUI
+Disable GUI
.TP
-.B \-b, \-\-Bank [File]
+.B \-b, \-\-Bank [File]
Load a Bank File
.TP
-.B \-l, \-\-Load [File]
+.B \-l, \-\-Load [File]
Load a Preset File
.SH AUTHOR
-This manual page was written by holborn <holborn@telefonica.net>,
-
+This manual page was written by holborn <holborn@telefonica.net> and has been
+modified by Tiago Bortoletto Vaz <tiago@debian.org> for the Debian
+distribution.
#! /bin/sh /usr/share/dpatch/dpatch-run
## 02_fix_to_binutils-gold.dpatch by Tiago Bortoletto Vaz <tiago@debian.org>
##
## DP: Add missing libs to the linker due to the "--no-add-needed"
## binutils-gold behavior
@DPATCH@
diff -urNad rakarrack~/configure.in rakarrack/configure.in
--- rakarrack~/configure.in 2009-11-21 09:54:12.000000000 -0200
+++ rakarrack/configure.in 2009-11-21 09:55:04.000000000 -0200
@@ -89,7 +89,7 @@
-LIBS="`$FLTKCONFIG --use-images --ldflags` -lasound `pkg-config --libs jack` -lXpm"
+LIBS="`$FLTKCONFIG --use-images --ldflags` -lasound `pkg-config --libs jack` -lXpm -lX11"
CXXFLAGS="-O2 -Wall $SSE -fno-rtti -pipe -ffunction-sections -fomit-frame-pointer -Wno-format-y2k -fPIC -fno-exceptions -fno-strict-aliasing `$FLTKCONFIG --use-images --cxxflags` `pkg-config --cflags jack`"
AC_CONFIG_FILES([Makefile src/Makefile man/Makefile data/Makefile icons/Makefile doc/Makefile doc/help/Makefile doc/help/imagenes/Makefile doc/help/css/Makefile])
AC_OUTPUT
#! /bin/sh /usr/share/dpatch/dpatch-run
## 03_fix_to_binutils-gold.dpatch by Tiago Bortoletto Vaz <tiago@debian.org>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Add X11 library
@DPATCH@
diff -urNad rakarrack~/configure.in rakarrack/configure.in
--- rakarrack~/configure.in 2010-01-31 21:48:08.000000000 +0000
+++ rakarrack/configure.in 2010-01-31 22:43:42.000000000 +0000
@@ -92,7 +92,7 @@
-LIBS="`$FLTKCONFIG --use-images --ldflags` -lasound `pkg-config --libs jack` -lXpm $LIBS"
+LIBS="`$FLTKCONFIG --use-images --ldflags` -lasound `pkg-config --libs jack` -lXpm -lX11 $LIBS"
CXXFLAGS="-Wall $SSE $ALTIVEC -ffast-math -fno-rtti -pipe -ffunction-sections -fomit-frame-pointer -fsigned-char -Wno-format-y2k -fPIC -fno-exceptions -fno-strict-aliasing `$FLTKCONFIG --use-images --cxxflags` `pkg-config --cflags jack` $CXXFLAGS"
AC_CONFIG_FILES([Makefile src/Makefile man/Makefile data/Makefile icons/Makefile doc/Makefile doc/help/Makefile doc/help/imagenes/Makefile doc/help/css/Makefile])
AC_OUTPUT
#! /bin/sh /usr/share/dpatch/dpatch-run
## 04_fix_manpage.dpatch by Tiago Bortoletto Vaz <tiago@debian.org>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Fixes manpage
@DPATCH@
diff -urNad rakarrack~/man/rakarrack.1 rakarrack/man/rakarrack.1
--- rakarrack~/man/rakarrack.1 2010-01-03 23:28:13.000000000 +0000
+++ rakarrack/man/rakarrack.1 2010-01-31 23:27:42.000000000 +0000
diff --git a/man/rakarrack.1 b/man/rakarrack.1
index d912a01..89d3503 100644
--- a/man/rakarrack.1
+++ b/man/rakarrack.1
@@ -1,22 +1,6 @@
-.\" Hey, EMACS: -*- nroff -*-
-.\" First parameter, NAME, should be all caps
......@@ -33,7 +27,7 @@ diff -urNad rakarrack~/man/rakarrack.1 rakarrack/man/rakarrack.1
.SH SYNOPSIS
.B rakarrack
.RI [ options ] " files" ...
@@ -37,28 +21,27 @@
@@ -39,28 +23,27 @@ Rakarrack is designed for Linux distributions with Jack Audio Connection Kit.
.TP
.PP
......
Description: Fix segfault with uninitialiized variable
Ppreset is uninitialized in this function, which leads to a
segfault later on.
Thanks to Ben Wiederhake for finding the details.
The bug was forwarded to Ryan via private mail on 10 Mar 2018.
Author: Stefan Potyra <stefan@potyra.de>
Bug-Debian: https://bugs.debian.org/892077
--- rakarrack-0.6.1.orig/src/Looper.C
+++ rakarrack-0.6.1/src/Looper.C
@@ -28,7 +28,7 @@
#include <math.h>
#include "Looper.h"
-Looper::Looper (float * efxoutl_, float * efxoutr_, float size)
+Looper::Looper (float * efxoutl_, float * efxoutr_, float size) : Ppreset(0)
{
efxoutl = efxoutl_;
efxoutr = efxoutr_;
Index: rakarrack-0.6.1/src/rakarrack.cxx
===================================================================
--- rakarrack-0.6.1.orig/src/rakarrack.cxx 2011-12-24 15:31:22.000000000 -0500
+++ rakarrack-0.6.1/src/rakarrack.cxx 2011-12-24 15:31:24.000000000 -0500
@@ -22889,7 +22889,7 @@
Fl_Widget *m = fl_message_icon();
m->parent()->copy_label(rkr->jackcliname);
sprintf(temp2,"Overwrite? \"%s\"",w->label());
- ok=fl_choice(temp2,"No","Yes",NULL);
+ ok=fl_choice("%s",temp2,"No","Yes",NULL);
if (!ok)
{
o->value(0);
@@ -24142,7 +24142,7 @@
w->parent()->copy_label(rkr->jackcliname);
- ok=fl_choice("Bank was modified, but not saved","Discard","Save",NULL);
+ ok=fl_choice("%s","Bank was modified, but not saved","Discard","Save",NULL);
@@ -27243,7 +27243,7 @@
}
sprintf(temp2,"Delete? \"%s\"",s->text());
-ok=fl_choice(temp2,"No","Yes",NULL);
+ok=fl_choice("%s",temp2,"No","Yes",NULL);
if (!ok) return;
memset(Rname,0,sizeof(Rname));
sprintf(Rname,"%s",s->text());
Index: rakarrack-0.6.1/src/fileio.C
===================================================================
--- rakarrack-0.6.1.orig/src/fileio.C 2011-12-24 15:31:22.000000000 -0500
+++ rakarrack-0.6.1/src/fileio.C 2011-12-24 15:31:24.000000000 -0500
@@ -1641,7 +1641,7 @@
case 3:
memset (temp, 0, sizeof (temp));
- sprintf (temp, BankFilename);
+ sprintf (temp, "%s", BankFilename);
break;
}
@@ -2786,4 +2786,4 @@
}
-
\ No newline at end of file
+
Index: rakarrack-0.6.1/src/varios.C
===================================================================
--- rakarrack-0.6.1.orig/src/varios.C 2011-12-24 16:36:58.000000000 -0500
+++ rakarrack-0.6.1/src/varios.C 2011-12-24 16:37:49.000000000 -0500
@@ -41,7 +41,7 @@
w->image (a);
w->align (FL_ALIGN_TOP | FL_ALIGN_INSIDE);
w->parent ()->copy_label (labelwin);
- fl_message (message_text);
+ fl_message ("%s", message_text);
return (0);
};
@@ -399,4 +399,4 @@
-
\ No newline at end of file
+
04_fix_manpage.diff
format-security.diff
05_fix_segfault.diff
#!/bin/sh
SSE2="`grep -i sse2 /proc/cpuinfo`"
if [ "$SSE2" != "" ]
then
exec /usr/lib/rakarrack/rakarrack
else
exec /usr/lib/rakarrack/sse/rakarrack
fi
#!/usr/bin/make -f
# Derived from:
# Sample debian/rules that uses debhelper,
# GNU copyright 1997 by Joey Hess.
# Copyright Ron Lee 2003, 2004, 2007, 2008
SHELL = /bin/bash
include /usr/share/quilt/quilt.make
#export DH_VERBOSE=1
export DH_OPTIONS
ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
INSTALL_PROGRAM += -s
endif
# These are used for cross-compiling and for saving the configure script
# from having to guess our platform (since we know it already)
DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
DEB_HOST_ARCH_CPU ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_CPU)
builddir = build
builddir_sse = build-sse
all_builds = $(builddir) $(builddir_sse)
arch_builds = $(builddir)
ifeq ($(DEB_HOST_ARCH_CPU),i386)
arch_builds += $(builddir_sse)
endif
clean:
dh_testdir
dh_testroot
$(RM) *-stamp
$(RM) -r $(all_builds) config.log
dh_clean
# This first empty one is equivalent to declaring it .SECONDARY while we have
# no target specific variables to set. We don't want it removed by default as
# an unnamed intermediate file when the build target is completed.
$(builddir)/config.status:
$(builddir_sse)/config.status: EXTRA_CONFIG_FLAGS += --enable-sse
%/config.status: configure
dh_testdir
mkdir -p $*
$(RM) src/config.h
cd $* && ../configure --host=$(DEB_HOST_GNU_TYPE) \
--build=$(DEB_BUILD_GNU_TYPE) \
--prefix=/usr \
$(EXTRA_CONFIG_FLAGS)
build: build-arch
build-arch: $(foreach d,$(arch_builds),build-target-$(d)-stamp)
build-target-%-stamp : %/config.status
dh_testdir
cd $* && $(MAKE)
touch $@
build-indep: build-indep-stamp
build-indep-stamp:
dh_testdir
touch $@
install: install-arch install-indep
install-arch: install-arch-stamp
install-arch-stamp:
dh_testdir
cd $(builddir) && $(MAKE) install DESTDIR=$(CURDIR)/debian/rakarrack
find $(CURDIR)/debian/rakarrack/ -name "COPYING" -depth -exec rm -rf {} \;
mv $(CURDIR)/debian/rakarrack/usr/share/doc/rakarrack/ChangeLog $(CURDIR)/debian/rakarrack/usr/share/doc/rakarrack/changelog
if [ -d "$(builddir_sse)" ]; then \
mkdir -p $(CURDIR)/debian/rakarrack/usr/lib/rakarrack/sse; \
cp -v $(builddir)/src/rakarrack $(CURDIR)/debian/rakarrack/usr/lib/rakarrack; \
cp -v $(builddir_sse)/src/rakarrack $(CURDIR)/debian/rakarrack/usr/lib/rakarrack/sse; \
cp -v $(CURDIR)/debian/rakarrack.wrapper $(CURDIR)/debian/rakarrack/usr/bin/rakarrack; \
fi
touch $@
install-indep:
binary: binary-indep binary-arch
binary-indep: DH_OPTIONS = -i
binary-indep: build-indep install-indep
dh_testdir
dh_testroot
dh_installdocs
dh_installchangelogs
dh_compress
dh_fixperms
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
binary-arch: build-arch install-arch
dh_testdir
dh_testroot
dh_install -a
dh_installdocs -a
dh_installman -a
dh_installchangelogs -a
dh_strip -a
dh_compress -a
dh_fixperms -a
dh_installdeb -a
dh_shlibdeps -a
dh_gencontrol -a
dh_md5sums -a
dh_builddeb -a
include /usr/share/cdbs/1/rules/debhelper.mk
include /usr/share/cdbs/1/rules/dpatch.mk
include /usr/share/cdbs/1/class/autotools.mk
install/rakarrack::
find debian/rakarrack/ -name "COPYING" -depth -exec rm -rf {} \;
.PHONY: clean build build-arch build-indep install install-arch install-indep \
binary binary-arch binary-indep
clean/rakarrack::
rm -f config.log
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment