Skip to content

Meaning of thumbs up/down in NEW column of README?

Hi! I find the granularity of the NEW column in the README a bit lacking. How would I represent a REJECTED with some comment that is fixed and then ACCEPTED? One could say that it was a success since the package got accepted (hence thumbs up) or a failure because our review process didn't catch it while the ftp-master review found an issue (hence thumbs down). There is a gray zone with multiple interactions with ftp-master uploads, with some of the comments touching overlapping nits found by our review.

So: what is that column's semantics?

I think a reasonable semantic is to give thumns up where an upload that adress all comments raised here got ACCEPTED. And thumbs down if it got REJECTED, or the upload did not fix all issues that were raised here (e.g., the bitfield-script situation where I got good feedback from you but had already uploaded the package). I don't know how to deal with a situation where this project turned up good catch, that wasn't addressed in the upload, and the ftp-master sent an ACCEPT. Which could happen for bitfield-script now, if ftp-master doesn't catch that problem on their own or doesn't care about it (hard to tell a difference).

I forgot to submit golang-github-smallstep-cli-utils to this project, but ftp-master found a hard to spot copyright concern in it, which made me think about this aspect.