housekeeping.py 16 KB
Newer Older
Enrico Zini's avatar
Enrico Zini committed
1
2
from __future__ import annotations
from typing import Optional
Enrico Zini's avatar
Enrico Zini committed
3
import django_housekeeping as hk
4
from django.db import transaction
Enrico Zini's avatar
Enrico Zini committed
5
from django.utils.timezone import now
6
from backend.housekeeping import MakeLink, Housekeeper
7
from . import udldap
8
from backend import const
9
from sitechecks.models import Inconsistency
10
import backend.models as bmodels
11
import process.models as pmodels
12
import backend.ops as bops
13
import process.ops as pops
14
import dsa.models as dmodels
Enrico Zini's avatar
Enrico Zini committed
15
import datetime
16
17
18
19
import logging

log = logging.getLogger(__name__)

20

Enrico Zini's avatar
Enrico Zini committed
21
class NewGuestAccountsFromDSA(hk.Task):
22
23
24
    """
    Create new Person entries for guest accounts created by DSA
    """
25
    DEPENDS = [MakeLink, Housekeeper]
26

27
    @transaction.atomic
Enrico Zini's avatar
Enrico Zini committed
28
    def run_main(self, stage):
29
        for entry in udldap.list_people():
30
            # Skip DDs
Enrico Zini's avatar
Enrico Zini committed
31
32
            if entry.is_dd and entry.single("keyFingerPrint") is not None:
                continue
33

34
            fpr = entry.single("keyFingerPrint")
35
36

            # Skip people without fingerprints
Enrico Zini's avatar
Enrico Zini committed
37
38
            if fpr is None:
                continue
39

40
            email = entry.single("emailForward")
41

42
            # Skip entries without emails (happens when running outside of the Debian network)
Enrico Zini's avatar
Enrico Zini committed
43
44
            if email is None:
                continue
45

46
47
48
49
50
51
52
53
            # Find the corresponding person in our database
            person = bmodels.Person.objects.get_from_other_db(
                "LDAP",
                uid=entry.uid,
                fpr=fpr,
                email=email,
                format_person=self.hk.link,
            )
54
55
56

            if not person:
                # New DC_GA
57
                audit_notes = "created new guest account entry from LDAP"
58
59
60
61
                person = bmodels.Person.objects.create_user(
                    cn=entry.single("cn"),
                    mn=entry.single("mn") or "",
                    sn=entry.single("sn") or "",
62
                    email=email,
63
                    email_ldap=email,
64
                    uid=entry.uid,
65
                    fpr=fpr,
66
67
                    status=const.STATUS_DC_GA,
                    audit_author=self.hk.housekeeper.user,
68
                    audit_notes=audit_notes,
69
                )
70
                log.warn("%s: %s %s", self.IDENTIFIER, self.hk.link(person), audit_notes)
71
            else:
72
                # Validate fields
Enrico Zini's avatar
Enrico Zini committed
73
                if person.ldap_fields.uid is not None and person.ldap_fields.uid != entry.uid:
74
                    log.warn("%s: LDAP has uid %s for person %s, but uid is %s in our database",
Enrico Zini's avatar
Enrico Zini committed
75
                             self.IDENTIFIER, entry.uid, self.hk.link(person), person.ldap_fields.uid)
76
77
78
79
80
81
82
83
84
85
86
87
                    continue

                if person.fpr is not None and person.fpr != fpr:
                    log.warn("%s: LDAP has fingerprint %s for person %s, but fingerprint is %s in our database",
                             self.IDENTIFIER, fpr, self.hk.link(person), person.fpr)
                    continue

                audit_notes = ["entry found in LDAP"]

                # Ignore differences in email forward: they are caught by
                # CheckLDAPConsistency

88
89
90
                if person.status in (const.STATUS_DC_GA, const.STATUS_DM_GA):
                    # We already know about it: nothing to do
                    pass
Enrico Zini's avatar
Enrico Zini committed
91
                elif person.status in (const.STATUS_DC, const.STATUS_DM):
92
93
                    if person.status == const.STATUS_DM:
                        # DM that becomes DM_GA (acquires uid)
94
                        new_status = const.STATUS_DM_GA
95
96
                    else:
                        # DC that becomes DC_GA (acquires uid)
97
                        new_status = const.STATUS_DC_GA
98
                    audit_notes = "entry found in LDAP, adding 'guest account' status"
99

100
                    try:
Enrico Zini's avatar
Enrico Zini committed
101
102
                        process = pmodels.Process.objects.get(
                                person=person, closed_by__isnull=True, applying_for=new_status)
103
104
105
106
                    except pmodels.Process.DoesNotExist:
                        process = None

                    if process is None:
107
108
109
110
                        op = bops.ChangeStatus(
                            audit_author=self.hk.housekeeper.user, audit_notes=audit_notes,
                            person=person, status=new_status)
                        op.execute()
111
                    else:
112
                        op = pops.ProcessClose(
113
114
115
116
                            audit_author=self.hk.housekeeper.user, audit_notes=audit_notes,
                            process=process,
                        )
                        op.execute()
117

118
119
120
121
122
123
124
                    log.info("%s: %s %s", self.IDENTIFIER, self.hk.link(person), audit_notes)
                else:
                    # New uid on a status that is not supposed to have one:
                    # just warn about it
                    log.warn("%s: LDAP has new uid %s for person %s, which already has status %s in our database",
                             self.IDENTIFIER, entry.uid, self.hk.link(person), const.ALL_STATUS_DESCS[person.status])

125

Enrico Zini's avatar
Enrico Zini committed
126
class CheckLDAPConsistency(hk.Task):
127
128
129
    """
    Show entries that do not match between LDAP and our DB
    """
130
    DEPENDS = [MakeLink, Housekeeper]
131

Enrico Zini's avatar
Enrico Zini committed
132
133
134
135
136
137
138
139
    def __init__(self, *args, **kw):
        super().__init__(*args, **kw)
        self.email_forwarding_cutoff = now() - datetime.timedelta(days=6 * 30)

    def check_unmapped_ldap_entry(self, entry):
        """
        Check a LDAP entry that has no corresponding entry on nm.debian.org
        """
140
141
        from backend.models import _build_fullname

Enrico Zini's avatar
Enrico Zini committed
142
143
        fpr = entry.single("keyFingerPrint")
        if fpr:
144
145
146
147
            Inconsistency.objects.found(
                    self.IDENTIFIER,
                    f"{entry.uid} has fingerprint {fpr} and gid {entry.single('gidNumber')} in LDAP,"
                    " but is not in our db")
Enrico Zini's avatar
Enrico Zini committed
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
        else:
            ldap_fields_args = {
                "cn": entry.single("cn"),
                "mn": entry.single("mn") or "",
                "sn": entry.single("sn") or "",
                "uid": entry.uid,
                "email": entry.single("emailForward"),
            }
            person_args = {
                "email": entry.single("emailForward"),
                "fullname": _build_fullname(entry.single("cn"), entry.single("mn"), entry.single("sn")),
            }
            audit_args = {
                "audit_author": self.hk.housekeeper.user,
            }
            if entry.is_dd:
                person_args["status"] = const.STATUS_REMOVED_DD
                audit_args["audit_notes"] = "created to mirror a removed DD account from LDAP"
                if not person_args["email"]:
                    person_args["email"] = "{}@debian.org".format(entry.uid)
            else:
                person_args["status"] = const.STATUS_DC_GA
                audit_args["audit_notes"] = "created to mirror a removed guest account from LDAP"
                if not person_args["email"]:
                    person_args["email"] = "{}@example.org".format(entry.uid)
            person = bmodels.Person.objects.create_user(**person_args, **audit_args)
            dmodels.LDAPFields.objects.create(person=person, **ldap_fields_args, **audit_args)
            log.warn("%s: %s: %s", self.IDENTIFIER, self.hk.link(person), audit_args["audit_notes"])

    def check_account_status(self, person, entry, dsa_status: str, dsa_status_date: Optional[datetime.date] = None):
        """
        Check a LDAP entry for a person, with one of the closed/locked
        accountStatus values
        """
        if person.status in (const.STATUS_DC_GA, const.STATUS_DM_GA):
            pass  # TODO: handle guest accounts that have been closed
        elif person.status not in (const.STATUS_REMOVED_DD, const.STATUS_EMERITUS_DD):
            try:
                process = pmodels.Process.objects.get(
                        person=person, closed_by__isnull=True,
188
189
                        applying_for__in=(const.STATUS_REMOVED_DD, const.STATUS_EMERITUS_DD),
                        approved_by__isnull=False)
Enrico Zini's avatar
Enrico Zini committed
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
            except pmodels.Process.DoesNotExist:
                process = None

            if process is not None:
                audit_notes = "closed from dsa: " + entry.single("accountStatus")
                op = pops.ProcessClose(
                    audit_author=self.hk.housekeeper.user, audit_notes=audit_notes,
                    process=process,
                )
                op.execute()
                person.refresh_from_db()
                log.info("%s: %s %s", self.IDENTIFIER, self.hk.link(person), audit_notes)
            elif not entry.is_dd:
                # mom040267 has a locked account (see the FD comments on the site)
                if person.ldap_fields.uid != "mom040267":
205
206
207
208
209
210
                    Inconsistency.objects.found(
                        self.IDENTIFIER,
                        f"person has accountStatus '{entry.single('accountStatus')}'"
                        f" (comment: {entry.single('accountComment')})"
                        f" but in our db the state is {const.ALL_STATUS_DESCS[person.status]}",
                        person=person)
Enrico Zini's avatar
Enrico Zini committed
211
212
213
214
215
216
217

        if entry.is_dd:
            # if person.status not in (const.STATUS_REMOVED_DD, const.STATUS_EMERITUS_DD):
            #     log.warn("%s: %s has supplementaryGid Debian, but in our db the state is %s",
            #              self.IDENTIFIER, self.hk.link(person), const.ALL_STATUS_DESCS[person.status])

            if person.status_changed > self.email_forwarding_cutoff:
218
219
220
221
222
                if person.ldap_fields.uid == "preining":
                    # special case preining; he is marked as retired in LDAP, but the account
                    # is simply locked while he became a DM.
                    pass
                elif dsa_status == "retiring" and person.status != const.STATUS_EMERITUS_DD:
223
224
225
226
227
228
                    Inconsistency.objects.found(
                        self.IDENTIFIER,
                        f"person has accountStatus '{entry.single('accountStatus')}'"
                        f" (comment: {entry.single('accountComment')})"
                        f" but in our db the state is {const.ALL_STATUS_DESCS[person.status]} [retiring]",
                        person=person)
Enrico Zini's avatar
Enrico Zini committed
229
230

                if dsa_status == "inactive" and person.status != const.STATUS_REMOVED_DD:
231
232
233
234
235
236
                    Inconsistency.objects.found(
                        self.IDENTIFIER,
                        f"person has accountStatus '{entry.single('accountStatus')}'"
                        f" (comment: {entry.single('accountComment')})"
                        f" but in our db the state is {const.ALL_STATUS_DESCS[person.status]} [inactive]",
                        person=person)
Enrico Zini's avatar
Enrico Zini committed
237
238
239
240

        if dsa_status == "locked":
            parsed = entry.single("accountStatus").split()
            if len(parsed) == 1:
241
242
243
244
245
                Inconsistency.objects.found(
                    self.IDENTIFIER,
                    f"person has accountStatus '{entry.single('accountStatus')}'"
                    f"(comment: {entry.single('accountComment')}) locked with no date",
                    person=person)
Enrico Zini's avatar
Enrico Zini committed
246
247
            else:
                if dsa_status_date is not None and dsa_status_date < self.email_forwarding_cutoff.date():
248
249
250
251
252
                    Inconsistency.objects.found(
                        self.IDENTIFIER,
                        f"person has accountStatus '{entry.single('accountStatus')}'"
                        f" (comment: {entry.single('accountComment')}) locked for longer than 6 months",
                        person=person)
Enrico Zini's avatar
Enrico Zini committed
253

Enrico Zini's avatar
Enrico Zini committed
254
    def run_main(self, stage):
Enrico Zini's avatar
Enrico Zini committed
255
        # Prefetch people and index them by uid
Enrico Zini's avatar
Enrico Zini committed
256
        people_by_uid = {}
257
        for p in bmodels.Person.objects.all():
258
            if p.ldap_fields.uid is None:
Enrico Zini's avatar
Enrico Zini committed
259
                continue
260
            people_by_uid[p.ldap_fields.uid] = p
261

262
        for entry in udldap.list_people():
263
            person = people_by_uid.get(entry.uid, None)
264
265

            if person is None:
Enrico Zini's avatar
Enrico Zini committed
266
                self.check_unmapped_ldap_entry(entry)
267
            else:
Enrico Zini's avatar
Enrico Zini committed
268
269
                dsa_status = entry.single("accountStatus")
                if dsa_status is not None:
Enrico Zini's avatar
Enrico Zini committed
270
271
272
                    parsed = dsa_status.split()
                    dsa_status = parsed[0]
                    if len(parsed) > 1:
273
                        try:
Enrico Zini's avatar
Enrico Zini committed
274
                            dsa_status_date = datetime.datetime.strptime(parsed[1], "%Y-%m-%d").date()
Enrico Zini's avatar
Enrico Zini committed
275
                        except ValueError:
276
277
278
                            Inconsistency.objects.found(
                                self.IDENTIFIER,
                                "person has accountStatus '{entry.single('accountStatus')}'"
279
                                " (comment: {entry.single('accountComment')}) with non-parsable date",
280
                                person=person)
Enrico Zini's avatar
Enrico Zini committed
281
282
283
284
                            dsa_status_date = None
                    else:
                        dsa_status_date = None
                    if dsa_status not in ("retiring", "inactive", "memorial", "locked", "renamed"):
285
286
                        Inconsistency.objects.found(
                            self.IDENTIFIER,
Mattia Rizzolo's avatar
Mattia Rizzolo committed
287
                            f"person has unknown accountStatus {entry.single('accountStatus')}",
288
                            person=person)
Enrico Zini's avatar
Enrico Zini committed
289
290
291
292
293
                    else:
                        self.check_account_status(person, entry, dsa_status, dsa_status_date)
                else:
                    # Account does not seem locked in LDAP, see if there are
                    # DDs we don't expect
Enrico Zini's avatar
Enrico Zini committed
294
                    if entry.is_dd:
Enrico Zini's avatar
Enrico Zini committed
295
                        if person.status not in (const.STATUS_DD_U, const.STATUS_DD_NU):
296
297
298
299
300
                            Inconsistency.objects.found(
                                self.IDENTIFIER,
                                "person has supplementaryGid 'Debian',"
                                f" but in our db the state is {const.ALL_STATUS_DESCS[person.status]}",
                                person=person)
Enrico Zini's avatar
Enrico Zini committed
301
302
                    else:
                        if person.status in (const.STATUS_DD_U, const.STATUS_DD_NU):
303
304
305
306
307
                            Inconsistency.objects.found(
                                self.IDENTIFIER,
                                "person has no supplementaryGid 'Debian',"
                                f" but in our db the state is {const.ALL_STATUS_DESCS[person.status]}",
                                person=person)
308
309

                email = entry.single("emailForward")
310
                if email != person.ldap_fields.email:
311
                    if email is not None:
312
                        log.info("%s: %s changing email_ldap from %s to %s (source: LDAP)",
Enrico Zini's avatar
Enrico Zini committed
313
                                 self.IDENTIFIER, self.hk.link(person), person.email, email)
314
                        person.ldap_fields.email = email
Enrico Zini's avatar
Enrico Zini committed
315
316
317
                        person.ldap_fields.save(
                                audit_author=self.hk.housekeeper.user,
                                audit_notes="updated ldap_fields.email from LDAP")
318
319
320
321
322
323
324
                    # It gives lots of errors when run outside of the debian.org
                    # network, since emailForward is not exported there, and it has
                    # no use case I can think of so far
                    #
                    # else:
                    #     log.info("%s: %s has email %s but emailForward is empty in LDAP",
                    #              self.IDENTIFIER, self.hk.link(person), person.email)
325
326
327

                # Update name information if it changes in LDAP
                for field in "cn", "mn", "sn":
328
                    old = getattr(person.ldap_fields, field)
329
330
331
332
333
334
                    new = entry.single(field)
                    if new is not None:
                        new = new.strip()
                    else:
                        new = ""
                    if old != new:
335
                        log.info("%s: %s changing %s from %s to %s (source: LDAP)",
Enrico Zini's avatar
Enrico Zini committed
336
                                 self.IDENTIFIER, self.hk.link(person), field, old, new)
337
338
                        setattr(person.ldap_fields, field, new)
                        person.ldap_fields.save(
Enrico Zini's avatar
Enrico Zini committed
339
                                audit_author=self.hk.housekeeper.user,
340
                                audit_notes="updated ldap_fields.{} from LDAP".format(field))