dsa: refactor test flow

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

dsa/tests/test_models.py

@@ -7,35 +7,30 @@ import django.db
 
 class TestLDAPFields(TestCase):
     def test_uid(self):
-        person = Person.objects.create_user(fullname="Test", email="test@example.org", audit_skip=True)
+        person = Person.objects.create_user(
+            fullname="Test", email="test@example.org", audit_skip=True
+        )
         f = LDAPFields.objects.create(person=person, cn="Test", audit_skip=True)
         f.uid = "foo"
         f.full_clean()
         f.save(audit_skip=True)
-        f.uid = "foo-guest"
-        with self.assertRaises(ValidationError):
-            f.full_clean()
-
-        f.uid = "bo"
-        with self.assertRaises(ValidationError):
-            f.full_clean()
-
-        f.uid = "fooBar"
-        with self.assertRaises(ValidationError):
-            f.full_clean()
-
-        f.uid = "foo.bar"
-        with self.assertRaises(ValidationError):
-            f.full_clean()
-
-        f.uid = "root"
-        with self.assertRaises(ValidationError):
-            f.full_clean()
+        for u in (
+            "foo-guest",
+            "bo",
+            "fooBar",
+            "foo.bar",
+            "root",
+        ):
+            f.uid = u
+            with self.assertRaises(ValidationError):
+                f.full_clean()
 
         # Test duplicate checks on uid
         self.assertEqual(LDAPFields.objects.filter(uid="foo").count(), 1)
 
-        person1 = Person.objects.create_user(fullname="Test1", email="test1@example.org", audit_skip=True)
+        person1 = Person.objects.create_user(
+            fullname="Test1", email="test1@example.org", audit_skip=True
+        )
         f1 = LDAPFields.objects.create(person=person1, cn="Test1", audit_skip=True)
         f1.uid = "foo"
         with self.assertRaises(ValidationError):