dsa: forbid - in usernames

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

dsa/models.py

@@ -85,6 +85,12 @@ class LDAPFields(models.Model):
                     "uid": _("DSA expressed a preference against dots in usernames."
                              " Contact debian-admin@lists.debian.org for details."),
                 })
+            # See RT#8583: - breaks the email address extension.
+            if self.uid and "-" in self.uid:
+                raise ValidationError({
+                    "uid": _("DSA forbids dashes in usernames."
+                             " Contact debian-admin@lists.debian.org for details."),
+                })
             if self.uid and self.uid in dam_forbidden_uids:
                 raise ValidationError({
                     "uid": _("The requested UID is a system user or a well known alias,"

dsa/tests/test_models.py

@@ -19,6 +19,7 @@ class TestLDAPFields(TestCase):
             "bo",
             "fooBar",
             "foo.bar",
+            "foo-bar",
             "root",
         ):
             f.uid = u