Skip to content
GitLab
Commit 7e5e0fe9 authored by Enrico Zini's avatar Enrico Zini
Browse files

Refactored so that checkers can share a common state

parent b2b0a5af
Hide whitespace changes
Inline Side-by-side
maintenance/management/commands/maintenance.py
View file @ 7e5e0fe9
......@@ -26,101 +26,127 @@ import logging
import ldap
from backend import models as bmodels
from backend import const
import keyring.models as kmodels
log = logging.getLogger(__name__)
@transaction.commit_on_success
def compute_am_ctte(**kw):
from django.db.models import Max
# Set all to False
bmodels.AM.objects.update(is_am_ctte=False)
cutoff = datetime.datetime.utcnow()
cutoff = cutoff - datetime.timedelta(days=30*6)
# Set the active ones to True
cursor = connection.cursor()
cursor.execute("""
SELECT am.id
FROM am
JOIN process p ON p.manager_id=am.id AND p.progress IN (%s, %s)
JOIN log ON log.process_id=p.id AND log.logdate > %s
WHERE am.is_am AND NOT am.is_fd AND NOT am.is_dam
GROUP BY am.id
""", (const.PROGRESS_DONE, const.PROGRESS_CANCELLED, cutoff))
ids = [x[0] for x in cursor]
bmodels.AM.objects.filter(id__in=ids).update(is_am_ctte=True)
log.info("%d CTTE members", bmodels.AM.objects.filter(is_am_ctte=True).count())
@transaction.commit_on_success
def compute_process_is_active(**kw):
"""
Compute Process.is_active from Process.progress
"""
cursor = connection.cursor()
cursor.execute("""
UPDATE process SET is_active=(progress NOT IN (%s, %s))
""", (const.PROGRESS_DONE, const.PROGRESS_CANCELLED))
transaction.commit_unless_managed()
log.info("%d/%d active processes",
bmodels.Process.objects.filter(is_active=True).count(),
cursor.rowcount)
def check_one_process_per_person(**kw):
"""
Check that one does not have more than one open process at the current time
"""
from django.db.models import Count
for p in bmodels.Person.objects.filter(processes__is_active=True) \
.annotate(num_processes=Count("processes")) \
.filter(num_processes__gt=1):
log.warning("%s has %d open processes", p, p.num_processes)
for idx, proc in enumerate(p.processes.filter(is_active=True)):
log.warning(" %d: %s (%s)", idx+1, proc.applying_for, proc.progress)
def check_am_must_have_uid(**kw):
"""
Check that one does not have more than one open process at the current time
"""
from django.db.models import Count
for am in bmodels.AM.objects.filter(person__uid=None):
log.warning("AM %d (person %d %s) has no uid", am.id, am.person.id, am.person.email)
def check_status_progress_match(**kw):
"""
Check that the last process with progress 'done' has the same
'applying_for' as the person status
"""
from django.db.models import Max
for p in bmodels.Person.objects.all():
try:
last_proc = bmodels.Process.objects.filter(person=p, progress=const.PROGRESS_DONE).annotate(ended=Max("log__logdate")).order_by("-ended")[0]
except IndexError:
continue
if p.status != last_proc.applying_for:
log.warning("%s has status %s but the last completed process was applying for %s",
p.uid, p.status, last_proc.applying_for)
def check_enums(**ks):
"""
Consistency check of enum values
"""
statuses = [x[1] for x in const.ALL_STATUS]
progresses = [x[1] for x in const.ALL_PROGRESS]
for p in bmodels.Person.objects.exclude(status__in=statuses):
log.warning("person %s has invalid status %s", p.lookup_key, p.status)
for p in bmodels.Process.objects.exclude(applying_for__in=statuses):
log.warning("process %s has invalid applying_for %s", p.lookup_key, p.applying_for)
for p in bmodels.Process.objects.exclude(progress__in=progresses):
log.warning("process %s has invalid progress %s", p.lookup_key, p.progress)
for l in bmodels.Log.objects.exclude(progress__in=progresses):
log.warning("log entry %s has invalid progress %s", l.id, l.progress)
class Checker(object):
@transaction.commit_on_success
def compute_am_ctte(self, **kw):
from django.db.models import Max
# Set all to False
bmodels.AM.objects.update(is_am_ctte=False)
cutoff = datetime.datetime.utcnow()
cutoff = cutoff - datetime.timedelta(days=30*6)
# Set the active ones to True
cursor = connection.cursor()
cursor.execute("""
SELECT am.id
FROM am
JOIN process p ON p.manager_id=am.id AND p.progress IN (%s, %s)
JOIN log ON log.process_id=p.id AND log.logdate > %s
WHERE am.is_am AND NOT am.is_fd AND NOT am.is_dam
GROUP BY am.id
""", (const.PROGRESS_DONE, const.PROGRESS_CANCELLED, cutoff))
ids = [x[0] for x in cursor]
bmodels.AM.objects.filter(id__in=ids).update(is_am_ctte=True)
log.info("%d CTTE members", bmodels.AM.objects.filter(is_am_ctte=True).count())
@transaction.commit_on_success
def compute_process_is_active(self, **kw):
"""
Compute Process.is_active from Process.progress
"""
cursor = connection.cursor()
cursor.execute("""
UPDATE process SET is_active=(progress NOT IN (%s, %s))
""", (const.PROGRESS_DONE, const.PROGRESS_CANCELLED))
transaction.commit_unless_managed()
log.info("%d/%d active processes",
bmodels.Process.objects.filter(is_active=True).count(),
cursor.rowcount)
def check_one_process_per_person(self, **kw):
"""
Check that one does not have more than one open process at the current time
"""
from django.db.models import Count
for p in bmodels.Person.objects.filter(processes__is_active=True) \
.annotate(num_processes=Count("processes")) \
.filter(num_processes__gt=1):
log.warning("%s has %d open processes", p, p.num_processes)
for idx, proc in enumerate(p.processes.filter(is_active=True)):
log.warning(" %d: %s (%s)", idx+1, proc.applying_for, proc.progress)
def check_am_must_have_uid(self, **kw):
"""
Check that one does not have more than one open process at the current time
"""
from django.db.models import Count
for am in bmodels.AM.objects.filter(person__uid=None):
log.warning("AM %d (person %d %s) has no uid", am.id, am.person.id, am.person.email)
def check_status_progress_match(self, **kw):
"""
Check that the last process with progress 'done' has the same
'applying_for' as the person status
"""
from django.db.models import Max
for p in bmodels.Person.objects.all():
try:
last_proc = bmodels.Process.objects.filter(person=p, progress=const.PROGRESS_DONE).annotate(ended=Max("log__logdate")).order_by("-ended")[0]
except IndexError:
continue
if p.status != last_proc.applying_for:
log.warning("%s has status %s but the last completed process was applying for %s",
p.uid, p.status, last_proc.applying_for)
def check_enums(self, **kw):
"""
Consistency check of enum values
"""
statuses = [x[1] for x in const.ALL_STATUS]
progresses = [x[1] for x in const.ALL_PROGRESS]
for p in bmodels.Person.objects.exclude(status__in=statuses):
log.warning("person %s has invalid status %s", p.lookup_key, p.status)
for p in bmodels.Process.objects.exclude(applying_for__in=statuses):
log.warning("process %s has invalid applying_for %s", p.lookup_key, p.applying_for)
for p in bmodels.Process.objects.exclude(progress__in=progresses):
log.warning("process %s has invalid progress %s", p.lookup_key, p.progress)
for l in bmodels.Log.objects.exclude(progress__in=progresses):
log.warning("log entry %s has invalid progress %s", l.id, l.progress)
def check_corner_cases(self, **kw):
"""
Check for known corner cases, to be fixed somehow eventually maybe in case
they give trouble
"""
c = bmodels.Person.objects.filter(processes__isnull=True).count()
if c > 0:
log.warning("%d Great Ancients found who have no Process entry", c)
c = bmodels.Person.objects.filter(status_changed__isnull=True).count()
if c > 0:
log.warning("%d entries still have a NULL status_changed date", c)
def run(self, **opts):
"""
Run all checker functions
"""
import inspect
for prefix in ("backup", "compute", "check"):
for name, meth in inspect.getmembers(self, predicate=inspect.ismethod):
if not name.startswith(prefix + "_"): continue
log.info("running %s", name)
meth(**opts)
class Command(BaseCommand):
......@@ -137,9 +163,5 @@ class Command(BaseCommand):
else:
logging.basicConfig(level=logging.INFO, stream=sys.stderr, format=FORMAT)
# Run procedures
for prefix in ("backup", "compute", "check"):
for k, v in sorted(globals().iteritems()):
if not k.startswith(prefix + "_"): continue
log.info("running %s", k)
v(**opts)
checker = Checker()
checker.run(**opts)
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment