The <tt> tag is deprecated, according to:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt

The <code> tag is proposed as a replacement. It has the same intented
semantics: an inline block of code:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/code

Closes #41.

This is not simply fixing up spelling and grammar, but a full (ish)
review of English language strings and translation structure. This lays
the groundwork for a more formal translation round at a later date.

Some of the phrasing will inevitably be coloured by en_GB preference,
but I don't feel any shame about that.

Now, the "Approve (old)" button is replaced by a "Approve (No RT)"
button, useful to reapprove an unapproved process without changing
anything else

The "Approve provess" button is a redirection to the
"approval/statement/create/" page, and the "approve" url is deactivated.

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Two parts of that line aren't added to the l10n catalog yet but should.

Approval becomes a Requirement of a process. When this requirement is
fulfilled, it makes the process become approved, whatever the state of
the other requirements.

Depending on the status of the approver, the StatementCreate view either
spawns a ProcessApproveRT op to send immediately a RT ticket, or just
spawns a ProcessApprove op, to approve the process.

The approval statement contains the RT ticket that is sent or not. In
the case it's not, a housekeeping job could iterate through the
processes on a regular basis and as soon as the approval requirement is
old enough, spawn a RT ticket using the approval statement.

To avoid issues with testing instances, the ProcessApproveRT has been
reworked in order for the RT part to be mocked, returning 0
systematically.

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Also extract to a shared CSS class whilst here.

urbec authored Mar 02, 2020 and Mattia Rizzolo committed Mar 06, 2020

Closes: #952939
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Adding Django related i18n template tags so the string can be extracted
and filled into the language related .po files.

If a process is approved and/or closed then it doesn't make sense to
open an RT ticket for it, so don't show those links if this is the case.

Closes: #882707

We were only showing RT ticket numbers when a process was approved
but not yet processed + closed. It's still useful once the process
is closed, so show it then also.

Closes: #882706