Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

fix tests after the previous commit (and also add a specific test, so to check the None/not-None possible values)
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

For example, it may link to a RT ticket.
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Hopefully this will fix this error:

RuntimeError: ('{} returned error code {}. Stderr: {}', '/usr/bin/gpg --homedir /srv/nm.debian.org/nm2/data/keyring-maint.gpg.tmp --keyserver keyring.debian.org -q --no-default-keyring --no-auto-check-trustdb --no-permission-warning --recv 0E3A94C3E83002DAB88CCA1694FA372B2DA8B985 A4626CBAFF376039D2D7554497BA9CE761A0963B AB41C1C68AFD668CA045EBF8673A03E4C1DB921F 0EE5BE979282D80B9F7540F1CCD2ED94D21739E9', 2, b"gpg: cannot open '/dev/tty': No such device or address\n")
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Rather than relying on (often unreliable) 3rd party keyservers, use
keyring.debian.org for updating the keyring-maint keys - in this
instance we know the keys are already present in the Debian keyring
so this limitation of keyring.d.o is not a problem.

did we managed to get by only chance till now?
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Thanks: Jeorg for noticing it
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

It was causing missing date on the various
    For nm.debian.org, at {{now}}:
lines.

Alternatively templates could have used the {% now %} tag, but I'm going
with the smaller change.
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

MR: !5Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Closes: #907421
Thanks: Pierre-Elliott Bécue <becue@crans.org> for the patch!
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

John has joined keyring-maint and did most of the last update, so
plumb his details (email → UID mapping, fingerprint) into the keyring
git checking infrastructure.

the code would crash while parsing a `gpg --check-sigs` output with
lines like:

sig:%::22:485E1BD3AE76CB72:1506259130::::[Invalid signature class] :10x::0064BBAEF91E13B2BCF21889485E1BD3AE76CB72:::8:

that, by their nature, would be first, before any uid.

This happened on process 124, causing the following crash in production:

|File "/usr/lib/python3/dist-packages/django/core/handlers/exception.py" in inner
|  42.             response = get_response(request)
|
|File "/usr/lib/python3/dist-packages/django/core/handlers/base.py" in _legacy_get_response
|  249.             response = self._get_response(request)
|
|File "/usr/lib/python3/dist-packages/django/core/handlers/base.py" in _get_response
|  217.                 response = self.process_exception_by_middleware(e, request)
|
|File "/usr/lib/python3/dist-packages/django/core/handlers/base.py" in _get_response
|  215.                 response = response.render()
|
|File "/usr/lib/python3/dist-packages/django/template/response.py" in render
|  109.             self.content = self.rendered_content
|
|File "/usr/lib/python3/dist-packages/django/template/response.py" in rendered_content
|  86.         content = template.render(context, self._request)
|
|File "/usr/lib/python3/dist-packages/django/template/backends/django.py" in render
|  66.             return self.template.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render
|  208.                     return self._render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in _render
|  199.         return self.nodelist.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render
|  994.                 bit = node.render_annotated(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
|  961.             return self.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/loader_tags.py" in render
|  174.         return compiled_parent._render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in _render
|  199.         return self.nodelist.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render
|  994.                 bit = node.render_annotated(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
|  961.             return self.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/loader_tags.py" in render
|  174.         return compiled_parent._render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in _render
|  199.         return self.nodelist.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render
|  994.                 bit = node.render_annotated(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
|  961.             return self.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/loader_tags.py" in render
|  174.         return compiled_parent._render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in _render
|  199.         return self.nodelist.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render
|  994.                 bit = node.render_annotated(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
|  961.             return self.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/loader_tags.py" in render
|  70.                 result = block.nodelist.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render
|  994.                 bit = node.render_annotated(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
|  961.             return self.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/defaulttags.py" in render
|  209.                     nodelist.append(node.render_annotated(context))
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
|  961.             return self.render(context)
|
|File "/usr/lib/python3/dist-packages/django/template/defaulttags.py" in render
|  508.                   six.iteritems(self.extra_context)}
|
|File "/usr/lib/python3/dist-packages/django/template/defaulttags.py" in <dictcomp>
|  507.         values = {key: val.resolve(context) for key, val in
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in resolve
|  711.                 obj = self.var.resolve(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in resolve
|  852.             value = self._resolve_lookup(context)
|
|File "/usr/lib/python3/dist-packages/django/template/base.py" in _resolve_lookup
|  915.                             current = current()
|
|File "/srv/nm.debian.org/nm2/process/models.py" in compute_status
|  417.         return meth()
|
|File "/srv/nm.debian.org/nm2/process/models.py" in compute_status_keycheck
|  510.                     keycheck = key.keycheck()
|
|File "/srv/nm.debian.org/nm2/keyring/models.py" in keycheck
|  268.         keys = KeyData.read_from_gpg(self.check_sigs.splitlines())
|
|File "/srv/nm.debian.org/nm2/keyring/models.py" in read_from_gpg
|  509.                     raise Exception("gpg:{}: found sig line with no previous uid line".format(lineno))
|
|Exception Type: Exception at /process/124
|Exception Value: gpg:4: found sig line with no previous uid line
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Reorder elements in rt_ticket template

See merge request !4

We put fingerprint and uid first, as that are the most
relevant items for DSA, and probably also for keyring.

Also, rename "Username" to "uid".

MR: !3Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>