1. 28 Nov, 2018 2 commits
  2. 27 Nov, 2018 2 commits
    • Mattia Rizzolo's avatar
      use --batch when calling gpg · 212f847e
      Mattia Rizzolo authored
      Hopefully this will fix this error:
      
      RuntimeError: ('{} returned error code {}. Stderr: {}', '/usr/bin/gpg --homedir /srv/nm.debian.org/nm2/data/keyring-maint.gpg.tmp --keyserver keyring.debian.org -q --no-default-keyring --no-auto-check-trustdb --no-permission-warning --recv 0E3A94C3E83002DAB88CCA1694FA372B2DA8B985 A4626CBAFF376039D2D7554497BA9CE761A0963B AB41C1C68AFD668CA045EBF8673A03E4C1DB921F 0EE5BE979282D80B9F7540F1CCD2ED94D21739E9', 2, b"gpg: cannot open '/dev/tty': No such device or address\n")
      Signed-off-by: Mattia Rizzolo's avatarMattia Rizzolo <mattia@debian.org>
      212f847e
    • Mattia Rizzolo's avatar
      flake8 keyring/housekeeping · fd919330
      Mattia Rizzolo authored
      Signed-off-by: Mattia Rizzolo's avatarMattia Rizzolo <mattia@debian.org>
      fd919330
  3. 26 Nov, 2018 1 commit
    • Jonathan McDowell's avatar
      Use keyring.debian.org for keyring-maint keys · f0bf2232
      Jonathan McDowell authored
      Rather than relying on (often unreliable) 3rd party keyservers, use
      keyring.debian.org for updating the keyring-maint keys - in this
      instance we know the keys are already present in the Debian keyring
      so this limitation of keyring.d.o is not a problem.
      f0bf2232
  4. 22 Oct, 2018 5 commits
  5. 13 Oct, 2018 1 commit
  6. 03 Oct, 2018 3 commits
  7. 01 Oct, 2018 4 commits
  8. 29 Sep, 2018 1 commit
  9. 30 Aug, 2018 1 commit
  10. 25 Aug, 2018 3 commits
    • Mattia Rizzolo's avatar
      Do not crash on invalid signatures · d36112a3
      Mattia Rizzolo authored
      the code would crash while parsing a `gpg --check-sigs` output with
      lines like:
      
      sig:%::22:485E1BD3AE76CB72:1506259130::::[Invalid signature class] :10x::0064BBAEF91E13B2BCF21889485E1BD3AE76CB72:::8:
      
      that, by their nature, would be first, before any uid.
      
      This happened on process 124, causing the following crash in production:
      
      |File "/usr/lib/python3/dist-packages/django/core/handlers/exception.py" in inner
      |  42.             response = get_response(request)
      |
      |File "/usr/lib/python3/dist-packages/django/core/handlers/base.py" in _legacy_get_response
      |  249.             response = self._get_response(request)
      |
      |File "/usr/lib/python3/dist-packages/django/core/handlers/base.py" in _get_response
      |  217.                 response = self.process_exception_by_middleware(e, request)
      |
      |File "/usr/lib/python3/dist-packages/django/core/handlers/base.py" in _get_response
      |  215.                 response = response.render()
      |
      |File "/usr/lib/python3/dist-packages/django/template/response.py" in render
      |  109.             self.content = self.rendered_content
      |
      |File "/usr/lib/python3/dist-packages/django/template/response.py" in rendered_content
      |  86.         content = template.render(context, self._request)
      |
      |File "/usr/lib/python3/dist-packages/django/template/backends/django.py" in render
      |  66.             return self.template.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render
      |  208.                     return self._render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in _render
      |  199.         return self.nodelist.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render
      |  994.                 bit = node.render_annotated(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
      |  961.             return self.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/loader_tags.py" in render
      |  174.         return compiled_parent._render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in _render
      |  199.         return self.nodelist.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render
      |  994.                 bit = node.render_annotated(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
      |  961.             return self.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/loader_tags.py" in render
      |  174.         return compiled_parent._render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in _render
      |  199.         return self.nodelist.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render
      |  994.                 bit = node.render_annotated(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
      |  961.             return self.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/loader_tags.py" in render
      |  174.         return compiled_parent._render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in _render
      |  199.         return self.nodelist.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render
      |  994.                 bit = node.render_annotated(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
      |  961.             return self.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/loader_tags.py" in render
      |  70.                 result = block.nodelist.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render
      |  994.                 bit = node.render_annotated(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
      |  961.             return self.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/defaulttags.py" in render
      |  209.                     nodelist.append(node.render_annotated(context))
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in render_annotated
      |  961.             return self.render(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/defaulttags.py" in render
      |  508.                   six.iteritems(self.extra_context)}
      |
      |File "/usr/lib/python3/dist-packages/django/template/defaulttags.py" in <dictcomp>
      |  507.         values = {key: val.resolve(context) for key, val in
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in resolve
      |  711.                 obj = self.var.resolve(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in resolve
      |  852.             value = self._resolve_lookup(context)
      |
      |File "/usr/lib/python3/dist-packages/django/template/base.py" in _resolve_lookup
      |  915.                             current = current()
      |
      |File "/srv/nm.debian.org/nm2/process/models.py" in compute_status
      |  417.         return meth()
      |
      |File "/srv/nm.debian.org/nm2/process/models.py" in compute_status_keycheck
      |  510.                     keycheck = key.keycheck()
      |
      |File "/srv/nm.debian.org/nm2/keyring/models.py" in keycheck
      |  268.         keys = KeyData.read_from_gpg(self.check_sigs.splitlines())
      |
      |File "/srv/nm.debian.org/nm2/keyring/models.py" in read_from_gpg
      |  509.                     raise Exception("gpg:{}: found sig line with no previous uid line".format(lineno))
      |
      |Exception Type: Exception at /process/124
      |Exception Value: gpg:4: found sig line with no previous uid line
      Signed-off-by: Mattia Rizzolo's avatarMattia Rizzolo <mattia@debian.org>
      d36112a3
    • Mattia Rizzolo's avatar
    • Mattia Rizzolo's avatar
      flake8 fixes on keyring/models.py · f1c9a06f
      Mattia Rizzolo authored
      Signed-off-by: Mattia Rizzolo's avatarMattia Rizzolo <mattia@debian.org>
      f1c9a06f
  11. 11 Aug, 2018 1 commit
  12. 05 Aug, 2018 1 commit
  13. 04 Aug, 2018 4 commits
  14. 30 Jul, 2018 1 commit
  15. 25 Jul, 2018 2 commits
  16. 23 Jul, 2018 1 commit
  17. 10 Jul, 2018 2 commits
  18. 03 Jul, 2018 2 commits
  19. 01 Jul, 2018 3 commits