1. 14 Mar, 2018 3 commits
    • Nikita Krishnia-INTERN's avatar
      Set default License Status message to request license server details when QDWS... · dff02b94
      Nikita Krishnia-INTERN authored
      Set default License Status message to request license server details when QDWS is selected and license features are enabled.
      *On licensed setup, if license server details are modified through
       UI/gridd.conf and service is restarted, set default license status
       message to request license server details.
      *On failed attempt, handled the termination of license acquisition
       loop when vAPP is selected and license features are enabled
       on that system.
      Testing done:
      Verified on NMOS, correct license status message is displayed.
      Also, on failed attempt license acquisition loop stops when
      vAPP is selected.
    • Nikita Krishnia-INTERN's avatar
      Once licensed, switching to a different feature requires a system reboot,... · 82ffaf9a
      Nikita Krishnia-INTERN authored
      Once licensed, switching to a different feature requires a system reboot, notify user about the same.
      On licensed NMOS setup, if user restarts nvidia-gridd service and
      selected 'GRID Virtual Apps' license edition. There is mismatch in
      licensed feature type enabled in the driver and feature type read from
      gridd.conf/UI control. In this change, notify user that license features
      are still enabled in the driver even if license is released and hence restart is
      required. Set appropriate license status message to indicate the same.
      Added NV_CTRL_ATTR_NVML_GPU_GRID_LICENSABLE_FEATURES attribute to get feature code
      of the currently licensed feature.
      Used the existing NVML api nvmlDeviceGetGridLicensableFeatures to fetch this feature code.
      And then query this licensed feature code in nvidia-settings.
      Setting the restart required status message when there is mismatch in
      the queried licensed feature type and the feature type read from gridd.conf/UI.
      Testing done:
      Verified on NMOS, correct license status message is displayed.
    • Nikita Krishnia-INTERN's avatar
      Auto-reflect runtime changes in nvidia settings when the nvidia-gridd is restarted/stopped. · da89797d
      Nikita Krishnia-INTERN authored
      Issue and root cause:
      When 'Manage License' page is created , a timer callback is registered to
      query license state from nvidia-gridd with 1 sec time interval to
      update the 'Manage License' page. When nvidia-gridd service is stopped,
      there is no response against the Dbus request so the callback function exits with error
      which destroys the timer. Hence 'Manage License' page is never updated.
      Do not destroy the timer which updates the 'Manage license' page even if 'nvidia-gridd' service
      is stopped.
      Upon failure to communicate with nvidia-gridd to fetch licensing state info
      we are disabling all UI controls and notifying user about the issue via a message on the UI.
      Testing Done:
      Verified that if nvidia-gridd service is restarted then 'Manage License' page gets
      refreshed automatically.
  2. 29 Jan, 2018 2 commits
  3. 04 Jan, 2018 11 commits
    • Aaron Plattner's avatar
      390.12 · 7bcf8ff2
      Aaron Plattner authored
    • Devi Sravani Simhadri's avatar
      Fixing nvidia-settings to update config parameters into gridd.conf file... · 5ab3031e
      Devi Sravani Simhadri authored
      Fixing nvidia-settings to update config parameters into gridd.conf file correctly once the user clicks apply.
      Issue : By default, EnableUI config parameter is true for 5.0 drivers.
              nvidia-settings writes "EnableUI=TRUE" to gridd.conf file if the user
              has applied license via UI. Since the user config options in gridd.conf
              persist on driver upgrade we see the UI is enabled with 5.1 drivers.
              The same issue is also encountered on driver upgrade from 5.0 to 6.0
      Fix : User has to manually delete the gridd.conf file and create a new one with
            the gridd.conf.template file provided.
            Made the following changes:
            1. On launching nvidia-settings, if there is no gridd.conf file available,
               no new gridd.conf file will be created.  A new gridd.conf file will be
               created only when user clicks apply button via UI.
            2. While updating the griddConfig structure with the user provided values
               from UI, the corresponding config parameter will be updated only if it
               differs from the currently provided value by the user.
    • Nikita Krishnia-INTERN's avatar
      Modified logic to update status/messages on 'Manage License Page' and rename... · 2f557912
      Nikita Krishnia-INTERN authored
      Modified logic to update status/messages on 'Manage License Page' and rename "Tesla(unlicensed)" string to "GRID Virtual Apps"
      - From nvidia-gridd, fetching license state from the state machine. Sending this
        license state instead of license status to nvidia-settings.
      - According to license state and featureType fetched from nvidia-gridd, setting
        license status on nvidia-settings side.
      - Updated all license status messages to latest reviewed strings.
      - Renamed "Tesla(unlicensed)" string to "GRID Virtual Apps".
    • Nikita Krishnia-INTERN's avatar
      Modifications in the sensitivity of Apply/Cancel button in 'Manage License'... · 2fb5615f
      Nikita Krishnia-INTERN authored
      Modifications in the sensitivity of Apply/Cancel button in 'Manage License' page of nvidia-settings:
      Apply/Cancel button is disabled post moving from "Quadro Virtual" "Datacenter
      Workstation" license edition to "Unlicensed Tesla" license edition.
      Apply/Cancel buttons are enabled only under following cases:
      * If the License Edition has changed, that is the corresponding feature type
        selection has changed.
      * If any of the textbox entry has changed.
      Also updating the license Acquiring, unlicensed and failed message strings on UI
      according to the feature type selection.
    • Jonathan Waddell's avatar
      Update available SLI Mosaic options to support options for 32 displays · 8bb5cbaa
      Jonathan Waddell authored
      Simple change to add a couple combinations of 32 display options to the SLI
      Mosaic Grid Config dropdown
    • Nikita Krishnia-INTERN's avatar
      Setting feature type correctly on 'Manage GRID License' page creation. · 650de750
      Nikita Krishnia-INTERN authored
      When nvidia-settings is launched on a Quadro vDWS Edition licensed VM, the
      message shown on 'Manage GRID License' page as well as the one logged in
      /var/log/messages incorrectly states that the system has switched to Tesla
      (unlicensed) and user needs to reboot the system.
      Root cause and fix:
      Issue was observed because the feature type was not set correctly on page
      creation. Fixed it with this change.
      Testing done:
      Verified on NMOS and vGPU setup,correct feature type is displayed in the message
      over UI and in /var/log/messages as well.
    • Trupti Pimparkar's avatar
    • Pablo De La Garza's avatar
      Stereo Test · 635666ba
      Pablo De La Garza authored
      It had been requested to provide end users with a way to test if stereo mode has
      been configured and is working properly.
      To address such, it was decided to create a simple demo/test and to get such app
      embedded in nvidia settings by creating a custom gtk widget on which to render
      opengl. (Such widget seems to exist, but only in versions of gtk3 that are newer
      to what nvidia-settings use, hence the need to create our own).
      This implementation will work with gtk3 and ignored on gtk2.
    • Andy Ritger's avatar
    • Benjamin Morris's avatar
      Enhance InbandStereoSignaling support · 9a680076
      Benjamin Morris authored
      This change adds a new stereo mode (14) to represent the current combination of
      stereo mode 3 with InbandStereoSignaling.
    • Aaron Plattner's avatar
      Update nvml.h · 6351cbbd
      Aaron Plattner authored
  4. 27 Nov, 2017 1 commit
  5. 30 Oct, 2017 2 commits
    • Aaron Plattner's avatar
      387.22 · af2d4dd1
      Aaron Plattner authored
    • Nikita Krishnia-INTERN's avatar
      UI control modifications in 'Manage License' page of nvidia-settings: · 6bd0fa4d
      Nikita Krishnia-INTERN authored
      * Added a new cancel button, which clears all changes made in the fields.
      * If Primary server address is empty:
              * Apply/Cancel buttons and Secondary server address/port disabled.
              * Enable Apply/Cancel buttons and Secondary server address/port only
                when there is text entered in Primary server address textbox to nofity
                user that Primary server address is mandatory.
      * If Primary server address is non-empty:
              * User can edit Secondary server address/port.
      * Apply/Cancel buttons Grayed out after applying click.
      * Enable Apply/Cancel buttons when text entered in any of the textboxes is
        different than the earlier entered text.
      * On launch of 'Manage License' page, Apply/Cancel buttons are disabled.
      Testing done:
      Verified the above modified functionality of 'Manage License' page on NMOS and vGPU.
  6. 03 Oct, 2017 14 commits
    • Aaron Plattner's avatar
      387.12 · d9436550
      Aaron Plattner authored
    • Aaron Plattner's avatar
      Update nvml.h · bd24d2fd
      Aaron Plattner authored
    • Jonathan Waddell's avatar
      Set Rotation and Reflection to only the current modes when using Basic Configuration · 3722e02d
      Jonathan Waddell authored
      Currently when the Display Configuration page of nvidia-settings is in Basic mode, any changes to the Rotation and Reflection values are applied to all modes for that display. This causes our entire list of metamodes to be updated and when we cancel a modeset, those updated metamodes are not reverted. Even if we do revert them on the server, our internal data structures do not represent these metamodes and resetting the UI to force a sync would cause the loss of all user config options currently chosen but not applied.
      This change modifies the behavior of Basic Mode configurations that involve rotation and reflection. These changes will make these metamode changes to behave similarly to advanced mode changes in that they will only affect the current metamode. On the UI side, in basic mode, we will make sure that if rotation/reflection is selected and the resolution is changed (effectively changing to a different selected mode) we will make sure the adjustments are carried over to the new mode.
      A user using the UI exclusively should not see any changes in behavior aside from the actual issue fixed. A user checking the available metamodes on the server would see a difference but it would be identical to the metamodes given by the unchanged Configuration method in Advanced Mode.
    • Jonathan Waddell's avatar
      Add text to the help page for widgets missing entries. · 34bd15d6
      Jonathan Waddell authored
      This change adds help text for the "Save Current Configuration" button on the "nvidia-settings Configuration" page and re-enables a flag that allows the help text for "Sync to this display device" on the XVideo Settings page.
      Also removes the per entry tooltip text for the "Sync to this display device" and adds the tooltip to the entire container widget since it exists for the entire lifetime of the application.
    • Pablo De La Garza's avatar
      Fix for un-initialized variables valgrind error · 245cc37e
      Pablo De La Garza authored
      The variable on this change are liable to not be initialized if the
      function that is meant to initialize errors out. And the uninitialized
      variable would still be passed for the creation of a widget. Since in
      the case of this happening such widget won't be used anyways, chances
      of this causing trouble are slim, but still we shouldn't have it.
      Additionally it shows on valgrind so it creates noise when trying to
      troubleshoot something else.
    • Jonathan Waddell's avatar
      Allow Mosaic configuration when a screen is selected. · 4025656e
      Jonathan Waddell authored
      Right now, the Enable Mosaic button is only validated properly and shown when a Display object is selected on the Display Config page of nvidia-settings. Mosaic support is a feature of the gpu and shouldn't depend on if a Display or Screen is selected. This change adds the validation and activation of the Mosaic feature with a Screen selection in addition to the existing Display selection.
    • Jonathan Waddell's avatar
      Allow moving displays to the origin even if the layout window is too large. · 52d37bf6
      Jonathan Waddell authored
      Currently, we can get in a situation where the nvidia-settings display layout window is setup to be larger than what the X server allows. The problem is if we are in this situation, the user may not be able to fix the layout because our enforcement of size limits doesn't allow the user to move displays to the origin. This is because when moving items to the left or upward, we calculate our movement limit with respect to the right-most or furthest down position used.
      This change will allow us to always move items to the origin. Note that we already always redefine the origin to be the top-left most valid item. This position should always be available when moving items.
    • Jonathan Waddell's avatar
      Keep the ECC Reset Default Config button in sync with current ECC pending status. · dc9b16d0
      Jonathan Waddell authored
      Anytime the ECC Pending Status Checkbox is set to a different value than the ECC Default Configuration value, this button should be enabled. It should be clear to the user that what the Reset button's value should be based on behavior alone.
      This change updates the enabled/disabled state of the Reset anytime we receive a update to the pending config value and or when the user changes the value manually.
    • Aaron Plattner's avatar
      Repack images with 'optipng -o7 -zm1-9' · 9a3fb673
      Aaron Plattner authored
      This saves a couple dozen KB.
       -rwxr-xr-x 1 aaron aaron 1481192 May 18 16:11 libnvidia-gtk2.so.old
       -rwxr-xr-x 1 aaron aaron 1452520 May 18 16:11 libnvidia-gtk2.so
       -rwxr-xr-x 1 aaron aaron 1477384 May 18 16:11 libnvidia-gtk3.so.old
       -rwxr-xr-x 1 aaron aaron 1444616 May 18 16:11 libnvidia-gtk3.so
    • Aaron Plattner's avatar
      Use embedded PNGs to load pixbufs · 95ae8e07
      Aaron Plattner authored
      Create a helper function, ctk_pixbuf_from_data(), and corresponding helper macro
      CTK_LOAD_PIXBUF(), to load embedded images from their internal PNG
      representation. Delete the uncompressed pixdata versions.
      This saves a few hundred KB from each of libnvidia-gtk2 and libnvidia-gtk3:
       -rwxr-xr-x 1 aaron aaron 1828552 May 18 16:06 libnvidia-gtk2.so.old
       -rwxr-xr-x 1 aaron aaron 1481192 May 18 16:07 libnvidia-gtk2.so
       -rwxr-xr-x 1 aaron aaron 1820808 May 18 16:06 libnvidia-gtk3.so.old
       -rwxr-xr-x 1 aaron aaron 1477384 May 18 16:07 libnvidia-gtk3.so
    • Aaron Plattner's avatar
      Embed the .png files into the libnvidia-gtk[23] libraries · c03ed380
      Aaron Plattner authored
      These will be used later to decompress the images at runtime.
      Generate headers that define the start and end symbols for these.
    • Jonathan Waddell's avatar
      Always check if the ECC Configuration Pending state has changed. · 4e75f74b
      Jonathan Waddell authored
      Right now on the ECC status page in nvidia-settings we poll for changes in the ECC state of the GPU. When ECC is enabled we poll for ECC errors. The problem is we only check the Configuration Pending state when the application starts up. We can detect via nvcontrol events, if this value is changed for example on the command line by "nvidia-settings -a ECCConfiguration=1". But if this value is changed by a non-nvcontrol method like "nvidia-smi -e 1", we don't detect or display the change.
      This change adds querying this value to the polling loop of the ECC Status page.
    • Aaron Plattner's avatar
      Add an AllowGSYNC MetaMode flag · da95925c
      Aaron Plattner authored
      Recognize the new flag in nvidia-settings in order to be able to write it to
    • Sachin Chitte's avatar
      Update overclocking UI to show memory clock offset and graphics clock offset independently. · 58717aa6
      Sachin Chitte authored
      On few SKU users can only set graphics clock offset and not memory clock offset.
      So updated UI to show memory clock offset and graphics clock offset, if either is editable.
  7. 21 Sep, 2017 2 commits
  8. 22 Aug, 2017 5 commits