Make fewer assumptions about build-dependencies

Simon McVittierequested to merge
smcv/freespace2:bug1012232 into master

Includes !2 (merged), please land that first.

  • d/control: Explicitly depend on libsdl1.2-dev

    libsdl-dev is a virtual package and currently has more than one implementation in unstable, so this build-depdendency results in an unpredictable one of the possible implementations being chosen.

    Helps: #1012232

  • d/control: Explicitly build-depend on pkgconf

    configure.ac invokes PKG_PROG_PKG_CONFIG, so we should explicitly build-depend on pkgconf rather than assuming that another build-dependency will pull it in.

    Helps: #1012232

  • d/control: Explicitly build-depend on libgl1-mesa-dev, libgl-dev

    code/graphics/gropengl.h includes <GL/gl.h> and <GL/glu.h>, so freespace2 should build-depend on the relevant packages, instead of assuming that another build-dependency will pull them in.

    Helps: #1012232

  • Add patch to check for malloc.h

    libsdl1.2 traditionally defined HAVE_MALLOC_H in SDL_config.h on platforms that have it, but that was never really an API guarantee, and initial versions of sdl12-compat didn't define that macro. sdl12-compat >= 1.2.64-4 in Debian, and 1.2.66 upstream, will work around this, but it's better for freespace2 to take responsibility for checking for all the headers that it needs.

    Closes: #1012232

Merge request reports