Change-Id: I733c4bcf28d845aa0413ef4af06cdab6bc25cc7b

it actually doesn't assert the value
becase we now use same if statement
for the assertion but hope it to be
even a little better than no covarage.

Change-Id: I8860a2a8227e43e02afddcbad1e108157c0872f6

...if users *really* want to. They opt-in at run time by setting

    LIBERASURECODE_WRITE_LEGACY_CRC=1

in the environment; leaving it unset, set to an empty string, or set to
the string "0" continues to write zlib crcs.

UpgradeImpact
=============
This option is intended to allow a smooth upgrade from liberasurecode
1.5.0 and earlier in a system with multiple readers and writers:

  * Before upgrade, ensure the environment variable is set on all nodes.
    This will be ignored by earlier versions.
  * Upgrade liberasurecode on each node in the system, restarting any
    services that use it. Every node continues writing CRCs that are
    still usable by nodes that have not yet upgraded.
  * Now that every node is capable of reading zlib CRCs, remove the
    environment variable from each node to start writing new CRCs.

If you are already using 1.6.0 or later, just upgrade normally.

Closes-Bug: #1886088
Closes-Bug: #1867937
Related-Bug: #1666320
Needed-By: https://review.opendev.org/#/c/739164/
Change-Id: I9adfbe631a2dddc592fd08f8a325f3e8331b92f1

Apparently upstream now requires that you log in?

Change-Id: I065ca37e5d69bb6ee3c7f00374af2e9c3da7739f

*Hopefully*, this will make it "standard" enough that GitHub will
call it out as the BSD-2-Clause that it is.

Change-Id: If097a3d86e1bd22cebbcbc160c6ae238663843c5

Compilers are getting smarter, and we started getting this:

libec_slap.c: In function 'test_hd_code':
libec_slap.c:285:14: error: 'frags.array' may be used uninitialized
 in this function [-Werror=maybe-uninitialized]

The fix is to consume the error code in such a way that the
test proceeds further only when frags are indeed initialized.

Change-Id: I54db0172a36419206d00b22608523a08818f41f6

Change-Id: I6c7a1725ba00981d45511fc3c18795737b1967cb

These aren't C strings; we shouldn't be using strncpy and friends.

Change-Id: I50cd7922dfa377ea27f3c9558a8a7268120ec733
Closes-Bug: #1859710

Change-Id: I1ab792c3c509539a73a1808b8c28c6748185ae00
Closes-Bug: 1835071

Change-Id: Ifb497f1b65588c16a61ad59165ae10bb42bceb1b

Change-Id: Iaa6cc5bb06e715aafb3ecab86ae7cde6ef30413d

This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.

...then switch CentOS job to be a voting gate job instead of
experimental.

Change-Id: I510e4da82deb779ece9ea5436b63c038a6c25b58

Apparently the author of our old crc32 assumed that shifting an int
to the right sign-extends, which is not always the case. Result is,
building and running make test on s390x fails. The fix is to force
a sign-extension using the "xor 0x80; sub 0x80" trick.

N.B. This does not cause a compatibility problem, because by a
miracle the "broken" crc32_alt was actually computing a stock
crc32, same that zlib has. Therefore, if someone, somewhere,
ran a Swift cluster on s390x with erasure coding policy,
the data in it is already stored with zlib checksums, as we
do it now anyway. This fix only permits the tests pass, which
used the bad data sample from x86.

Change-Id: Ibd5e4e6c02be00540a9648cc7e0f8efda275bf3f
Related-Change: Ib5ea2a830c7c23d66bf2ca404a3eb84ad00c5bc5
Related-Bug: 1666320

This popped up because Fedora mandates warning-free builds,
and get_chksum triggers a warning because it returns an
unaligned pointer (it is so analigned, static analysis in
the compiler can detect it).

The easiest fix is to remove it altogether. We think it should
be safe, because:

 - The function is not listed in any headers
 - Its counterpart is called "set_checksum", not "set_chksum"
 - PyECLib does not use it

We also hush some doxygen warnings about wrong comments.

Change-Id: Ie5bc736f912706e0ffd507765abd24e7f4761233

Install libraries to be tested w/ liberasurecode

Change-Id: Ic1cd7b61c780cf794640e4ce0d57e6126ad5756b

If LD_LIBRARY_PATH is set to any value, build will fail, example:
Making check in doc
...
/bin/bash: line 1: /usr/lib/libeatmydata: No such file or directory
...

See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=906480

Same is true for DYLD_LIBRARY_PATH and DYLD_FALLBACK_LIBRARY_PATH.

This bug was introduced with commit 19442df2
where Kota removed evals, but forgot to remove prepending of same env
variables.

Change-Id: Ib7a1d6b839d4a207ee0471b55233e1ce5d958705

Change-Id: I97b85f1b37952aaede168e274d2f4a74d3b9aaa8

... and vice-versa. We'll fix up frag header values for our output
parameter from liberasurecode_get_fragment_metadata but otherwise
avoid manipulating the in-memory fragment much.

Change-Id: Idd6833bdea60e27c9a0148ee28b4a2c1070be148

Add the unittests in-tree and convert them as Zuul v3 native tests so
that they can be modified locally.

This adds a new job running on Ubuntu and an experimental CentOS-7 one.

Change-Id: Ib43e40280411623fda84f2068958b64a17cdc3dc

Should make it easier to diagnose failures.

Change-Id: I32ed3019c556706634aae91844bf57b0954af86a

While we're at it, tighten up some test_create_backend_invalid_args
assertions.

Change-Id: Id6c70cdb2d86580280ededc3ec6ec648c6cb7d57

Previously, we'd segfault with args like k=1, m=3, hd=3.

Change-Id: I8a1d92f388c54fe4f5b357eaf85a27e6b334df11

This simplifies compiling by allowing users to include

   CFLAGS += `pkg-config --cflags erasurecode-1`
   LDFLAGS += `pkg-config --libs erasurecode-1`

in makefiles. Otherwise, trying to use pkg-config results in errors like

   /usr/local/lib/liberasurecode.so: undefined reference to `dlopen'
   /usr/local/lib/liberasurecode.so: undefined reference to `dlclose'
   /usr/local/lib/liberasurecode.so: undefined reference to `dlerror'
   /usr/local/lib/liberasurecode.so: undefined reference to `dlsym'
   collect2: error: ld returned 1 exit status

Change-Id: I39fb137b1a3b6b2beda1d0b28faef3132229ec3b

Otherwise, we're left with error-prone copy & pasting, which means we'll
constantly be cleaning it up.

Change-Id: I57e2cbef2c9221cffccf2e73b6af9bd003c04968
Related-Change: Ibd72ba4ae609ad77e8808aa1594b0adb62e34ef0
Related-Change: I9ee9ec3d8f86a10c4c7b5d6425a530b9c44d1156

This allows us to start defining test suites for common capabilities /
allowed failure modes.

Null Backend:
    test_decode_with_missing_parity
    test_decode_with_missing_multi_parity

Jerasure RS Vand:
    test_decode_with_missing_parity

Jerasure RS Cauchy:
    test_decode_with_missing_parity

ISA-L RS Vand:
    test_decode_with_missing_parity
    test_get_fragment_metadata_crc32

ISA-L RS Cauchy:
    test_decode_with_missing_parity
    test_get_fragment_metadata_crc32

SHSS:
    test_decode_with_missing_parity
    test_get_fragment_metadata_crc32

liberasurecode RS Vand:
    test_decode_with_missing_parity

Change-Id: I9ee9ec3d8f86a10c4c7b5d6425a530b9c44d1156

* When we specify a particular backend, we don't need to include it in
  the display string; we'll already include it in the output.

* test_destroy_backend_invalid_args shouldn't be reported as
  test_create_backend_invalid_args.

* Consistently include the leading "test_" in the display string.

Change-Id: Ibd72ba4ae609ad77e8808aa1594b0adb62e34ef0

Each was only really used in one place, they had some strange return types,
and recent versions of clang on OS X would refuse to compile with

erasurecode_helpers.c:531:26: error: taking address of packed member 'metadata_chksum' of
      class or structure 'fragment_header_s' may result in an unaligned pointer value
      [-Werror,-Waddress-of-packed-member]
    return (uint32_t *) &header->metadata_chksum;
                         ^~~~~~~~~~~~~~~~~~~~~~~

We don't really *care* about the pointer; we just want the value!

Change-Id: I8a5e42312948a75f5dd8b23b6f5ccfa7bd22eb1d