Currently we only pass the configured multipath option when getting
the connector properties and do not pass it when creating the
connector object which in turn does the multipathing in os-brick.
So we are only passing multipathing option to cinder for exporting &
mapping the volume to paths but not while creating the connector object
and hence doing multipathing partially.
This patch passes that option and fixes the stated issue.

Related-Bug: #1863983

Co-Authored-By: Gorka Eguileor <geguileo@redhat.com>

Change-Id: I82979c47ec9ec1dd6cc864d3827ab219177251f8
(cherry picked from commit 04e5ead7)
(cherry picked from commit 9bb85709)

Change-Id: I1de76a70e07bbf2bd70900b4d93104a1b0fda74b
(cherry picked from commit b93facf1)
(cherry picked from commit b42ffa40)

Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/victoria branch, tests will
continue to use the upper-constraints list on master.

Change-Id: Ib685f95ca4c9d668d2bd33ad770348d276183db9

Change-Id: I108ffbdf88c13faff3da6d6310776a8c2de2e5bf

This message is not actually an error inside the system for most of the
time.  The primary reason behind this is that it is possible that there
are VMs using this image and therefore it can't be deleted, the operator
has no actionable thing to do about this.

For those who are monitoring ERROR level messages and alerting on them,
this is noisy and not actionable, drop this error message to warning.

Change-Id: If5447c3f5b4f678943273c2bdb2e44cd25d5b226

Since the resize decisions are packed tight into a helper, it
is trivial to test the boundary conditions alone. This adds a test
to do that, including the previously-uncovered condition of the
8G resize ceiling.

Change-Id: I04b4e2f220cf93275f0b14240cbbfff3da94e4d1

This brings over the small-footprint FakeData generator from glance and
refactors the rbd resize tests to use it instead of a static string.

Change-Id: I842578ca933294e4340ba080be488999e7910727

Inside cinder, default types are returned as dictionary but the
API call return it as a object.
Correcting name reference for the same from dictionary (['name'])
to object (.name)

Change-Id: Iaf7f1174f80624a0e1f47bea3c0c0b36d2345557

This patch adds support for configuring multiple cinder stores.
The following changes are part of this patch:
1) location URL format: previously cinder://<volume-id>, the format is
now changed to cinder://<store-name>/<volume-id>
2) Check for configured volume types: During initialization of service,
all volume types configured in the cinder store(s) will be checked if
they exist in deployment or not, the store with the wrong type will be
disabled. if cinder store is configured using traditional/old way
(i.e. using 'stores' config option) then this validation will not be performed.
3) Update legacy images: This change is partially depedent on the glance
changes[1] which trigger updating the URL for legacy images and the
cinder store checks the configured stores volume type against the existing
image-volume's type and update it respectively.

[1] https://review.opendev.org/#/c/742373/

Implements: blueprint multiple-cinder-backend-support
Change-Id: I0ba36d1095886fd1d96926af37a3a65a178c004f

Add new configuration option ``rbd_thin_provisioning`` and
``filesystem_thin_provisioning`` to rbd and filesystem
store to enable or not sparse upload.

A sparse file means that we do not actually write null byte
sequences but only the data itself at a given offset, the
"holes" which can appear will automatically be interpreted by
the storage backend as null bytes, and do not really consume
your storage.

Change-Id: I129e30f490e3920e9093c2b793f89b70ce310a50
Co-Authored-By: Grégoire Unbekandt <gregoire.unbekandt@gmail.com>
Partially Implements: blueprint handle-sparse-image

Change the RBD store to resize the image by up to 8GiB
at the time to not resize on every write.

Trim the image in Ceph after all data has been written
to the actual size in case we overshot the resize.

Partial-Bug: #1792710
Related-to: spec-lite-Ceph-Store-Optimization

Change-Id: I7f0bffda222b663d4316c5d6c03fdbd0d3337035

At the moment if you need to configure cinder store of glance in your
environment then you need to mannualy copy rootwrap related files
from glance_store/etc/glance to /etc/glance folder.

Added those rootwrap.* related files as data_files in setup.cfg
which will copies those to /etc/glance on installation.

Change-Id: I9217f4a1379687241d23fe34deecd1f482cbb49c
Closes-Bug: #1890844

This is to add missing white space between words in log message.

Change-Id: Ie166d3d29b10452238f6d3b325bb8c2f36b5fae1

As per victoria cycle testing runtime and community goal[1]
we need to migrate upstream CI/CD to Ubuntu Focal(20.04).

Set bionic nodeset for py36 job and focal nodeset for rest all.

[1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-fo$

Change-Id: Ide3cefdcf5e99f9593890a8f9bd4c8520af12d29
Story: #2007865
Task: #40185

It replaces legacy-tempest-dsvm-full-ceph-plugin-src-glance_store
which is defined inside openstack-zuul-jobs.
It is really a variant of the devstack-plugin-ceph-tempest job.

Remove .zuul.yaml from the ignored file list as in other jobs.
Change-Id: Id9bc9172560421e3ebcbb3842da367ffd9a6bfd4

Importing pkg_resources causes the app to scan the entire import path
for all distributions, not just those providing entry points. The
scanner in stevedore will have a cache of the entry point data, making
it significantly faster.

This also more accurately reflects the way oslo.config loads option
plugins.

Change-Id: Ibbac3240a99684de0dea2f690f4276a3d24e3fe1
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

This has been replaced in use by stestr.

Change-Id: If0297f1a85d9d54c126da8a8436044bf4a161ef4
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

These translation sections are not needed anymore, Babel can
generate translation files without them.

Remove babel.cfg as well, this is the default role and not needed
anymore.

also remove Babel from requirements[1]
[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014227.html

Change-Id: I106c408a394ce8018c11560a60fe1a160b898ec3

We allowed the use of the third party mock lib, even though we no longer
declare it as a test-requirement. That should have failed, but there
must still be a dependency that pulls it in for us. But unit tests will
start failing once more dependencies move away from it, so we need to
clean that up.

Change-Id: I79d647e8c8a060eacfa5cbee39a99344adc0ae94
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

With change[1], we will enabled encrypted volume support for cinder
nfs driver.
Before enabling that, we require handling in cinder consuming projects
(like glance_store) to not have unexpected behavior.
This patch blocks image creation if the destination volume (in which
the image will be written) is an encrypted nfs volume.

[1] https://review.opendev.org/#/c/597148/

Closes-Bug: #1884482

Change-Id: I3b4c6782e561f22a7118624e26bf056cd6405a30

Change-Id: I8eadf775a17d9505ed5eafc54d1c4849de6f45f3

The __future__ module [1] was used in this context to ensure compatibility
between python 2 and python 3.

We previously dropped the support of python 2.7 [2] and now we only support
python 3 so we don't need to continue to use this module and the imports
listed below.

Imports commonly used and their related PEPs:
- `division` is related to PEP 238 [3]
- `print_function` is related to PEP 3105 [4]
- `unicode_literals` is related to PEP 3112 [5]
- `with_statement` is related to PEP 343 [6]
- `absolute_import` is related to PEP 328 [7]

[1] https://docs.python.org/3/library/__future__.html
[2] https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html
[3] https://www.python.org/dev/peps/pep-0238
[4] https://www.python.org/dev/peps/pep-3105
[5] https://www.python.org/dev/peps/pep-3112
[6] https://www.python.org/dev/peps/pep-0343
[7] https://www.python.org/dev/peps/pep-0328

Change-Id: I9dcb02f5417c0f1d0ffce94267953a426252a56b

Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems

Update Sphinx version as well.

Disable openstackdocs_auto_name to use 'project' variable as name.

Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.

Remove docs requirements from lower-constraints, they are not needed
during install or test but only for docs building.

openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.

See also
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html

Change-Id: Iee357adb23ff65e453ac627eaec0b9d7ac245ba6

Previous versions of jsonschema (<3.2.0) doesn't support python 3.8 [1].
Python 3.8 is part of the victoria supported runtimes [2] so we now force
to use jsonschema version 3.2.0 to avoid issues, remove ambiguity and ensure
that everything works with python 3 in general.

[1] https://github.com/Julian/jsonschema/pull/627
[2] https://governance.openstack.org/tc/reference/runtimes/victoria.html#python-runtimes-for-victoria

Change-Id: I097b2d0349083cad1908db8dc25a33d9ad492adb

flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.

Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.

To avoid similar gate break in future, we need to bump the hacking min
version.

- http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html

Change-Id: Ia57bd9ef1bb1100c6c2a44b89718c63945e53f70

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ib629f32a1c6caad3c65d71052b104a8b3b23f250