Merge branch 'debian/stein' of ssh://salsa.debian.org/openstack-team/libs/python-hacking into debian/stein

ghanshyam authored Apr 13, 2018 and David Rabel committed Sep 03, 2018

As we have 2 new changes and request to release
the hacking, this commit adds the release notes
for next release.

Usually we do not add the release note for hacking
changes but it is good to have release notes per
release to reflect the glance of changes happening in
release.

Change-Id: I607ea48e9539e9bb2e2115dec503ed7283fb84af

Andreas Jaeger authored Feb 24, 2018 and David Rabel committed Sep 03, 2018

Add the hacking-integration-nova test as Zuul v3 native test.

Note that the legacy tests always fails due to missing
required-projects with Zuul v3.

Fix also the following problems so that the test works:
* Give proper exit code, so that tox does not always succeed
* Import nova to avoid the error:
  "ImportError nova.hacking.checks.factory"

Change-Id: Iffaae6a3acb890051fbe4768eef9f0b82428e81c

Doug Hellmann authored Apr 11, 2018 and David Rabel committed Sep 03, 2018

We will manage the eventlet version using constraints now. See the
thread starting at
http://lists.openstack.org/pipermail/openstack-dev/2018-April/129096.html


for more details.

Change-Id: I39977f2c40bbb04f8e1994fc7dbad7628fae58b0
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

OpenStack Proposal Bot authored Mar 15, 2018 and David Rabel committed Sep 03, 2018

Change-Id: Iff9775ebd70f7ed4cde47b71e8307828fe2de218

Doug Hellmann authored Mar 22, 2018 and David Rabel committed Sep 03, 2018

Create a tox environment for running the unit tests against the lower
bounds of the dependencies.

Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.

Add openstack-tox-lower-constraints job to the zuul configuration.

See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.

Change-Id: I0e081a577a9662fb8a231abf6f5b49cf239d9be8
Depends-On: https://review.openstack.org/555034


Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Eric Harney authored Aug 16, 2017 and David Rabel committed Sep 03, 2018

In python 3.6, escape sequences that are not
recognized in string literals issue DeprecationWarnings.

Convert these to raw strings.

Change-Id: I0e2bff9cb45974b159aed6a63913a63b1956aa32

OpenStack Proposal Bot authored Jan 27, 2018 and David Rabel committed Sep 03, 2018

Change-Id: Id81573cceaa628e68ecfb2275150c19c338ae030

Nguyen Van Trung authored Jan 29, 2018 and David Rabel committed Sep 03, 2018

We support py35 now.so it is no need to keep
the supoort for py34.

Change-Id: I7f1ff8a12e11441a6a64914bbbe0e5465e89c344

Paul Carver authored Feb 15, 2017 and David Rabel committed Sep 03, 2018

There is some inconsistency across existing code in whether OpenStack
projects such as oslo and neutron_lib are considered "third party" or
"project imports". This commit clarifies the guideline.

If the popular sentiment is the opposite of what I've written then
I can change the wording to say that, but either way the style guide
should state clearly whether "other" OpenStack projects are "project"
or "third party".

Change-Id: I6d89eefdef9f3b594a65aa73b7464bbc1f18306d

John L. Villalovos authored Oct 17, 2017 and David Rabel committed Sep 03, 2018

Don't cause an H210 error if the mock.patch/mock.patch.object call uses
the 'wraps' keyword. As that serves the same purpose in catching wrong
attributes.

In testing, if using 'autospec=True' with 'wraps', then the object
specified by 'wraps' does not get called.

Change-Id: I29a4df15c2511bd12655c09edcae8530cd5ce0d3

Dirk Mueller authored Oct 25, 2017 and David Rabel committed Sep 03, 2018

flake8 2.6.x performed the conversion to pycodestyle (which is
the new name of pep8). Remove the explicit dependencies of
hacking as flake8 is going to pull in mccabe, pyflakes and
pycodestyle in the versions that are needed.

Change-Id: I12b5e114c5c6783e9da5cca2818ac9266a00fc87

Andreas Jaeger authored Dec 02, 2017 and David Rabel committed Sep 03, 2018

We do not need tox_install.sh, pip can handle constraints itself
and install the project correctly. Thus update tox.ini and remove
the now obsolete tools/tox_install.sh file.

This follows https://review.openstack.org/#/c/508061 to remove
tools/tox_install.sh.

Change-Id: I4d8af466a96832000070196b81772b1325d0765c

Andreas Jaeger authored Nov 16, 2017 and David Rabel committed Sep 03, 2018

Release notes are version independent, so remove version/release
values. We've found that projects now require the service package
to be installed in order to build release notes, and this is entirely
due to the current convention of pulling in the version information.

Release notes should not need installation in order to build, so this
unnecessary version setting needs to be removed.

This is needed for new release notes publishing, see
I56909152975f731a9d2c21b2825b972195e48ee8 and the discussion starting
at
http://lists.openstack.org/pipermail/openstack-dev/2017-November/124480.html
.

Change-Id: I01315f332e339bf783d34e96a972eac121816a56

OpenStack Proposal Bot authored Sep 20, 2017 and David Rabel committed Sep 03, 2018

Change-Id: I25d3d888a41f00311b7cde97f9bad1ea91b059ff

John L. Villalovos authored Sep 05, 2017 and David Rabel committed Sep 03, 2018

The releasenotes were broken and would not generate correctly.

Change-Id: Ic9e032bc6482f8e7d819ba1f5fc04c20628b3a86

Andrea Frittoli authored Aug 31, 2017 and David Rabel committed Sep 03, 2018

There has not been a hacking release in some time. This release is
done at the very beginning of the Queens cycle to reduce disruption as
much as possible and give plenty of time to solve any issue that may
arise or enabling new rules that are disabled by default.

Change-Id: If9a54a0b2c07f91ff2f503f1159ff0d23946e2d9

John L. Villalovos authored Jul 26, 2017 and David Rabel committed Sep 03, 2018

Add two test lines to show that using '# noqa' will work to disable
the mock.patch check that requires using autospec.

Change-Id: I4c5777867265c15469e2f34e8e9dea49fa7bff98

John L. Villalovos authored Mar 18, 2017 and David Rabel committed Sep 03, 2018

Adding an off_by_default check to require one of the following keyword
arguments to be specified in mock.patch() or mock.patch.object() calls:
   * autospec
   * new (or as a parameter argument)
   * new_callable
   * spec
   * spec_set

If none of those are present in the call, then error.

Change-Id: I7ee7fbd7a66f38777f8b9216ab161acf447b5136

Akihiro Motoki authored Jul 11, 2017 and David Rabel committed Sep 03, 2018

Change-Id: I015a24d68138afb17ff3204be63603a48ff9b94f

Akihiro Motoki authored Jul 11, 2017 and David Rabel committed Sep 03, 2018

Some minor formatting issues caused by openstackdocstheme adoption
in README.rst and HACKING.rst.

Note that the install instruction is part of README, so it is not split
out into a separate rst file (as suggested in the doc-migration spec).

Change-Id: Iac58eeb15921e9225a461e3b5b2f3bd7ac99f415

Akihiro Motoki authored Jul 11, 2017 and David Rabel committed Sep 03, 2018

Change-Id: I4ab08cd976dda6b9deb5116a7ab9d3da91fe69da

Akihiro Motoki authored Jul 11, 2017 and David Rabel committed Sep 03, 2018

pbr warnerrors is no longer needed in favor of
warning-is-error from Sphinx.

Change-Id: Ia39ca8f59aa360d428817efa7d7276d65818d671