Using partition numbers is currently broken for devicemapper devices.
Fortunately, GPT has partition UUIDs, so we can just generate one and
use it for lookup.

Adapted from IPA change I41ffe4f8e4c6e43182090b5aa2a2b4b34f32efd5,
but uses a simplified version of get_partition (just findfs).

Change-Id: Id71da0fef3783619f3d07667cfab25c88638867b

Ansible playbook from bindep fails to install package
python-devel on python3 environment.
https://opendev.org/opendev/bindep/src/branch/master/playbooks/bindep/run.yaml#L31

Add platform:base-py[2|3] to python devel rpm packages.

Related: RHBZ#2054559
Change-Id: Iee5ac3a778f8106b7f2e96cd9294e2da28fe4def
(cherry picked from commit 3818348e)

The blkid version included in util-linux 2.23.2 does not allow long
options name for probe and match-tag.
Use the short single letter name to restore compatibility with Centos 7

Story: 2009328
Task: 43764

Change-Id: I10a52c16ebe4e519d0af63b36c3a89fd5d371319
(cherry picked from commit 731e2f9c)

oslo.config is relying on the list_opts entrypoint to automatically
integrate the json_rpc options.

Story: 2009126
Task: 43038

Change-Id: Id50af71faec84bd778422ed86a3b99797158afdb
(cherry picked from commit 12bca21c)

list_opts() should return a tuple otherwise
oslo-config-(genera|valida)tors are unable to parse its output.

Story: 2009126
Task: 43039

Change-Id: Ib4b9c270709f5994bc2c031c339822d7d6b9356d
(cherry picked from commit f6ddd09d)

Per blkid man page, we should rather use lsblk, which has much better
debugging output (blkid essentially only returns an exit code). Since
the partition table type is not available in lsblk, copy the procedure
using parted from ironic-python-agent.

Change-Id: I3b20754727de904dbe72f358a21f31f00a5fbb77
(cherry picked from commit b7f12117)

Add logging when a command is not found.

Also remove duplicate logging of exit code and command line:
it's already done by processutils.

Change-Id: I0349073cf0f78fb021dcd3e830fedddf2b4a0c92
(cherry picked from commit e4d7c1f4)

Under heavy load, the qemu-img convert method may attempt to create
additional malloc arenas to complete its work. By default this number
is 8 * ncpu * which at about 250 MB of memory which can be consumed
in this mannor should the.

Since this is only something which should realistically occur under
heavy cross-thread load where memory locking prevents a thread from
unlocking a range of memory, (such as what can happen with hypervisors
and VMs inside those hypervisors), then a new arena gets created, and
the memory consumption spikes.

More information is avialable at:
https://www.gnu.org/software/libc/manual/html_node/Memory-Allocation-Tunables.html

Change-Id: I8b2b490f2cc0ac5f47c3aaaaa249ce59db6602d6
Story: 2008928
Task: 42529
(cherry picked from commit 76cbb962)

The current value is insufficient for modern images. A similar change to IPA:
https://review.opendev.org/c/openstack/ironic-python-agent/+/778035

Change-Id: Ia1535b375d2cec467011c7456da84b5811ba48dd
(cherry picked from commit df9a2e85)

Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/wallaby branch, tests will
continue to use the upper-constraints list on master.

Change-Id: Id217caf5de50762e894459f06d4403331240d4e4

Change-Id: Iea117f4f1a651007fd11c44e10d0f1b6cd50c24f

They have a colon in device names, so the current logic breaks.
Also add a more useful error message when splitting.

Change-Id: I55b2cc42789218afcf4ff05cdd50a250992cb9db

The use_standard_locale and log_stdout arguments are not passed to
processutils.execute, they should be keyword arguments of the execute
function.

Change-Id: I743ce53d5e5d82401173eb7189e90531f3ee138e

The param check_exit_code from the processutils extension execute has
default already at [0]
See:
https://opendev.org/openstack/oslo.concurrency/src/branch/master/oslo_concurrency/processutils.py#L214

Change-Id: Ia0f42bf3de9c074a1212859352b5c5e1abe7eed8

To be able to use the same JSON RPC implementation for ironic-inspector,
it is now imported in ironic-lib. Some additional abstraction laters are
added to avoid hard dependency on oslo.context and oslo.messaging.

Change-Id: I0e790cebcd086d26bf27b909f73842c3f46bbd77

The get_uefi_disk_identifier function is currently unused in both
ironic and IPA. Furthermore, its name is confusing: it returns
the UEFI partition UUID, not the disk identifier, unlike the
similarly named get_disk_identifier.

This change imports get_efi_part_on_device from IPA as
find_efi_partition. The only difference is that it returns
a complete partition record rather than only the number.

Change-Id: I424d04adb6ccbb3daa99daa5c860cbb81332c02e

Change-Id: I735a6289b9b94b90f0737a4743b7281dd2bdcedf

Add a new helper get_device_information that can call blkid
with various arguments. Also add get_partition_table_type
using the PTTYPE blkid field. Switch a few calls to using
the new helper.

Change-Id: I005613d9f7de8106f31c30abd9c87e0bcd6b9272

It seems common in IPA to retry umount 3 times, so default to it.
Also permit retrying mount as well just in case.

Change-Id: I79fc069ff07af37bfc8109421f79c3175c4b2749

It's used in a few places here and in IPA, so let's add it.

Also makes list_partition return a path (can be handy in IPA).

Change-Id: I04c2593c22350fbc77921ef97533f16e1dc65a18

There was TODO in the imported code from ironic, this patch
implements it.

Change-Id: Idb4b0e12348fa1c2a079cc0c6da28c5938ecbeb5

This code is used by both ironic and ironic-inspector with barely
any difference and will be required to import the JSON RPC code.

To prevent IPA from depending on keystoneauth, the new requirement
is added as a new extra feature "keystone".

Change-Id: I8bc08ec9e081a67d1687033413fee63698e14e69

Extended boot records (EBRs) are used in the MSDOS partitioning
scheme to manage extended partitions. EBRs are small partitions
themselves and Ironic will therefore treat them like any other
partition during cleaning. Since EBRs are smaller than a GPT
(33 sectors), dd'ing 33 sectors will fail. This patch proposes
a fix to handle EBRs (and other tiny paritions) by adjusting
the number of blocks writtent to be the partition size at max.

Story: #2008539
Task: #41628
Change-Id: Ie9809b3e4fe2bea6b66ee95c442111942e85d618

Not needed now that we only support Python 3.

Change-Id: I241ae6f62e5b91c253c73964ce31e0c3fcc28de1

There is no reason to force standalone users to base64 encode
and gzip their config drives.

Change-Id: Ic221c4bbc165cd717b36fff8bdd66edebb08be9a

The base64 module can raise many exceptions, TypeError doesn't even
seem one of them. Capture all errors and provide the exact message.

Change-Id: Id3748e729f8dd31aa6d2d7084bd01088cd9a7ecd

The minimum version since when tox accepts having inline comments
in deps is 3.9.0

https://tox.readthedocs.io/en/latest/changelog.html#v3-9-0-2019-04-17

Change-Id: I1976e24792d506003962cf970cd59b8d47891f4a

This pattern is used in a few places and is very helpful for
writing custom deploy steps.

Change-Id: Ib7518075f3140a8daf06db52317ff10f8572dcc8