This is a follow-up for I143203be7827f73daba32e7c084c5807063ff91d
with minor fixes requested in the review.

Change-Id: I83a506b0a489efe56b4a11a954a76fe0783fa4ba

Ansible playbook from bindep fails to install package
python-devel on python3 environment.
https://opendev.org/opendev/bindep/src/branch/master/playbooks/bindep/run.yaml#L31

Add platform:base-py[2|3] to python devel rpm packages.

Related: RHBZ#2054559
Change-Id: Iee5ac3a778f8106b7f2e96cd9294e2da28fe4def

This change allows customizing the roles required for JSON RPC, to use
any roles different from the 'admin' role.

There is a plan, as part of SRBAC effort, to replace usage of the admin
role in each service by the new service role, which has more restricted
access, and we expect the ironic service user would require only
the service role once this work is done.

Change-Id: I143203be7827f73daba32e7c084c5807063ff91d

We have updated the yoga testing runtime to keep the
py36 testing.

- https://review.opendev.org/c/openstack/governance/+/820195

Unit tests job template is also updated to keep python
3.6 as a voting job. So with the py3.6 and py3.9 testing as voting
job template, we are keeping python 3.6, 3.7, 3.8, and 3.8 as
tested versions in the Yoga cycle.

- https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/820286

This commit re-add the python 3.6/3.7 versions in setup.cfg classifier.

Change-Id: I7129bb68320a7d6de40feea571e2ac03d4b09166

Yoga testing runtime has been updated with py38 and py39
as voting and removed the py36 testing. Unit tests update are
handled by the job template change in openstack-zuul-job and you
can see the updated jobs running in gate.

- https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/818609

this commit updates the tested py versions in setup.cfg classifier.

[1] https://governance.openstack.org/tc/reference/runtimes/yoga.html

Change-Id: I7cfd594a76c30bb4b603b212aa9e4aca82f4336f

The blkid version included in util-linux 2.23.2 does not allow long
options name for probe and match-tag.
Use the short single letter name to restore compatibility with Centos 7

Story: 2009328
Task: 43764

Change-Id: I10a52c16ebe4e519d0af63b36c3a89fd5d371319

Allow the sparse_size for qemu-img to be specified in order
instruct it to write out all zeros(when set to 0). Doing this
will cause it not to zero out the entire block device
which can be very costly on a slow HDD.

Story: 2009227
Task: 43315
Change-Id: I480352be378020a6063fe247238b18713031f6b0

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for yoga.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I294706753dc791f70833759b6c7cdcd2eb7caa2e

Per blkid man page, we should rather use lsblk, which has much better
debugging output (blkid essentially only returns an exit code). Since
the partition table type is not available in lsblk, copy the procedure
using parted from ironic-python-agent.

Change-Id: I3b20754727de904dbe72f358a21f31f00a5fbb77

This library is designed for leaf applications (services, CLI). For
libraries it's enough to use the generic logging.

Unit tests needed adjustment since LOG.exception is implemented via
LOG.error internally.

Change-Id: I943e1f07a23e76354966acae5e4594e41dd4822b

oslo.config is relying on the list_opts entrypoint to automatically
integrate the json_rpc options.

Story: 2009126
Task: 43038

Change-Id: Id50af71faec84bd778422ed86a3b99797158afdb

list_opts() should return a tuple otherwise
oslo-config-(genera|valida)tors are unable to parse its output.

Story: 2009126
Task: 43039

Change-Id: Ib4b9c270709f5994bc2c031c339822d7d6b9356d

The lower-constraints test was removed because of an issue where pip
could not correctly determine the required packages versions to install,
ending in an almost infinite loop that would end up in timeout, failure,
and general mayhem.
Recently the issue has been fixed and, if properly configured, the
lower-constraints test can provide good indication of which minimum
versions are required to support the current code.
This patch adds the test back to the current development branch, and it
runs only on master.
The lower-constraints file will stay in the future stable branches.

Fix olso.utils min requirement and remove doc8 from test-requirements
as it's already included in tox.ini config.

Change-Id: Ic0174f59b95a878539ab17f659f1663548e94ed7

Change-Id: Ib4340aacba21cadef655998b1729dc6b18e173a8

Support for the human format by oslo_utils.imageutils.QemuImgInfo was
deprecated since oslo.utils 4.9.1 [1]. This change replaces the human
format with the json format which will be used by default.

[1] 73eb0673f627aad382e08a816191b637af436465

Change-Id: I4c9bdbccb9345e2259ddb0737f37c09d99dd1c4f

The min version of tox is updated to 3.18.0 to replace whitelist_externals
with allowist_externals option [1]

[1] https://github.com/tox-dev/tox/blob/master/docs/changelog.rst#v3180-2020-07-23

Change-Id: I655917f1c44b68118ce22fcf479f3f317636ac98

Add logging when a command is not found.

Also remove duplicate logging of exit code and command line:
it's already done by processutils.

Change-Id: I0349073cf0f78fb021dcd3e830fedddf2b4a0c92

Under heavy load, the qemu-img convert method may attempt to create
additional malloc arenas to complete its work. By default this number
is 8 * ncpu * which at about 250 MB of memory which can be consumed
in this mannor should the.

Since this is only something which should realistically occur under
heavy cross-thread load where memory locking prevents a thread from
unlocking a range of memory, (such as what can happen with hypervisors
and VMs inside those hypervisors), then a new arena gets created, and
the memory consumption spikes.

More information is avialable at:
https://www.gnu.org/software/libc/manual/html_node/Memory-Allocation-Tunables.html

Change-Id: I8b2b490f2cc0ac5f47c3aaaaa249ce59db6602d6
Story: 2008928
Task: 42529

To write whole disk images using convert_image we need to support
cache flags and out-of-order.

Change-Id: I60df5a747a51109965b432653184b1ee3c98e2a5

The current value is insufficient for modern images. A similar change to IPA:
https://review.opendev.org/c/openstack/ironic-python-agent/+/778035

Change-Id: Ia1535b375d2cec467011c7456da84b5811ba48dd

Setuptools v54.1.0 introduces a warning that the use of dash-separated
options in 'setup.cfg' will not be supported in a future version [1].
Get ahead of the issue by replacing the dashes with underscores. Without
this, we see 'UserWarning' messages like the following on new enough
versions of setuptools:

  UserWarning: Usage of dash-separated 'description-file' will not be
  supported in future versions. Please use the underscore name
  'description_file' instead

[1] https://github.com/pypa/setuptools/commit/a2e9ae4cb

Change-Id: I0f8a792afc5a346d273b92e3aa77d59781b04a37

This code used to be shared between the iSCSI and the direct deploy
interfaces. Now that iSCSI is gone, this code has been moved to IPA:
https://opendev.org/openstack/ironic-python-agent/commit/24951b1029170840484a50fdd38d2a57858a578c

Change-Id: Ia879595d00501f3f06ae5dc2a9dca9c5ea234501

Change-Id: I3eb14c2a5c489fff684f60a710b17b1c0b48a016

Pbr is a very heavy package to depend on. It requires git-core, which is
16 MiB on my Fedora. We only use it to detect the version, which can be
done without pbr by any consumer (e.g. with importlib_metadata).

This is technically a breaking change, although since ironic-lib is an
internal library it should not be an issue.

Change-Id: I6f5ee64226ffc6a30804c09bb28b3d6680b095d1

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for xena.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I83237b5ca29ce1bec73e659381b134cc5c9844e0

They have a colon in device names, so the current logic breaks.
Also add a more useful error message when splitting.

Change-Id: I55b2cc42789218afcf4ff05cdd50a250992cb9db

The use_standard_locale and log_stdout arguments are not passed to
processutils.execute, they should be keyword arguments of the execute
function.

Change-Id: I743ce53d5e5d82401173eb7189e90531f3ee138e

The param check_exit_code from the processutils extension execute has
default already at [0]
See:
https://opendev.org/openstack/oslo.concurrency/src/branch/master/oslo_concurrency/processutils.py#L214

Change-Id: Ia0f42bf3de9c074a1212859352b5c5e1abe7eed8

To be able to use the same JSON RPC implementation for ironic-inspector,
it is now imported in ironic-lib. Some additional abstraction laters are
added to avoid hard dependency on oslo.context and oslo.messaging.

Change-Id: I0e790cebcd086d26bf27b909f73842c3f46bbd77