The assertItemsEqual method has been removed in Python 3.3 [1] but
it was kept alive by unittest2, imported by testtools. For better
compatibility, change to assertCountEqual.

[1] https://bugs.python.org/issue17866

Change-Id: I240355d5a0ebf8ece14bb2b4faf764c23477e322

The patch bumps min version of tox to 3.18.0 in order to
replace tox's whitelist_externals by allowlist_externals option:
https://github.com/tox-dev/tox/blob/master/docs/changelog.rst#v3180-2020-07-23

Change-Id: I2e2574ab495a4e8dd10f81315996844f93645895

After transition to the new enginefacade db calls should be done inside
the context of the READER or WRITER transaction. In bgpvpn_db module
some methods where decorated to be run inside such transaction but also
"with" statement was used inside. This patch gets rid of such
redundant calls.

Change-Id: I5f4b6d319316eb1082ebc1d3121dba5d19de58b7

Change-Id: Iaaa3f5b582c603c50f406d7edace88ed15701e0b

This patch switches the code over to the payload style of callbacks [1]
for PORT events for those that are not using them yet.

This patch is necessary since [2].

[1]https://docs.openstack.org/neutron-lib/latest/contributor/callbacks.html
[2]https://review.opendev.org/c/openstack/neutron/+/800604

Closes-Bug: #1938461
Change-Id: If55f0eb08c34e95ba5bc1865f7b6c107a86cd5af

This patch switches the code over to the payload style of callbacks [1]
for ROUTER_INTERFACE events for those that are not using them yet.

Depends-On: https://review.opendev.org/#/c/639814/

[1] https://docs.openstack.org/neutron-lib/latest/contributor/callbacks.html

Change-Id: I5e5fb7f73ff4b9812a468d8aa528addd3247f45c

Devstack is changing the Neutron default to OVN backend.
This patch makes sure that networking-bgpvpn-install job use OVS
backend.

Change-Id: I976f91478b15bca2c2d6b5cb5d074ec5475d7ede

``ConfDriver`` quota driver was deprecated in Liberty release.

Change-Id: I00354b3d6509c0cb20f6d93c7971dccbf775e5ea
Related-Bug: #1928211

Setuptools v54.1.0 introduces a warning that the use of dash-separated
options in 'setup.cfg' will not be supported in a future version [1].
Get ahead of the issue by replacing the dashes with underscores. Without
this, we see 'UserWarning' messages like the following on new enough
versions of setuptools:

  UserWarning: Usage of dash-separated 'description-file' will not be
  supported in future versions. Please use the underscore name
  'description_file' instead

[1] https://github.com/pypa/setuptools/commit/a2e9ae4cb

Change-Id: I7727b19a1804188ce3e6957c2402a3009cd5eedc

Change-Id: I8b544391ddb5c48ee2dbec2715a3f71f7041db1c

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for xena.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I3a2e3e08fcb8d6606f96bfabd0638a54cbfa7dc2

Add file to the reno documentation build to show release notes for
stable/wallaby.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/wallaby.

Sem-Ver: feature
Change-Id: I8768634717b3b8e4a9ed5af1b684986b0e04fed0

UPPER_CONSTRAINTS_FILE is old name and deprecated
This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.

Change-Id: I0c8c2c4a783c4f0ac9f7530d4d18937ce5b17c61

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I4d015cfe8b97e0fc1259d47c89f4b0704accb61c

l-c job recently failed too much, and maintaining it is huge job.
As on stable branches we decided (see [1]) to drop l-c testing, meke
non-voting it for networking-bgpvpn in check queue, and remove from
gate queue.

[1]http://eavesdrop.openstack.org/meetings/networking/2021/networking.2021-01-12-14.00.log.html

Change-Id: Ib5628cf79ab8bc099fb5f8b00f5302a34fa26655

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I4045c12d022b06a26f7e5e1765b3fb9834c1058b

Jobs "networking-bgpvpn-bagpipe-dsvm-install" and
"networking-bgpvpn-dsvm-install" was renamed recently as part of zuulv3
migration to networking-bgpvpn-bagpipe-install and to
networking-bgpvpn-install

Change-Id: If9b5ce8522acf298c037b14fa11dc5b97f8c8bef

in 'victoria' cycle, we should test py38 by default.

[1] https://governance.openstack.org/tc/reference/runtimes/victoria.html

Change-Id: I023720594810d346649fcda24ce011ce15955fc6

hacking 3.0.1 fix the pinning of flake8 to avoid bringing in a new
version with new checks.

bumping the min version for hacking so that any older hacking versions
which auto adopt the new checks are not used.

Change-Id: I4aca49327fb8fb0f03b7c262f8247186245cbc19

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for wallaby.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: Iff34c4159a831f3ccbb459fb4dd4767c3b0c1e1a

Add file to the reno documentation build to show release notes for
stable/victoria.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.

Change-Id: I0761cdf1501b9bb19fb81e50d0080b70495a6b67
Sem-Ver: feature

This patch is a clean-up patch for refactor-error-messages bp
which remove the exception message from base message otherwise
the same exception message display twice like
this https://ibb.co/XyFWMdz .

Depends-On: https://review.opendev.org/#/c/708069/
Change-Id: Ic7061cd293b238c497f0f4343aa3cc0e7996d5a0

As the 'all-plugin' tox env is deprecated it is recommended to use
'all' tox env instead.

[1] https://review.opendev.org/#/c/543974/

Change-Id: I827fa6d9a077efd0d3b5792fee6145dc604d371a
Related-Bug: 1862240

As per victoria cycle testing runtime and community goal[1]
we need to migrate upstream CI/CD to Ubuntu Focal(20.04).

Bump the lower constraints for required deps which added
python3.8 support in their later version.

Story: #2007865
Task: #40199

[1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal

Change-Id: Ie96f1049ea053200f3087eee81351848318727b2

networking-bgpvpn-bagpipe-dsvm-install and
networking-bgpvpn-dsvm-install jobs are still legacy jobs, this patch
aims to move them to zuulv3 syntax. The new job names are:
networking-bgpvpn-bagpipe-install and networking-bgpvpn-install

Change-Id: I75e66d864f175fef19b0f20155dec60725496034

Make the code compatible with hacking rules:
* import order problems
* line break before/after binary operator (for this added ignore for
W504, line break after binary operator
* indentation problems

I removed the rule N530 (Direct neutron imports not allowed), as that is
a longer story.
As a side-effect use newer pylint version, and fix the problems reported

Change-Id: I701c89ecc890a1d866815b5401cd4c022c51c9c4
Depends-On: https://review.opendev.org/#/c/708965/

New versions of isort broke pylint. This patch fixes it at 4.3.21.
Make sure that siblings are installed for functional tests.

Change-Id: Id04da60731543d970de6a1a88da5a32435be1aae

The __future__ module [1] was used in this context to ensure compatibility
between python 2 and python 3.

We previously dropped the support of python 2.7 [2] and now we only support
python 3 so we don't need to continue to use this module and the imports
listed below.

Imports commonly used and their related PEPs:
- `division` is related to PEP 238 [3]
- `print_function` is related to PEP 3105 [4]
- `unicode_literals` is related to PEP 3112 [5]
- `with_statement` is related to PEP 343 [6]
- `absolute_import` is related to PEP 328 [7]

[1] https://docs.python.org/3/library/__future__.html
[2] https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html
[3] https://www.python.org/dev/peps/pep-0238
[4] https://www.python.org/dev/peps/pep-3105
[5] https://www.python.org/dev/peps/pep-3112
[6] https://www.python.org/dev/peps/pep-0343
[7] https://www.python.org/dev/peps/pep-0328

Change-Id: Ic7fd095674f1e2717d686c1e4a69bad60146c9f3

_MovedItems is defined in six, six has been removed,
so it can also be removed.

Change-Id: I837db304696c1eb9d3580a64290e6148247aa0bd

With python3.x, classes can use 'metaclass=' instead of
'six.add_metaclass'.

Change-Id: I69814806752e7dab67f643c424e75462fbc6a033