As it was announced [1] global bindep-fallback.txt was removed and now
projects need to have a local bindep.txt to be able to install binary
dependencies for testing.

In test jobs the script tools/test-setup.sh is called which requires
mysql and postgres servers and clients to be installed.

[1] http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007272.html

Change-Id: I6b7afd3f6d0b45337f87e13352ab1095d51a23a3
(cherry picked from commit 4655630a)
(cherry picked from commit 29a07f76)
(cherry picked from commit 26f5183f2533ef871ef19631b4a3e2b479ddab7d)
(cherry picked from commit 987d2fb6)
(cherry picked from commit 1f44b237)

This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.

This is a mechanically generated change to replace openstack.org
git:// URLs with https:// equivalents.

This is in aid of a planned future move of the git hosting
infrastructure to a self-hosted instance of gitea (https://gitea.io),
which does not support the git wire protocol at this stage.

This update should result in no functional change.

For more information see the thread at

 http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html

Change-Id: I277954698eeb1911c391fac300cd9cff891f0449

Import legacy jobs from openstack-zuul-jobs and rename them
according to Zuul v3 naming conventions.

Change-Id: I56e23dd4352ee34ed2a129cc853cc33616559dca

This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.

Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.

Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: I20f667741b01ecc9be0dc3d06386ef1d902ce14d
Story: #2002586
Task: #24314

This is a combination of 10 commits that are needed to have successful
check, gate and periodic stable job runs.

Note: All the tempest related fixes are due to the fact that we can't
pin the version of tempest that we are using, and hence need to adjust
things when tempest evolves.

1. Fix sphinx-docs job for stable branch

build-openstack-sphinx-docs jobs fail on stable branches due to the new
pip version 10 introduces some previously Warning as Error: in case of
calling "pip install" without any package name, the command fails.
tox_install.sh is called during docs job without any package passed to
pip.

Also some tests still needs networking-odl package to be installed, however
it is removed from the required-projects of networking-bgpvpn, so they
fails now. To fix this, the easiest solution is to add networking-odl
to .zuul.yaml on stable/* branch as required project.

2. Add networking-odl for periodic-stable jobs

periodic-stable jobs fail: networking-odl is required for jobs on queens
and older stable branches. From rocky, there is no tox_install.sh any
more, so this is not needed there.

3. (stestr change removed)

4. use networking-odl from pypi instead of git master

Two reasons:
- no point in tracking master, now that development is done
  on odl bgpvpn v2 driver, which does not sit in n8g-bgpvpn tree
- odl master is sometimes broken [1], which impacts our CI

[1] http://logs.openstack.org/70/470470/2/check/gate-networking-bgpvpn-dsvm-functional-ubuntu-xenial/febf152/console.html#_2017-06-05_12_56_21_302481

5. Speed up tox_install.sh

* When installing git repos into tox venv, there is no need to
  use full clone. Shallow clone like --depth 1 is sufficient.
  It speeds up tox venv creation.
* Fix import check for networking-bagpipe and networking-odl.
  Python module names use underscores instead of hyphens,
  so the current iport check always returns false.
  As a result, installation of these projects are run multiple times.
* Allow to specify GIT_BASE for local testing.
  Previously PIP_LOCATION exists, but the tox_install.sh installs
  four repositories so PIP_LOCATION actually cannot be used.

In my local env, the time to prepare tox env was reduced from 4m52s
to 2m39s for the first run and from 42s to 19s for the second run
or later (after applying the first two points above).

Note(elod.illes): some changes of tox_install.sh didn't seem trivial to
git so it needed some manual intervention...

Closes-Bug: 1716746

6. Change sourcing neutron l2 agent script for devstack

Source the l2 agent script only in case and in place where functions
from this are going to be used.

7. unbreak tempest tests

The initialization of the self.networks variable was missing.

I don't know yet why this wasn't showing up before, possibly
because the tempest test suite was not in CI before (?).

8. tempest: unbreak scenario test

The initialization of the self.subnets variable was missing.

I don't know yet why this wasn't showing up before, possibly
because the tempest test suite was not in CI before (?).

9. tempest: Switch to local copy of tempset/scenario/manager.py

The manager.py file was literally copied from
tempest as of today. [1]

tempest/scenario/manager.py is not a part of tempest stable
interface for plugins. [2]

This was suggested on openstack-dev as a preparation for
the coming refactoring in tempest. [3]

As tempest is branchless, this change needs to be backported
to all relevant stable branches.

[1] d184d619d7adc6ab60055884515055a7f3cf7770
[2] https://docs.openstack.org/developer/tempest/plugin.html#stable-tempest-apis-plugins-may-use
[3] http://lists.openstack.org/pipermail/openstack-dev/2017-February/112938.html

10. Register query hooks at BGPVPNPluginDb object creation

This change also modifies the expected exception raised in tempest
while testing a delete of a bgpvpn by a regular tenant :
the Forbidden exception is now raised instead of the NotFound one.

Note(elod.illes): only the exception change is cherry-picked from
this commit, the networking_bgpvpn/neutron/db/bgpvpn_db.py change
is skipped.

Closes-bug: 1685930

(cherry picked from commit ff84e5a1)
(cherry picked from commit d0c1a6b5)
(cherry picked from commit 8f576a2c)
(cherry picked from commit 9c349433)
(cherry picked from commit 650c37b1)
(cherry picked from commit f24f9ce3)
(cherry picked from commit d6baa9cdde0548072b06a7d5147d1e53515cf628)
(cherry picked from commit fe90ea22)
(cherry picked from commit a62d8c64)
(cherry picked from commit 0bb5a67d)
(cherry picked from commit c7211ed7)

Change-Id: I93aea1800b6403482a7e15116610efeed02c28a1

Tempest provides stable library interfaces under tempest.lib.
This patch switches to use it for data_utils.

Change-Id: Idc81a961b6273bdb1a09a6804ce2c845224d5677
(cherry picked from commit 9478798a)

Change-Id: I12fd531612137247b0c1384087986324dfb13df0

Introduce precommit hooks for all delete_bgpvpn_xxx
methods in the bgpvpn plugin.

The precommit hooks introduced here will be used by
ODL BGPVPN Version 2 driver to write to journal
on precommits.

Also subtransactions=True were missing for net_assoc and
router_assoc methods inside bgpvpn_db and has been added
as part of this fix.

Change-Id: I422cfb5ff5c2a15c4a80430ba99e19b9ae768b06
Closes-Bug: #1664637
(cherry picked from commit 6ee70a5f)

Change-Id: I5e9e20d13b10d84e13a0bb11525cc281b246c741

Change-Id: Ic783753747f521010171a9e3876df44d3d14e9a5

Change-Id: I7063b5cc1dde70c89eb41104078bcaa547887b1b

Change-Id: I72422f63c5c724fdc9397d63c289a42b1a910c9a

From Ocata release the new ODL BGPVPN Driver v2 is available and v1 diver
is being deprecated. Add a warning log message to inform users of v1
driver so they can switch to the new v2 driver.

Change-Id: Id58f0df0b0825ad78dff586a1bea07a78a19ec05
Partial-Bug: #1632117
Depends-On: I08485db8f10f15591d70474a4b8546990d4de166

This reverts commit 205452bf.

As explain in that last version of the neutron client documentation [1]
(from review [2]) and to follow the OpenStack Client (OSC) and the
OpenStack Python SDK migration, Neutron stadium projects CLI extensions
should reside in the python-neutronclient project under the repository
'neutronclient/osc/v2/<extension>'

[1] http://docs-draft.openstack.org/71/407271/2/check/gate-python-neutronclient-docs-ubuntu-xenial/d30c3c8//doc/build/html/devref/transition_to_osc.html#developer-guide
[2] https://review.openstack.org/#/c/407271/

Change-Id: I099faee06bc3d4d634a96f45560a070f2a23bb56
Depends-On: Ib1ba356e994a98712e00a11ff045df67fbe4c7ea
Partial-Bug: #1650204

Earlier, only one RD from the list of RDs for a BGPVPN was
passed to OpenDaylight since OpenDaylight Controller had
a limitation that it can process BGPVPNs with only a single RD.
From Carbon release cycle, OpenDaylight is being enhanced to
support BGPVPNs that host multiple RDs.

Change-Id: If9fbf447e1048d52ca749ca6757b45b729223e76
Closes-Bug: #1662930

A motivation is that neutron does not complain
with a clear error message when networking_bgpvpn.conf
is not found.

Change-Id: I2688c6303fbcacb5a0e633cb309f2b5ae51ea1a6

The gating on python 3.4 is restricted to <= Mitaka. This is due to
the change from Ubuntu Trusty to Xenial, where only python3.5 is
available. There is no need to continue to keep these settings.

This patch add support python 3 to classifier and drop py34 environment
from tox

Change-Id: I69c1c724990aadb7aecabd264382ffd661eb632a

Change-Id: I0402af08e3d1284d1bb00d66fdd8083548c242f2

Add simple script to setup mysql and postgresql databases, this script
can be run by users during testing and will be run by CI systems for
specific setup before running unit tests. This is exactly what is
currently done by OpenStack CI in project-config.

This allows to change in project-config the python-db jobs to
python-jobs since python-jobs will call this script initially.

See also
http://lists.openstack.org/pipermail/openstack-dev/2016-November/107784.html

Needed-By: I0a87f7db0d1d78e7419a8706683aaa540c3dc399
Change-Id: I557202e2be6df2c1cb8efc0f42ac74cd0c458559

For db based drivers, use the Neutron db query hooks mechanism to apply
resource association filters on query results. That improvement permits to
remove two mandatory methods of the driver interface
'find_bgpvpns_for_network' and 'find_bgpvpns_for_router' which can be
replaced by the 'get_bgpvpns' method with appropriated filters.

For non db based drivers, improves utils method to filter resources with
a list of values instead of one value only. In that case, the resource
attribute value must contains filtered values at least (like it's done
for db based drivers).

Change-Id: Icbbb7ba704fbb3c025aabbddbb5121a2ecd852cc
Closes-Bug: #1659895
Implements blueprint api-find-bgpvpn-for-net

See http://lists.openstack.org/pipermail/openstack-dev/2017-January/111295.html

Change-Id: Iede105d4c3d225eca2625afaa98ae007992abf53
Closes-Bug: 1660973

Change-Id: I663c3d91e936f332a3b8a014970ef51e2496b690
Closes-Bug: 1659968

Sphinx module index docs won't be generated unless a
module level docstring is included (ex [1]) with class refs.
As we don't include such module level refs in this project,
nothing is generated and thus no py-modindex.html
is created. This results in a dead link in our devref (see
bug report).

This change removes the modindex ref from our devref's
index to account for this fact. In the future if we wish to
add module documentation to support generation of
modindex we can add the ref back into our index.

[1] https://github.com/openstack/neutron/blob/
master/neutron/neutron_plugin_base_v2.py#L19

Change-Id: I2c7f9a58d398033cf4a8029d16b430fe34fcc56e
Closes-Bug: #1656355

This patch refactors networking-bgpvpn to use portbindings
from neutron-lib. For more details see [1].

NeutronLibImpact

[1] https://review.openstack.org/422210/

Change-Id: I474141dd063181063715603ec5dd9e07af503288

Change-Id: I67cb55492ec8d1213f84ec32b69df1f15245219b

Change-Id: I329ffa4c6ed7f0fd54a071981ffffb2fe51a05c0

Change-Id: I24692675c8c9e3b8091b975fbab7c553ad3e69ad
Closes-Bug: #1655654