During recent days we many observed failures of
neutron_tempest_plugin.scenario.test_trunk.TrunkTest.test_trunk_subport_lifecycle test.
It started to fail on a different asserts.
Lets revert this patch, as it is a regression, and work further on this issue.

This reverts commit 41f6d622.

Related-Bug: #1834637
Related-Bug: #1845479

Change-Id: I244b937e916474703abf0a0c802e13bcd5a54918

Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/train branch, tests will
continue to use the upper-constraints list on master.

Change-Id: Ie3dc99749ff96550a96c4110f6d28f20a0f753f0

Change-Id: Ic9cd832e05748963b4a05ec39a43589f0a4276ca

networking-ovn-tripleo-ci-centos-7-containers-multinode	does not pass
currently in newly created branch, and tripleo-ci potential fix has an
issue with rocky gates

Temporarily mark the job non-voting (and remove from gate) for
stable/train branch creation, this should be reverted as soon as job is
passing again, probably with https://review.opendev.org/#/c/684260/

Change-Id: I7941f46c9adc7320015bed1e16ab6673137d6ce2

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I64873b9ff2479b2f2e3a13159834eeb99700e24e

The correct path should be hashed-container-startup-config-step_4.json
instead of hashed-docker-container-startup-config-step_4.json in
cleanup-dataplane.yml.

When this file was originally commited the path was
hashed-docker-container-startup-config-step_4.json but we have changed
it a few releases ago.

Change-Id: I901eedf64f7bd4281f94c156c33489355ff97aee

While other tests cover what happens when a Port_Binding is updated
when this event doesn't match, there was no test that covered the
case when it does. This test does test primarily implementation
details, but will have to do until we can test the actual use case
which involves uncleanly killing a compute server and doing a
'host evacuate' from it.

Change-Id: If9fc4209c5c54149a39ee3ddc743f3c11c51ceec

This lets us compare things to core Neutron performance.

Depends-On: https://review.opendev.org/681167/
Change-Id: I2c1acf71e5dbf51b550fce85c94041bc57a8a7a4

The patch https://review.opendev.org/#/c/681001/

 is now merged.

Change-Id: I9d78e521c3e0221231ec6442e85d3cc66bafe366
Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>

Fix string to byte convertion issues that were causing failure on the following tests:

TestMetadataAgent.test_agent_resync_on_non_existing_bridge
TestMetadataAgent.test_metadata_agent_healthcheck
TestMetadataAgent.test_agent_registration_at_chassis_create_event
TestMetadataAgent.test_updating_metadata_doesnt_update_controller_stats

networking_ovn.tests.functional.test_metadata_agent.TestMetadataAgent.test_agent_registration_at_chassis_create_event
---------------------------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b'  File "/opt/stack/networking-ovn/networking_ovn/tests/functional/test_metadata_agent.py", line 75, in setUp'
    b'    self.agent = self._start_metadata_agent()'
    b'  File "/opt/stack/networking-ovn/networking_ovn/tests/functional/test_metadata_agent.py", line 98, in _start_metadata_agent'
    b'    agt.start()'
    b'  File "/opt/stack/networking-ovn/networking_ovn/agent/metadata/agent.py", line 190, in start'
    b'    self.sync()'
    b'  File "/opt/stack/networking-ovn/networking_ovn/agent/metadata/agent.py", line 58, in wrapped'
    b'    return f(*args, **kwargs)'
    b'  File "/opt/stack/networking-ovn/networking_ovn/agent/metadata/agent.py", line 241, in sync'
    b'    unused_namespaces = [ns for ns in system_namespaces if'
    b'  File "/opt/stack/networking-ovn/networking_ovn/agent/metadata/agent.py", line 242, in <listcomp>'
    b'    ns.startswith(NS_PREFIX) and'
    b'TypeError: startswith first arg must be bytes or a tuple of bytes, not str'
    b''

Change-Id: Iaf807ab4bdbb41dc80702283d9689ccdd499fa31
Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
Co-Authored-By: Terry Wilson <twilson@redhat.com>
Closes-Bug: #1843944

In functional test
"test_updating_metadata_doesnt_update_controller_stats", do an active
wait to retrieve the Agent stats until "ChassisMetadataAgentEvent" is
generated and a new stat is added to the global instance "AgentStats".

Change-Id: I6ed2573b71dc91a60d860537512bfcef7a212e17
Closes-Bug: #1841913

We have irregular-files already, enhance them so that some jobs do not
run if we import locale files since those are unused in the test runs.

Change-Id: Iae5b4b402434f3c500f1f757c68fc3ddb4e2d29d

Although notify_nova_on_port_status_changes defaults to true, it
could be set to false, making the nova_notifier attribute unsafe to
use without checking. In fact, networking-ovn functional tests
inherit from the neutron base *unit* test which disables this
option.

This patch checks both the config option and that the attribute
exists, since the config could be changed after the plugin is
already initialized without the nova_notifier attribute being set.

Partial-Bug: 1843269
Change-Id: Ia89283c1f6569340a891b40c92405941cbda5800

This patch is modifying the DevStack scripts to use the new OVN
repository for our jobs targeting the master branch (or >= 2.12, when
it's released).

If the OVN_BRANCH is set to stable branches the code will fallback to
using the "compile_ovs" function like before (since those branches does
not exist in the new OVN repository, only master and >= 2.12 when
released).

Change-Id: I8b99a3481b4460ae32f2258dcf4190db9a8fed89
Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>

Setting binding profile for Trunk subports takes
time - for 125 subports rally CreateAndListTrunks
scenario [0] takes about 150 seconds. We need to
bump up the perfomance because large number of
subports is widly used in Kuryr deployments.

To achieve that I changed setting the binding
profile to be saved directly to the neutron DB.
Instead calling port_update I update only related
fields in OVN NorthBound DB rows. That gave performance
improvement in trunk port creation:

from 101 sec to 19.7 for 95%ile
from 99 sec to 14.9 for 50%ile

The same thing has been done for Trunk deletion.

[0] https://github.com/openstack/rally-openstack/blob/master/rally_openstack/scenarios/neutron/trunk.py#L37

Closes-Bug: #1834637

Change-Id: I020ba64618b2eb76c627632b0575896e88d1fcf8

Just like jobs that use networking-ovn-base as a parent,
networking-ovn-rally-task artifacts should contain the
databases created by OVN and OVS.

Change-Id: I96fb39e6fd7c885598527e57a3fb299e61367bf6
Co-Authored-By: Daniel Alvarez Sanchez <dalvarez@redhat.com>
Signed-off-by: Flavio Fernandes <flaviof@redhat.com>

Bump ovsdbapp to 0.17.0 in requirements and lower-constraints,
needed for external ports.

Change-Id: I8ca47a96866f581c72115aed828f5cc2fdd1331f

There were four code paths doing the same thing, created
a helper to lookup a loadbalancer given a pool id.

Change-Id: I6d4a4b396eaa0d4be2a2c7afeccdb336020a40b3

We have implicit branch matchers, so there's no need to add a check
for not-ocata etc, a job is only run for the branch it's on - like
master now.

Remove it to not confuse Zuul when multiple branches matches and the job
definition is different.

Remove jobs networking-ovn-tripleo-c7-s007-oooq-containers and
tripleo-ci-centos-7-scenario007-multinode-oooq-container, they are not run
on master at all, the jobs are on the branches and defined there.

Change-Id: If6e0b79ee4631ffa3295280c5ad04ad8a4399469

OVN doesn't support members with different IP version
that loadalancer VIP. We should block such operations.

Change-Id: Id193385866cfb5f2490e3e322fc79a1fae81fd72
Closes-Bug: #1843553

While setting the event handler lock in OvnNbIdlForLb
we found that on each Octavia API call exception
was raised that the IDL has not aquired OVNDB lock [0].

It is because when we set the event lock name it is
required to be acquired on each transaction, even on
the one passed by Octavia API, which shouldn't be
blocking one [1].

The second issue was cached NB DB connection within the same
process [2]. We overcome this by using other idl
implementation that utilize modified
networking_ovn.ovsdb.impl_idl_ovn.Backend.

So to address this issue I initialize second IDL that
watches only for events and has the lock name set. First
instance of OvnNbIdlForLb is used only for handling
Octavia API requests. Second has the lock name set and
is cached by OvnProviderHelper class attribute, that makes
the event mechanism work.

While long-living agent driver would be released
the second OvnNbIdlForLb object could be used in OVN agent
driver process in order to handle events there and then
we could stop using second IDL in the OvnProviderHelper.

[0] https://github.com/openstack/ovsdbapp/blob/master/ovsdbapp/backend/ovs_idl/transaction.py#L102
[1] https://github.com/openvswitch/ovs/blob/master/python/ovs/db/idl.py#L445
[2] https://github.com/openstack/ovsdbapp/blob/68d462d355a9c9f7e6b12f08f4dfb0b0b3d443b2/ovsdbapp/backend/ovs_idl/__init__.py#L51

Change-Id: I6534ac7777cf2a1216c65110704c675d5160b051
Story: 2006196