This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.

This is a mechanically generated change to replace openstack.org
git:// URLs with https:// equivalents.

This is in aid of a planned future move of the git hosting
infrastructure to a self-hosted instance of gitea (https://gitea.io),
which does not support the git wire protocol at this stage.

This update should result in no functional change.

For more information see the thread at

 http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html

Change-Id: Ie8f408aacba19447add384547c2ea0e2d611a50f

This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.

Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.

Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Update tools/tox_install.sh to fix docs job.

Change-Id: Ib80187a8ad568c563be04d2722d7120e82cc8240
Story: #2002586
Task: #24314

This moves current legacy jobs in our repository, renaming them as
recommended by:
https://docs.openstack.org/infra/manual/zuulv3.html#howto-update-legacy-jobs

Change-Id: Iaf6f8cc1eba9a75adbc824ec80d14519b4665642

Aliases are deprecated for cred manager [1], update existing occurences
in tempest plugin (including currently commented code for multinode
tests)

[1] I5f7164f7a7ec5d4380ca22885000caa0183a0bf7

Conflicts:
	networking_sfc/tests/tempest_plugin/tests/scenario/test_sfc_multinode.py

Change-Id: I2d204cca39a5fd445fc9a3c66913396b38e51fad
Closes-Bug: #1697588
(cherry picked from commit b2d3bc96)

Change-Id: Iec40ea7cffc6686f763691b388f482d62a89d920

Only observed on CentOS, but could happen on other systems:
 AssertionError: Mismatched values: 'source_ip_prefix',
 expected: u'10.0.0.9', actual: u'10.0.0.10

The list of flow classifiers can be in a different order than the
creation one, which causes the mismatch.

These tests now sort (on a relevant key) flow classifiers and expected
values lists. The assert check was also rewritten from the deprecated
assertDictContainsSubset method, and works fine on python 2 and 3

Change-Id: I5d7a6b4902522926ec07d06c8a291c5f41adc5bf
Closes-Bug: #1666568
(cherry picked from commit c28f7a38)

The manager.py file was mostly literally copied from
tempest as of today. [1]  It's slightly modified to
appease N521 hacking check.

tempest/scenario/manager.py is not a part of tempest stable
interface for plugins. [2]

This was suggested on openstack-dev as a preparation for
the coming refactoring in tempest. [3]

As tempest is branchless, this change needs to be backported
to all relevant stable branches.

[1] d184d619d7adc6ab60055884515055a7f3cf7770
[2] https://docs.openstack.org/developer/tempest/plugin.html#stable-tempest-apis-plugins-may-use
[3] http://lists.openstack.org/pipermail/openstack-dev/2017-February/112938.html

Change-Id: I8c2bb8b7b02e5e755d64fd29f9d20a55dc75ccdd
(cherry picked from commit 29e0732f)

Change-Id: I5467fed40b2b21855f6f00f9dbb1ce4371e7d010

Change-Id: Ieb98cd209828721757af8ef4725b933a17d99b3c

Change-Id: I87a12cb4b6f6e9033f13d66d718d15a2f67cabe8

This is a combination of 3 commits.

The first commit's message is:

Be explicit about the extensions being tested

Otherwise there the danger of skipping those important for SFC [1]

Co-Authored-By: Ihar Hrachyshka <ihrachys@redhat.com>
Co-Authored-By: Sean Dague <sean@dague.net>
Original-Commit: Ibd0f67f9131e7f67f3a4a62cb6ad28bf80e11bbf

Needed-By: Ie995f6875a1e2b4c1e47a6596d7e84d9d72c768b
[1] http://logs.openstack.org/11/442111/2/check/gate-tempest-dsvm-networking-sfc-ubuntu-xenial/0d87aca/console.html#_2017-03-07_20_40_34_903985

Change-Id: I4a51e25b7fc3c39beea69433e3230838ae2f65bc
(cherry picked from commit 5cb1e424)

This is the 2nd commit message:

Pin stable/ocata in tox_install

Change-Id: Iae1715cd8dcf8e73bed79173b22d3a8f72941fcd

Add all extensions to the tempest run

The post hook runs full tempest as well.

Change-Id: I19e4df1b26b05f08d0d770e2cbfebff6e7e91270
(cherry picked from commit 6c8e0d77a6275ab549100d7a5b8c3415872ccfd9)

The previous commit renders three bug fixes as a single bullet item.
This commit just modifies the YAML so that they will render to HTML
as three separate bullets.

Change-Id: I8f2ebff2d35851019564176e85fad8ba23131d0c

Change-Id: I671672dfebcd600080bec1fbff0501a37e236b07

This change allows Port Pairs to have correlation='mpls', and makes
the OVS Driver understand such correlation, preventing the addition of
"SFC Proxy" flows that remove the MPLS labels before sending packets
to the Service Functions.

In order to support the future SFC Graph resource,
encapsulation/correlation should be preserved across a whole graph
(dictionary of source to (list of) destination port-chains).

The following documentation was updated:
- doc/source/system_design and_workflow.rst

Change-Id: Iebdfca5467ca33cfd9d93d55f47d6b57b79dffbe
Closes-Bug: #1656526

As per https://docs.openstack.org/developer/neutron-lib/usage.html we
should enable any flake8 extensions neutron-lib’s tox.ini does

Change-Id: I72b2561b3eac0eb28e6286e7ebcb3418a827034f

Make each chain parameter have its own default value.

With this change, if the user creates a chain that specifies only the
'correlation' parameter, the 'symmetric' parameter will still be added,
and vice-versa. This allows the code to make more assumptions about
the definition of the chain, and the tests to be less specific about
the chains they want to simulate.

Change-Id: Idf1052e6bec92aad953e61542671316dff371b78

devstack-gate supports local.conf over localrc now:
https://review.openstack.org/#/c/326585/

This broke our tempest check, so dropping the only element filling
localrc file (sourcing devstackgaterc is needed all the time anyway to
get the DEVSTACK_GATE_TEMPEST_REGEX variable)

Change-Id: I9ee5e18cc5c879de500517e9c663ce99d01218d6
Closes-Bug: 1667485

    Add tempest_plugin scenario test cases for symmetric

Implements: blueprint symmetric-port-chain-ovs-agent

Co-Authored-By: Cathy Zhang <Cathy.H.Zhang@huawei.com>
Change-Id: I9c7c827e3cc83a0876e8cb8b66fda6fa0dc50c6a

    Add more symmetric test in drivers/ovs/test_driver.py

Implements: blueprint symmetric-port-chain-ovs-agent

Co-Authored-By: Cathy Zhang <Cathy.H.Zhang@huawei.com>
Change-Id: I4a4ed10338031c195ef1100b90a3416ecafe9e78

See Bug #1665960.
If not src/dst prefix is specified, then get the src/dst IP from
the logical-src/dst port and insert this prefix in the flowclassifier.

Change-Id:  I148e52b86ad0107ca63c92fcc800e9eb69f7a65a
Co-Authored-By: Cathy Zhang <cathy.h.zhang@huawei.com>
Partial-Bug: Bug #1665960 - Addresses unintended behavior but only
if the port has a single IP address.

    Add Unit db, extensions test for symmetric

Implements: blueprint symmetric-port-chain-ovs-agent

Co-Authored-By: Louis Fourie <louis.fourie@huawei.com>
Change-Id: I92a68587998addc0dceee87cba4a937638d4c195

   Add tempest_plugin api test cases for symmetric

Implements: blueprint symmetric-port-chain-ovs-agent

Co-Authored-By: Louis Fourie <louis.fourie@huawei.com>
Change-Id: Ic002c3cf7814445d0fb3830d9abbe233ed669d89

A couple of filters dictionary merge used hacking way, not sound logic
and poor readability. Replaced them with dictionary update functions.

Replaced dict function with dict literal to keep consistency with rest
of the code.

Change-Id: If5aa37c87ef9b0eb9101ca6e52bf370d358a0857

  Changes for symmetric chain support for OVS driver and agent

* Add fwd_path column in sfc_path_nodes table and in_mac_address
  column in sfc_portpair_details table in Database.
* Edit normalize_chain_parameters for parameters update to keep
  correlation when updating symmetric in extensions/sfc.py
* Add symmetric chain function in OVS driver and agent to enable
  SF chain.
* Create unit test for symmetric chain function

Implements: blueprint symmetric-port-chain-ovs-agent

Change-Id: I701d03a7aa6459d03062856ae77046990b5a257c
Co-Authored-By: Louis Fourie <louis.fourie@huawei.com>
Co-Authored-By: Cathy Zhang <Cathy.H.Zhang@huawei.com>

 - Add debug logging for update_flow_rules;
 - Use dictionary litrals instead of dict functions;
 - Fix typos, and reword messages;
 - Reform lines to increase readability;
 - Use the right way to merge dictionaries instead of hacking way.

Co-Authored-By: Louis Fourie <louis.fourie@huawei.com>

Change-Id: I40eb54b2e0ca8cad63f8e219c87985af4ecab990

    Pass update_flowrule_status function in drivers/ovs/driver.py

    * drivers/ovs/db.py will be removed in the future with 4 ovs tables,
      update_path_node function referred in this function and
      update_flowrule_status function itself will be no longer used.
    * On the other hand, this function currently raised:
        * RuntimeError: reentrant call
        * DBError: reentrant call
        * DBConnectionError: (pymysql.err.OperationalError)
              (2014, 'Command Out of Sync'))

Co-Authored-By: Louis Fourie <louis.fourie@huawei.com>

Partial-Bug: #1665406
Change-Id: Ib84f4dcc47bc6bd0ba4b138708c9f31e06a04c69

The following issues were addressed:
 - Dictionary creation could be rewritten by dictionary literal
 - PEP 8 naming convention violation
 - Unused local

Change-Id: I1b861f84b24044ea99f48ac7cb17e341a2968000