[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html



Co-Authored-By: Moisés Guimarães de Medeiros <moguimar@redhat.com>
Change-Id: I407b2c9bc6e9c1cd5b070a1cdca7c0eabe19b0ca
(cherry picked from commit f4e54d93)

This is because there's no yaml representer for i18n Messages object.
This patch aims to add this representer and allow the generation of
configurations using oslo.i18n strings.

One example of this is cinder.

Closes-bug: #1928582
Change-Id: I70ab87c9bed093cad883b6301b8a09753fc470d9
(cherry picked from commit e5fc313e)
(cherry picked from commit de1dbeed)
(cherry picked from commit 0950f82e)

There's currently a conflict when installing test-requirements.txt with
lower-constraints.txt.

The conflict is caused by:
    The user requested flake8<3.8.0 and >=3.6.0
    The user requested (constraint) flake8==2.5.5
    oslotest 3.2.0 depends on python-subunit>=1.0.0
    stestr 2.1.0 depends on python-subunit>=1.3.0

Change-Id: Id6f70b27df117f35a6bd5a6b38b4ffaee7e930b3

HostDomain is like HostAddress with the support of
_ character - RFC1033

openstack services are failing to start when a hostname with underscore
_ is provided.

Example:

```
overcloud-novacompute_edge1-0.internalapi.localdomain
overcloud-novacompute_edge1-0.internalapi
```

Nova use `HostAddressOpt` to define `live_migration_inbound_addr`,
and if a hostname with underscore is present in the config file
then the service fail to start.

Example:

```
/etc/nova/nova.conf
live_migration_inbound_addr =
overcloud-novacompute_edge1-0.internalapi.localdomain
```

FQDN is a domain name that specifies its exact
location in the tree hierarchy of the Domain Name System (DNS).

Underscore are allowed by RFC1033 [1][2][3]. Indeed, while a hostname may not
contain other characters, such as the underscore character (_), other
DNS names may contain the underscore.[1][2].
Systems such as DomainKeys and service records use the underscore.

These changes allow us to use underscore with the `HostDomain`.

[1] https://www.ietf.org/rfc/rfc1912.txt
[2] https://www.ietf.org/rfc/rfc1033.txt
[3] http://domainkeys.sourceforge.net/underscore.html



Co-authored-by: Daniel Bengtsson <dbengt@redhat.com>
Change-Id: I0a0670207f96a987996d329e5efa9a5eb2ce000c
Closes-Bug: #1892044
(cherry picked from commit 64803569)
(cherry picked from commit f37bcc77)

Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/ussuri branch, tests will
continue to use the upper-constraints list on master.

Change-Id: I36fb84fdb2894f5286490499f02cc19dcf5392dc

Change-Id: Ib3aecf1f14cec56d9e329a0c9c58a485d9c772e8

This now fails with the newest Sphinx due to multiple entries between
the added reference to the class's docstrings, and the docstrings
themselves. This fixes the warnings by just removing the duplication.

Also includes a squash of b1836ad4


to cap flake8 to be < 3.8.0. The pep8 job will fail without this one,
but that can't merge because the docs job fails without this docstring
change.

Change-Id: I284a49a5df9506f936ebf1846688339c94d9a6b8
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
(cherry picked from commit 1b248b4f)

Update the minversion parameter to use the python -m pip to install
python packages:

https://tox.readthedocs.io/en/latest/changelog.html#id185

It's recommend to use this.

Change-Id: Ib7cd076c167c5e47d7241995fb308cd3b8c9db42

Add the requirement, tox job, and basic configuration.

Change-Id: I3a865255ee731a27a00e7653557099fb99096486

This bumps the version of flake8 and pycodestyle to something much
newer, which resolves a long-standing warning about nested sets and
allows us to use new fangled features like f-strings if we so choose.

Note that this requires some minor modifications to keep the 'pep8' task
passing.

Change-Id: I3af8eb490345a6152372730ca3e0a6702bf482ea
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>

We don't need this in a Python 3-only world. We can't remove mock yet
since there's an issue with the stdlib variant in python3.6, but that is
called out.

Change-Id: I9657b1fd4409be90d645175a6e177d7e1d2ebac2
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>

Update the minversion parameter to use the python -m pip to install
python packages:

https://tox.readthedocs.io/en/latest/changelog.html#id185

Also Inherit the jobs requirements to simplify maintainance.

Change-Id: I730f15a4872334f040d5bd03da37e7c4f9e8148b

Change-Id: I09bfa2e97bb20b3be0b801c7e76ce93b8db6d0cb

Now that we've dropped py2 support we shouldn't be setting this
anymore.

Change-Id: I9a5e096e528ccf47f50b0ea67463cbe0cd359cd9

Change-Id: I39fbf54eb74843cd268c8cbac0a372927fff00e7

OpenStack is dropping the py2.7 support in Ussuri cycle.

Complete discussion & schedule can be found in
- http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010142.html
- https://etherpad.openstack.org/p/drop-python2-support

Ussuri Communtiy-wide goal:
https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html



Change-Id: I13ce8e8264679a19c7b108381ccb969573ea9ac6
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Sem-Ver: api-break

Move 'basepython' to the top-level 'testenv'.

Change-Id: I4957925d96c2eea0f9a2d791feb71b6d3f54a224

Add a section to the configuration guide to list all of the drivers
using stevedore's sphinx integration.

Change-Id: I6348f83efdd8a572821d2851ee4bd883f9e7e2b4
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Per the deprecation in change I04baae695a7ba0bb93c91ea642c4e33c04bf87bd
this can be removed.

Change-Id: I31156e2f47b0d68ea32726cde7f0c2b133022c9f

oslo.config allows us to configure groups and options dynamically. This
can cause a race with our logging as we attempt to iterate through
option groups that are changing under our feet. This wouldn't be a huge
issue, since these are just logs are we can always log again, if needed,
but we store groups in a dictionary and Python doesn't like us changing
the size of a dict it's iterating through:

  RuntimeError: dictionary changed size during iteration

Given that we're only reading through this option group and don't need
to worry about a group _disappearing_, the solution is pretty simple:
create a copy of our option group names ahead of time so we don't need
to worry about new ones coming and messing things up.

No tests are included since this is a race and the only way I see to
reproduce this would involve lots of ugly threading.

Change-Id: Id3b28465d645a24f0fcebff2dd68a9bd30e21594
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Closes-Bug: #1856312

Currently, we are overriding 'install_command' to use 'pip'. This is
considered poor behavior and 'python -m pip' should be used instead:

https://snarky.ca/why-you-should-use-python-m-pip/

It turns out that this is the the default value provided by tox:

https://tox.readthedocs.io/en/latest/config.html#conf-install_command

So we can remove the line and simply use the default value.

Change-Id: Ibcdd3a9f7e7ea421e906cf1d96f95b516008b5d7

"%d" will truncate float and generates wrong format message,
use "format" to handle floats correctly.

Closes-Bug: 1850879
Change-Id: If0dd3933695ac84f0e9cacefd28a9d7a60dd88d7

Change-Id: Icd54952c987153b0473872733db2bf7253d7c1f1

Sphinx 1.8 introduced [1] the '--keep-going' argument which, as its name
suggests, keeps the build running when it encounters non-fatal errors.
This is exceptionally useful in avoiding a continuous edit-build loop
when undertaking large doc reworks where multiple errors may be
introduced.

[1] https://github.com/sphinx-doc/sphinx/commit/e3483e9b045

Change-Id: Ied9f46640cf2f338a5784e1c72998f93b5c860c5

Change-Id: I592a110921707656748c48a62c038131d003db6c