SQLAlchemy 1.4 has modified the URL object to be immutable.
This patch makes the adjustments needed, using duck-typing
to check if the URL object is of the new style.  When
requirements reach SQLAlchemy 1.4 as the minimum required
version, these conditionals should be removed in favor of
the noted option in each.

CentOS Stream 9 is shipping sqlalchemy 1.4.

Change-Id: Id2f0663b13ed0f81e91a8d44f73d8541015bf844
(cherry picked from commit f37269ae)

Another change for SQLAlchemy 1.4 is the mechanics
of how the ``QueryContext`` object works.   Update the
update_match extension such that it does not rely upon the
``QueryContext`` object and uses public APIs instead.

Change-Id: I27e20e59bce8c98b5a507c617364652aa6eb33f5
(cherry picked from commit f2a94b6f)

Followup of change: Ic78059b625e73cece355541cb4d89e641abc1103

Change-Id: Idb0410a1946acbd7caf6a0bb1dad229bd5c2c346
(cherry picked from commit be2cc6a2)

These were missed in change : Icd090cf8a36fa560bf7b0c67d0e1c4923c221c65

Change-Id: I07b577f4e948c03d1751145e5f898b90ac1c197a
(cherry picked from commit ad720c33)

We facing errors related to the new pip resolver, this
topic was discussed on the ML and QA team proposed to
to test lower-constraints [1].

I propose to drop this test because the complexity and recurring pain needed
to maintain that now exceeds the benefits provided by this mechanismes.

[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html

Change-Id: Icd090cf8a36fa560bf7b0c67d0e1c4923c221c65
(cherry picked from commit a53ec14e)

In mysql 8.0.19 , Duplicate key error information is extended to
include the table name of the key.Previously, duplicate key error
information included only the key value and key name.

Unit tests are provided for updated changes.

Change-Id: Ic78059b625e73cece355541cb4d89e641abc1103
Closes-Bug: #1896916
(cherry picked from commit 2c2e6d48)

Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/wallaby branch, tests will
continue to use the upper-constraints list on master.

Change-Id: Ic41b1877414e57a13a311c2effc209a22f855c6a

Change-Id: I9583729a8603d76c33b248f67ccc0bf2b0bd6f61

This is a combination of 2 commits that both needed to unblock
stable/wallaby gate:

1. Remove contradictions in lower-constraints

This will avoid the following issue seen recently on wallaby and on
projects where lower-constraints tests haven't been yet dropped:

```
ERROR: Could not find a version that satisfies the requirement
bandit<1.7.0,>=1.6.0
ERROR: No matching distribution found for bandit<1.7.0,>=1.6.0
```

Also some other packages lower constraints has to bump to avoid
further contradictions and slow run of the pip resolver.

2. move flake8 as a pre-commit local target

The goal here is to avoid conflicts between flake8 and hacking version each
2 days.

Inspired from nova's approach [1].

The flake8 version to install will be determined by hacking and
requirements will stay aligned instead of relying on different versions.

[1] https://opendev.org/openstack/nova/src/branch/master/.pre-commit-config.yaml#L26-L35
[2] https://opendev.org/openstack/hacking/src/branch/master/requirements.txt#L1

Conflicts:
    pre-commit-config.yaml

(NOTE) hberaud: Original commit was made on the top of intermediary
changes on master.

Change-Id: Iae20f13ba6293b94b5bd131941263e097eba0518
(cherry picked from commit 7443bcd0)

This API allowed users to abstract the differences between
sqlalchemy-migrate and alembic. However, no one is using it for that and
its continued existence necessitates continued support for
sqlalchemy-migrate. Deprecate it now and encourage the odd user to
switch to alembic directly.

Change-Id: Ia5979369f23b38a2c7307f4112651a8bedb45c01
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

This module hasn't been touched with years and 'sqlalchemy-migrate' is
effectively abandoned. It's time to drop support for this an encourage
the laggards to switch to alembic and use it directly.

Change-Id: I59335b4f318bae2e29ab139cdea089a4d6e14305
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: If6de09e513ec778f9b5f8c34d985aeea640d6002

Introduced changes:
- pre-commit config and rules
- Add pre-commit to pep8 gate, Flake8 is covered in the pre-commit
hooks.
- Applying fixes for pre-commit compliance in all code.

Also commit hash will be used instead of version tags in pre-commit to
prevend arbitrary code from running in developer's machines.

pre-commit will be used to:
- trailing whitespace;
- Replaces or checks mixed line ending (mixed-line-ending);
- Forbid files which have a UTF-8 byte-order marker
(check-byte-order-marker);
- Checks that non-binary executables have a proper
  shebang (check-executables-have-shebangs);
- Check for files that contain merge conflict strings
  (check-merge-conflict);
- Check for debugger imports and py37+ breakpoint()
    calls in python source (debug-statements);
- Attempts to load all yaml files to verify syntax (check-yaml);
- Run flake8 checks (flake8) (local)

For further details about tests please refer to:
https://github.com/pre-commit/pre-commit-hooks

Change-Id: Id03c1ea4752...

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for wallaby.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I017723df2eca2e3aa00553f19628bfbd8aa93f41

Add file to the reno documentation build to show release notes for
stable/victoria.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.

Change-Id: Iefed09b57fffca3a62ec4467e1d18a5f4724c474
Sem-Ver: feature

As per victoria cycle testing runtime and community goal[1]
we need to migrate upstream CI/CD to Ubuntu Focal(20.04).

Fixing:
- Bump the lower constraints for required deps which added python3.8 support
in their later version.

Story: #2007865
Task: #40207

[1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal.h>

Change-Id: I978482f860a766c474944c77e2c569541f4849b1

This patch bumps bandit allowed version to >=1.6.0,<1.7.0 in order to
avoid the errors detailed here https://github.com/PyCQA/bandit/pull/393



Change-Id: I44f0b485266d6a03d12953f3f45e476ba821a00c
Signed-off-by: Moisés Guimarães de Medeiros <moguimar@redhat.com>

Change-Id: I9525eda24465bdedb9ae917350263fa91e9b780a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Starting from mysql version 8 it's not possible to create a user
implictly when using GRANT.

This patch makes the behavior compatible with that.

Change-Id: I42912629daaca44250270fca8d9534b801e95d7b
Co-written-by: Riccardo Pittau <elfosardo@gmail.com>
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

New theme of docs respects pygments_style.

more info: http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html

Change-Id: I572495d50e0edc8bdfe22594dcde30a61b0750b8

SQLAlchemy will be defaulting create_constraint to
False in an upcoming major release [1].  As this
test relies upon the CHECK constraint being present,
set create_constraint to True.

[1] https://github.com/sqlalchemy/sqlalchemy/issues/5367

Change-Id: Ie822172ef797dc1bf8050d9b5cabe6782120ea45

Change-Id: I4674616e3adda12f67ed143c23363a7e58f71caa

Switch to openstackdocstheme 2.2.0 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems

Update Sphinx version as well.

openstackdocstheme renames some variables, so follow the renames. A
couple of variables are also not needed anymore, remove them.

Depends-On: https://review.opendev.org/728938
Change-Id: I072cf215486d672eacd3a57483cb2b311483c844

Python modules related to coding style checks (listed in blacklist.txt in
openstack/requirements repo) are dropped from lower-constraints.txt
as they are not actually used in tests (other than pep8).

more info: https://github.com/openstack/requirements/blob/master/blacklist.txt

Change-Id: I01944ebdbf6311580f8991da61256e93be6823b3

These translation sections are not needed anymore, Babel can
generate translation files without them.

Change-Id: I8d86954ea4cb02f03ad8477e8380a9edaef3440b

Related to:
- https://review.opendev.org/#/c/723044/
- https://governance.openstack.org/tc/goals/selected/ussuri/project-ptl-and-contrib-docs.html

Change-Id: I0e4bca478301e9aba4a6a22b8d8a5bdc6aa2224f

Python 3.8 is now our highest level supported python runtime.
This updates the default tox target environments to swap out
py37 for py38 to make sure local development testing is
covering this version.

This does not impact zuul jobs in any way, nor prevent local
tests against py37. It just changes the default if none is
explicitly provided.

Change-Id: Id0107e9cdabbc1435c709641b93cb5c90cdf6907
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

Now that we are running the Victoria tests that include a
voting py38, we can now add the Python 3.8 metadata to the
package information to reflect that support.

Change-Id: I2826ded6a4be7507fc61e68fe6d9204682382252
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>