oslo.db 11.0.0 release

meta:version: 11.0.0
meta:diff-start: -
meta:series: xena
meta:release-type: release
meta:pypi: yes
meta:first: no
meta:release:Author: Hervé Beraud <hberaud@redhat.com>
meta:release:Commit: Hervé Beraud <hberaud@redhat.com>
meta:release:Change-Id: Icc048cb736d1e73737b98f6134e955d22bf46cf7
meta:release:Code-Review+2: Hervé Beraud <herveberaud.pro@gmail.com>
meta:release:Code-Review+2: Elod Illes <elod.illes@est.tech>
meta:release:Workflow+1: Elod Illes <elod.illes@est.tech>

oslo.db 8.5.1 release

meta:version: 8.5.1
meta:diff-start: -
meta:series: wallaby
meta:release-type: release
meta:pypi: yes
meta:first: no
meta:release:Author: Stephen Finucane <sfinucan@redhat.com>
meta:release:Commit: Stephen Finucane <sfinucan@redhat.com>
meta:release:Change-Id: I333a89a2990861b75ee28539839c7134a3f809ab
meta:release:Code-Review+1: Brin Zhang <zhangbailin@inspur.com>
meta:release:Code-Review+2: Hervé Beraud <herveberaud.pro@gmail.com>
meta:release:Code-Review+2: Elod Illes <elod.illes@est.tech>
meta:release:Workflow+1: Elod Illes <elod.illes@est.tech>

We've started using sqlalchemy features that were introduced in 1.4,
which means we need to bump our lower constraint. Do this now.

At some point, we probably want to dump all lower-constraint information
from these files since it's no longer maintainable without the
equivalent job. That's a task left to later, however.

Change-Id: I8629225eeb51d95264d8a3e4b719268bb1597f4f
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Resolve the following RemovedIn20Warning warning:

  Using plain strings to indicate SQL statements without using the
  text() construct is  deprecated and will be removed in version 2.0.
  Ensure plain SQL statements are passed using the text() construct.

Change-Id: I8acdb54d168afa1a7eac270ad6165faa287311ec
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Resolve the following MovedIn20Warning:

  The ``declarative_base()`` function is now available as
  sqlalchemy.orm.declarative_base()

Change-Id: I5fd707c62d0bfad6e54150c4a3b87aadadbeedb3
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Resolve the following RemovedIn20Warning warning:

  The autoload parameter is deprecated and will be removed in version
  2.0.  Please use the autoload_with parameter, passing an engine or
  connection.

Change-Id: Ie039851005c6038591e0e1f6426922ca5b0dcb9a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Resolve the following RemovedIn20Warning warning:

  The update.values parameter will be removed in SQLAlchemy 2.0.  Please
  refer to the Update.values() method.

Change-Id: I426605aa8f4332fd0b7d9f6fa0e97d7e02c7cbdc
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Resolve the following RemovedIn20Warning:

  The update.whereclause parameter will be removed in SQLAlchemy 2.0.
  Please refer to the Update.where() method.

Change-Id: I50064d16de6e1951b2282fcf9548a0ff2cd0fe55
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Resolve the following RemovedIn20Warning warning:

  The insert.values parameter will be removed in SQLAlchemy 2.0.  Please
  refer to the Insert.values() method.

Change-Id: I52ff0c44039d8d1ee09210d9a990d0e40bbfa411
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Resolve the following RemovedIn20Warning warning:

  The ``bind`` argument for schema methods that invoke SQL against an
  engine or connection will be required in SQLAlchemy 2.0.

Change-Id: If9492a3842055dde3841eaeb72fb4c050563b6ac
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Resolve the following RemovedIn20Warning warning:

  Passing a string to Connection.execute() is deprecated and will be
  removed in version 2.0.  Use the text() construct, or the
  Connection.exec_driver_sql() method to invoke a driver-level SQL
  string.

Change-Id: I1faa8c957649a04aa080518651045b432c6bd372
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Resolves the following RemovedIn20Warning warning:

  The MetaData.bind argument is deprecated and will be removed in
  SQLAlchemy 2.0.

Change-Id: I468048c01455d9dfe12004736c181806dc218e37
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Resolve the following SADeprecationWarning warning:

  The legacy calling style of select() is deprecated and will be removed
  in SQLAlchemy 2.0.  Please use the new calling style described at
  select().

Change-Id: Ic5f7240e790425d2689c6870483748650a49bc3d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Well, sort of. We enable them but immediately filter out the ones we're
actually seeing, the rationale being that we can address these in a
piecemeal fashion without the risk of introducing new issues.

Change-Id: I32cad5fd9ddbfd2ff6b62e5e2f87fad6ece7a4c1
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

These are using private APIs of SQLAlchemy but, more importantly, are
not necessary in an alembic-only world. Mark them deprecated for
removal.

Change-Id: I6efb6e1d35542cd8df922c86e134fe1e0b8c2e52
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Highlight use of deprecated SQLAlchemy APIs to ensure we keep on top of
things. This requires resolving the following SADeprecationWarning
warnings:

  The from_engine() method on Inspector is deprecated and will be
  removed in a future release.  Please use the sqlalchemy.inspect()
  function on an Engine or Connection in order to acquire an Inspector.

  The Column.copy() method is deprecated and will be removed in a future
  release.

  The ColumnCollectionConstraint.copy() method is deprecated and will be
  removed in a future release.

There are more warnings to be resolved related to SQLAlchemy 2.0, but
those require a special environment option (SQLALCHEMY_WARN_20) to
trigger and a lot of work to resolve. We'll address those in a series of
follow-ups.

Change-Id: I34b395e6d50f4e4151178c327d94308e6f5d5b6e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

The final step in cleaning up our many base classes. This will allow us
to do things consistently across the test suite in future changes.

Change-Id: I0bf663fdfd3c8be93e5658493e221d0a7db78832
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

We have quite a few base test classes in use. Start fixing these by
removing the logic from one of these. We will remove the class entirely
in a future change.

Change-Id: I6dae26aeb4b2a5cc4f39ed637807a27e44d40025
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

This base test isn't actually used by anything but we're going to change
that shortly. Before we do, address a longstanding TODO and make it
subclass 'oslotest.BaseTestCase'. Because 'oslotest.BaseTestCase'
already configures all of the fixtures we're currently using, our own
base test class ends up being a simple wrapper. This will also change in
the future.

Change-Id: I110392586fb032507d122ae9a412a6bba7c5ff2d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

This hasn't been supported by any project for many years. Quoting from
the nova patch that removed DB2 support [1]

  This removes db2 support from tree completely. This is an oddball non
  open database that made doing live data migrations difficult. It is
  used by 0% of users in the OpenStack User Survey.

  Supporting commercial software that doesn't have users at the cost of
  delivering features and fixes to our community is the wrong tradeoff.
  This corrects that.

There's no need to keep this around.

[1] Ifeb9929e4515e3483eb65d371126afd7672b92a4

Change-Id: I8c3f23083e09e5ac924e35d1b7b3248a0d074e1b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Followup of change: Ic78059b625e73cece355541cb4d89e641abc1103

Change-Id: Idb0410a1946acbd7caf6a0bb1dad229bd5c2c346
(cherry picked from commit be2cc6a2)

We were actually running tests four times. Twice with eventlet disabled
and twice with it enabled. Correct this.

Change-Id: Idb3926d73ff3c11abe9c273062aca1b299b9f72e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

These were missed in change : Icd090cf8a36fa560bf7b0c67d0e1c4923c221c65

Change-Id: I07b577f4e948c03d1751145e5f898b90ac1c197a
(cherry picked from commit ad720c33)

We facing errors related to the new pip resolver, this
topic was discussed on the ML and QA team proposed to
to test lower-constraints [1].

I propose to drop this test because the complexity and recurring pain needed
to maintain that now exceeds the benefits provided by this mechanismes.

[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html

Change-Id: Icd090cf8a36fa560bf7b0c67d0e1c4923c221c65
(cherry picked from commit a53ec14e)

In mysql 8.0.19 , Duplicate key error information is extended to
include the table name of the key.Previously, duplicate key error
information included only the key value and key name.

Unit tests are provided for updated changes.

Change-Id: Ic78059b625e73cece355541cb4d89e641abc1103
Closes-Bug: #1896916
(cherry picked from commit 2c2e6d48)

The 'check_foreign_key' method was removed in oslo.db 1.4.0 [1] and
re-added but marked as deprecated in 1.4.1 [2] to allow for a
deprecation period. That was over 6 years ago so we can now remove it.
Meanwhile, the private '_walk_versions', '_migrate_down' and
'_migrate_up' methods have been marked as deprecated since oslo.db 0.5.0
(!!!) [3]. We can definitely remove these now. codesearch.o.o reveals no
users of any of these methods.

[1] I77a2bba2de08125b5a601de03c1d2d5c73fa33ee
[2] Id892567bd60d6b4b88765bbfe3cd5c5e75910b25
[3] Ic9358445e60a0dd43a5900e8bda7b12f2bebf679

Change-Id: Idb9596284df3e5d038c939d27fe14fe2cc2f4318
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

This has been marked as experimented since before oslo.db was split out
of nova. We've no test coverage and no idea of whether it even works
nowadays. It's time to plan for its eventual removal.

Change-Id: Ib7a5a6e1124c44a742b003442f815022a866bcbb
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

We already state a minimum in our requirements.txt files to prevent use
of this package with older alembic and sqlalchemy releases, making these
checks simply noise. Remove them.

Change-Id: Ie3fbc54aa0c791e6e8ca3164c95051039e82b0e3
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>