Use a default value of None for facility in OSJournalHandler
class, as is done in the OSSysLogHandler class.

Neutron started failing with a:

 E1120: No value for argument 'facility' in constructor call

With a recent release of oslo.log.

Change-Id: I5269b82d219fd2377535120d9d266238d50431b3
Related-Bug: #1871840
(cherry picked from commit 184235c2)

Without SYSLOG_FACILITY log messages from journald forwards the message
to kern.log. This seems to be default behaviour as it treats the message
as kernel message.

This option provides a proper facility to the log message and kern.log
will not be filled up anymore.

Cherry-picked from commit 5b12e66f
Change-Id: I62a32ed46a400b62ead8c1e6e64acee658e2a769
Closes-Bug: #1871840

Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/ussuri branch, tests will
continue to use the upper-constraints list on master.

Change-Id: I0e741ae1960cf4fd933044a63df6ceecd9fb3d72

Change-Id: I308991827474bc32d46b39f783041890ae9f8900

Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.

Change-Id: I5587ac8f603798aad27908d3bd6ed8ebb3a9c14e
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

Change-Id: I0ad972f48ee6bc331b96aa67bd7e69c97fa8e2c3

Now that we have names for the next two releases we can get them
added here so we'll be ready when development starts.

Change-Id: I515a6b03b810a7c8b2246279e380973a29c626f4

Change-Id: I4451a0d216bc0ed0f4000c5590e12d1378bd0a41

Change-Id: I2c34c98ba6c927a0b1048e998ff50e063e94b481

Remove forgotten bdist wheel config

Change-Id: I0c06914b9cdf57924dbb3a961d226019e7cff5eb

Change-Id: I2a5a8b83d965ab6837ae01640ea4525284a0e7be

Ussuri Communtiy-wide goal:
https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html

Change-Id: If6d6357501dfdff5a5edb53f24104e216607ea00
Sem-Ver: api-break

unittest2 was needed for Python version <= 2.6, so it has not been
needed for quite some time now. See unittest2 note on:

https://docs.python.org/2.7/library/unittest.html



This replaces unittest2 in favor of the standard unittest package.

Change-Id: Idd5df4c8068810bbbd2bd5058ca38df9f5416a62
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

Move 'basepython' to the top-level 'testenv'.

Change-Id: I7269b71668b7d37886bdfd02a188cc9d6fd0c958

This was optionally being enabled to handle the case where we did not
have oslo.serialization 2.21.1. Our minimum version is now 2.25.0 so
this will never be the case. Remove this optionality logic.

Change-Id: Ib61e1fd02a5ec98ddcaed2ce42f049636598870f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>

This change introduces the serialization with basically json dumps,
falling back to repr for non-serializable object. We check the types
of the top level objects passed to the formatter, as for example
an object enclosed into dictionary passed to the logger should be a
much more rare case.

Closes-Bug: 1782361
Change-Id: Ib214f95abfadd91f85b6cce853057a572ec287f6

As part of community goal of dropping py27 support[1], we are
moving the devstack to py3 by default[2]. That will make grenade job
to perform upgrade from py2 to py3 which will not work (we have seen
the failure in neutron-grenade job).

To avoid existing grenade py2 job break, this commit moves grenade
jobs to py3 which is what we planned as part dropping the py2 support.

[1] https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html
[2] https://review.opendev.org/#/c/649097/12
    http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010938.html

Change-Id: I8cab5e17e6f7ce743136c013faddf56497ca5def

Sphinx 1.8 introduced [1] the '--keep-going' argument which, as its name
suggests, keeps the build running when it encounters non-fatal errors.
This is exceptionally useful in avoiding a continuous edit-build loop
when undertaking large doc reworks where multiple errors may be
introduced.

[1] https://github.com/sphinx-doc/sphinx/commit/e3483e9b045

Change-Id: Icbc670ba49e0cf9e1ce33b33a16231ec64ddf042

Change-Id: I4c9bc47034d6ecf405126b9919ef483da8a495b0

Add file to the reno documentation build to show release notes for
stable/train.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/train.

Change-Id: I638b57b529a76135a62ce6606629a474f6b4b4d5
Sem-Ver: feature

Now that we have a name we can add it to the list.

Change-Id: Icf10c2c8b1a5c90602dc0880f838bc9481e9b87e

See the Train python3-updates goal document for details:
https://governance.openstack.org/tc/goals/train/python3-updates.html

Change-Id: Iae43c960b980ba3c1aa83be8844ae2f873f9c186

Python 3.7 added caching of the log level for calls to isEnabledFor
on a logger[0]. As a result, modifying the logger level directly
can cause a mismatch in behavior if a log call was made prior to
that modification. In our case, we were calling logger.info before
the info level was enabled, which meant the logger cached the fact
that it was not enabled for info-level logging. Even after setting
the level to NOTSET, it was still remembering that it shouldn't log
info messages and that breaks our unit tests on py37. There is a
related issue open against Python[1], but basically the answer there
was "don't mess with logger internals".

The simple fix is to use logger.setLevel for resetting the log level
instead of modifying the attribute directly.

Change-Id: Ifd1300d8e4280df1913f632e964f9458dbb2db55
0: https://github.com/python/cpython/commit/78c18a9b9a1445f7c755929917a790ba02b4a5e0#diff-5bd69232a06838f179312d3e48ccf506
1: https://bugs.python.org/issue34269
Closes-Bug: 1783630

Some options are now automatically configured by the version 1.20:
- project
- html_last_updated_fmt
- latex_engine
- latex_elements
- version
- release.

Change-Id: I61f26bed7831cdcce1f33f3981c3e97b018c4c42

See https://github.com/sphinx-doc/sphinx/issues/6440 for upstream details
Depend-On: https://review.opendev.org/#/c/663060/

Change-Id: Ic5fe18b6c0b0b59310b0adbf05c2d6583ff759f4

Incubator logging has been gone for years. Nobody still needs these
docs, and on the off chance that I'm wrong they're still available
in git.

Change-Id: I4757f93c4194bd821232a2f6cc9abf3be00f15d0

Use the hotness for constraints.

Change-Id: I73e284393ce26c91ea675d5be213ff5e910b4dfe

Convert the logging guidelines from the previous cross-project spec:

  https://specs.openstack.org/openstack/openstack-specs/specs/log-guidelines.html

so that they read as documentation rather than a spec, in order to
encourage developers down the right lines.

Also port a section on variable interpolation from oslo.i18n.  It was
misplaced there because it wasn't specific to i18n, and anyway logs
are no longer translated so it had to be removed from there by
Ib86013ff5e7b.

Change-Id: I3b8299b7a53e9e22c507930aa7a37c81ebcd580e

Translation of log messages was ceased starting with Pike, but only
the oslo.i18n documentation was only partially updated (by
Ia34ad79ca9), and not this repository.

So remove misleading examples of log translation from this
documentation.

Change-Id: Ib86013ff5e7bd07ddc696da2e4c56ce9d07f0cb6

Prepare a periodic job used to check possible issue on requirements
due to the python 2.7 final countdown and requirements
who remove python 2.7 support. We will check it daily
to see potential errors quickly outside the
standard development lifecycle (feature, fix, etc...)

Change-Id: I7773e41ec48246fb56e7366a359c067788c9f5bb

We do not need tox_install.sh, pip can handle constraints itself
and install the project correctly. Thus update tox.ini and remove
the now obsolete tools/tox_install.sh file.

This follows https://review.openstack.org/#/c/508061

 to remove
tools/tox_install.sh.

Change-Id: I67c50430ced6efcc2f29ec7d8adc871415922d6f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>

Bandit 1.6.0 accidentally changed how to exclusion list option is
handled and breaks our use of it. Cap to the previous version until
bandit has has fixed the problem.

Sphinx 2.0 no longer works on python 2.7, so need to start capping it
there as well.

Limit monotonic to python < 3.3 and reflect the changes to
openstack/requirements introduced
in change Ib8c1bf08f5fa7463911602b0df19315907c81e04.

Co-Authored-By: Stephen Finucane <sfinucan@redhat.com>
Co-Authored-By: Hervé Beraud <hberaud@redhat.com>

Change-Id: I4c2a19fae55e8cfea2d5ae9603a1fb086b5db1bf