Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/wallaby branch, tests will
continue to use the upper-constraints list on master.

Change-Id: Ie335a6ce2b63e1f7a7ad7a8869fbbae2dfc9b3a7

Change-Id: I92de0aae3a3e9f10c7864cd64d41e08d2206718b

This patch is the merge of 2 current fixes that need to be solved in the
same time. Indeed each issue lock our gates independently.

Dropping lower constraints testing

We facing errors related to the new pip resolver, this
topic was discussed on the ML and QA team proposed to
to test lower-constraints [1].

I propose to drop this test because the complexity and recurring pain needed
to maintain that now exceeds the benefits provided by this mechanismes.

[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html

Move flake8 as a pre-commit local target.

The goal here is to avoid conflicts between flake8 and hacking version each
2 days.

Inspired from nova's approach[1].

The flake8 version to install will be determined by hacking and
requirements[2] will stay aligned instead of relying on different versions.

[1] https://opendev.org/openstack/nova/src/branch/master/.pre-commit-config.yaml#L26-L35
[2] https://opendev.org/openstack/hacking/src/branch/master/requirements.txt#L1



Co-authored-by: Daniel Bengtsson <dbengt@redhat.com>

Change-Id: Ia349eba36d8556d4d2775a83b9a344b2ebeed972
(cherry picked from commit 5f5db610)

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for wallaby.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I9e5f495822942695ffbcba0bbbebcd7ec6489381

Add file to the reno documentation build to show release notes for
stable/victoria.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.

Change-Id: I7789349e07a11a0107db7b149ae0e71b301c31db
Sem-Ver: feature

Introduced changes:
- pre-commit config and rules.
- Add pre-commit to pep8 gate, Flake8 is covered in the pre-commit hooks.
- Applying fixes for pre-commit compliance in all code.

Also commit hash will be used instead of version tags in pre-commit to
prevend arbitrary code from running in developer's machines.

pre-commit will be used to:
- trailing whitespace;
- Replaces or checks mixed line ending (mixed-line-ending);
- Forbid files which have a UTF-8 byte-order marker
  (check-byte-order-marker);
- Checks that non-binary executables have a proper
  shebang (check-executables-have-shebangs);
- Check for files that contain merge conflict strings
  (check-merge-conflict);
- Check for debugger imports and py37+ breakpoint()
  calls in python source (debug-statements);
- Attempts to load all yaml files to verify syntax (check-yaml);
- Run flake8 checks (flake8) (local)

For further details about tests please refer to:
https://github.com/pre-commit/pre-commit-hooks



Change-Id: Ic88cf026a74e9da4acaf9e00c50fddd2c8a48fbe
Signed-off-by: Moisés Guimarães de Medeiros <moguimar@redhat.com>

As per victoria cycle testing runtime and community goal[1]
we need to migrate upstream CI/CD to Ubuntu Focal(20.04).

Fixing:
- bug#1886298
Bump the lower constraints for required deps which added python3.8 support
in their later version.


Story: #2007865
Task: #40207

Closes-Bug: #1886298

[1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal.h>

Change-Id: Ic7b25781fad8868665f445bd7bef4f51284be192

This patch bumps bandit allowed version to >=1.6.0,<1.7.0 in order to
avoid the errors detailed here https://github.com/PyCQA/bandit/pull/393



Change-Id: I23fd4082e2566242b5fce093a4685c97663c947f
Signed-off-by: Moisés Guimarães de Medeiros <moguimar@redhat.com>

Change-Id: I422125b137a3beadb0a79f5944a19fce62f093d6
Closes-Bug: #1887506

assertItemsEqual was removed from Python's unittest.TestCase in
Python 3.3 [1][2]. We have been able to use them since then, because
testtools required unittest2, which still included it. With testtools
removing Python 2.7 support [3][4], we will lose support for
assertItemsEqual, so we should switch to use assertCountEqual.

[1] - https://bugs.python.org/issue17866
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
[3] - testing-cabal/testtools#286
[4] - testing-cabal/testtools#277

Change-Id: Ib8a08f1b44712bf2fbcadecdcecd0ee3dd8ab361

New theme of docs respects pygments_style.

more info: http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html

Change-Id: I0027294e6b0af6cbf8edbbde4ca4098e50648229

Change-Id: I4cc395093d9cc2f2e0c15c3578d049fbda686ef5

Switch to openstackdocstheme 2.2.0 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering
Update Sphinx version as well.

Remove docs requirements from lower-constraints, they are not needed
during install or test but only for docs building.

openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.

Depends-On: https://review.opendev.org/728938
Change-Id: I5511824a7ebba08c330efaf5118f130630aa52ae

Python modules related to coding style checks (listed in blacklist.txt in
openstack/requirements repo) are dropped from lower-constraints.txt
as they are not actually used in tests (other than pep8).

more info: https://github.com/openstack/requirements/blob/master/blacklist.txt

Change-Id: Idb12608777b8f81747a3d93a06f332057a4871bf

These translation sections are not needed anymore, Babel can
generate translation files without them.

Change-Id: I5f061827e719cf865bc52e8cd70723597d0b618c

Related to:
- https://review.opendev.org/#/c/723044/
- https://governance.openstack.org/tc/goals/selected/ussuri/project-ptl-and-contrib-docs.html

Change-Id: I4f1501b2a7dc40fc8425b6d6443b429b064a0b4b

Python 3.8 is now our highest level supported python runtime.
This updates the default tox target environments to swap out
py37 for py38 to make sure local development testing is
covering this version.

This does not impact zuul jobs in any way, nor prevent local
tests against py37. It just changes the default if none is
explicitly provided.

Change-Id: If96ca50b1836f444a2a6842a589ae60f436b7eaf
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

Now that we are running the Victoria tests that include a
voting py38, we can now add the Python 3.8 metadata to the
package information to reflect that support.

Change-Id: I764f814c47425b7923c75552d998d0759d86896f
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

Change-Id: I10e7df90fa268fb79bed39583e5c43eb070ac873

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for victoria.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I44489979be0fe878d30af12a7b09221a000b0045

Add file to the reno documentation build to show release notes for
stable/ussuri.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/ussuri.

Change-Id: I96f32dc4b3c89a9dff098d75b427cd5666bb9654
Sem-Ver: feature

The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.

Fix problems found.

Remove hacking and friends from lower-constraints, they are not needed
for installation.

Change-Id: I9a2a7c6cd9a0dfd02c6193ceca5653431eed3753

Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.

Change-Id: Icac647c8e89cd94cae69e357b009d676b1c744f7
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

There are a couple of things that changed in msgpack 1.0.0 that were
breaking oslo.privsep:

1) The encoding parameter to Unpacker was removed. This has been
   deprecated for a while in favor of the `raw` parameter[0], so this
   change switches to using raw.

2) The strict_map_key parameter default was changed from False to
   True.[1] I haven't found an explanation of why this was done, but
   we can explicitly set it False to maintain the previous behavior.

Change-Id: Ia97ecf965d807f12524d5b6602446934b5813ce6
Closes-Bug: 1855914
Closes-Bug: 1864811
0: https://msgpack-python.readthedocs.io/en/latest/api.html#msgpack.Unpacker
1: https://github.com/msgpack/msgpack-python/pull/392/commits/6e1d12c0a2072572890cbb124b94cb08b582dd2d

This is all necessary to bump the lower-constraint on msgpack so we
can support msgpack 1.0 without version-specific logic in our code.

The reasons for the changes are as follows:

* greenlet and PyYAML bumped because the previous lower-constraints
  for those didn't install on python 3.7, which is a supported Python
  version.
* msgpack-python is removed. It was replaced by msgpack and there is
  no new enough release of it to satisfy the needed minimum version bump.
* oslo.serialization is bumped because the old version was pulling in
  msgpack-python, which overwrote our new needed version of msgpack.
* I went ahead and included the msgpack bump to 0.6.0 so we can move
  forward in the subsequent patch with supporting msgpack 1.0.0.

It could be argued that this should be included in the msgpack 1.0.0
change, but it ended up being complex enough that I thought it was
worth it to split it out.

Change-Id: I69dae65d3e0a40bb2304d74de078ab84fc778d58

The unit tests set format to "dummy", which gets rejected by Python 3.8
by default due to newly added validation here:

  https://github.com/python/cpython/commit/18fb1fb943b7dbd7f8a76017ee2a67ef13effb85

We can skip this and restore old behavior by disabling validation.

Change-Id: I22ba9c4437787c3f338f17a0b006132b0dd09df5

When a neutron agent starts up, it processes different resources
in separate eventlet threads. These can race creating the channel
which results in redundant privsep-helper processes. This patch
fixes that by adding a lock around channel creation.

Change-Id: I5de22b72059133b05d64be47f4c1d3f566b46a6e
Closes-Bug: #1864664