1. 17 Jan, 2022 2 commits
    • Bence Romsics's avatar
      Make debug option of wsgi server configurable · 615cfad7
      Bence Romsics authored
      Because in some deployments tracebacks in API responses are unwanted
      for security reasons.
      
      Change-Id: I8a2acea7393c369bfa7d7822f21b4d40d56d6739
      Partial-Bug: #1951429
      (cherry picked from commit 6552b9a8)
      (cherry picked from commit 13ee22cc)
      (cherry picked from commit c1e3398b)
      615cfad7
    • Bence Romsics's avatar
      Unbreak lower constraints · ee19ff37
      Bence Romsics authored
      Before this lc job on stable/victoria fails with:
      
      ERROR: Cannot install bandit<1.7.0 and >=1.6.0 because these package
      versions have conflicting dependencies.
      
      The conflict is caused by:
          The user requested bandit<1.7.0 and >=1.6.0
          The user requested (constraint) bandit==1.1.0
      
      Change-Id: I2c434eb78b879f796cffb37c52e83e78ca775629
      ee19ff37
  2. 11 Sep, 2020 2 commits
    • OpenStack Release Bot's avatar
      Update TOX_CONSTRAINTS_FILE for stable/victoria · 4017909a
      OpenStack Release Bot authored
      Update the URL to the upper-constraints file to point to the redirect
      rule on releases.openstack.org so that anyone working on this branch
      will switch to the correct upper-constraints list automatically when
      the requirements repository branches.
      
      Until the requirements repository has as stable/victoria branch, tests will
      continue to use the upper-constraints list on master.
      
      Change-Id: Ide063547374dd4b9bd4662165c72cf7121182b8a
      4017909a
    • OpenStack Release Bot's avatar
      Update .gitreview for stable/victoria · bb2a3417
      OpenStack Release Bot authored
      Change-Id: Iaf49effc1cd4c29d032d27e72c818cdcfb788132
      bb2a3417
  3. 06 Aug, 2020 2 commits
  4. 04 Aug, 2020 1 commit
  5. 24 Jul, 2020 1 commit
  6. 20 Jul, 2020 1 commit
    • Rodolfo Alonso Hernandez's avatar
      Do not import "oslo.log" in the main module · 91d4eee9
      Rodolfo Alonso Hernandez authored
      The LOG instance is not being used and there is no need to import
      "oslo_log". This will also prevent the circular import detected
      in the related bug.
      
      Change-Id: Id560ba80472b9efbcfbc289a18d4df312961fdb1
      Related-Bug: #1888213
      91d4eee9
  7. 23 Jun, 2020 2 commits
  8. 22 Jun, 2020 1 commit
  9. 17 Jun, 2020 2 commits
    • Zuul's avatar
      6df6e4cd
    • Hervé Beraud's avatar
      Fix wsgi SSL tests for wsgi module under python 3 · caf66be7
      Hervé Beraud authored
      Previously some tests were ignored under python 3 environment, this was
      due to some design changes introduced by python 3.7 [1] in the SSL
      module of the stdlib. These changes reactivate some of them (some other
      are still skipped and needs further works).
      
      Indeed, when we try to use requests with SSL in a monkey patched
      environment we faced the following issue:
      
      ```
      TypeError: wrap_socket() got an unexpected keyword argument '_context'
      ```
      
      This is due to the fact that we are in a monkey patched environment
      where `requests` is monkey patched too.
      
      We don't need `request` for our needs. Indeed we can easily send
      http requests through low level socket. Our main goal is to test
      our wsgi server and not to test the `requests` library, and `requests`
      was just used to make the code more simpler.
      
      In our case we can implement a code dedicated to send request to our green
      server, unlock our tests and move away from this bug/side effect.
      
      Also this reactivated test will check WSGI server with and without SSL,
      so these changes add changes that allow us to submit a request without
      wrapping the socket with SSL.
      
      These changes move away from `requests` which is badly monkey patched by
      eventlet [1]. Now we use monkey patched socket and ssl to
      request the green server which is executed in background. Low level
      (monkey patched) modules could help us to skirt layers that are possibly
      badly monkey patched on higher level modules (urllib, requests, etc...).
      
      [1] https://github.com/eventlet/eventlet/issues/526#issuecomment-482694279
      [2] https://github.com/eventlet/eventlet/issues/526
      
      Change-Id: I3a018d507d102266c1e2fc9b6732a9c09fa2bb49
      Closes-Bug: #1482633
      caf66be7
  10. 16 Jun, 2020 5 commits
    • Zuul's avatar
      08216129
    • Zuul's avatar
      Merge "Raise minimum version of eventlet to 0.25.2" · 3e4fe58a
      Zuul authored
      3e4fe58a
    • Hervé Beraud's avatar
      Reactivate wsgi test related to socket option under python 3 · fb1ed408
      Hervé Beraud authored
      Previously these tests was ignored surely because the WSGI tests
      with SSL were broken due to some design changes introduced by python 3.7 [1]
      in the SSL module of the stdlib.
      
      However, unlike the other WSGI/SSL tests these changes don't use
      the `requests` module or high level modules which are broken by
      the monkey patching of the stdlib.
      
      I suppose previous developers simply turned off all of tests related to
      WSGI/SSL without much more details than "SSL tests with python 3 and eventlet
      is broken" but some of them don't need much more work than just reactivate
      them to be ran successfully.
      
      This test seems to work without change, and it run successfully locally.
      
      Let reactivate this test.
      
      Change-Id: Ie0257af10a9439de8ec124a698ca75778bdf90b5
      Partial-Bug: #1482633
      fb1ed408
    • Hervé Beraud's avatar
      Fix wsgi/SSL/ipv6 tests for wsgi module under python 3 · ebc2d8a4
      Hervé Beraud authored
      Previously some tests were ignored under python 3 environment, this was
      due to some design changes introduced by python 3.7 [1] in the SSL
      module of the stdlib. These changes reactivate some of them (some other
      are still skipped and needs further works).
      
      Indeed, when we try to use requests with SSL in a monkey patched
      environment we faced the following issue:
      
      ```
      TypeError: wrap_socket() got an unexpected keyword argument '_context'
      ```
      
      This is due to the fact that we are in a monkey patched environment
      where `requests` is monkey patched too.
      
      We don't need `request` for our needs. Indeed we can easily send
      http requests through low level socket. Our main goal is to test
      our wsgi server and not to test the `requests` library, and `requests`
      was just used to make the code more simpler.
      
      In our case we can implement a code dedicated to send request to our green
      server, unlock our tests and move away from this bug/side effect.
      
      These changes move away from `requests` which is badly monkey patched by
      eventlet [1]. Now we use monkey patched socket and ssl to
      request the green server which is executed in background. Low level
      (monkey patched) modules could help us to skirt layers that are possibly
      badly monkey patched on higher level modules (urllib, requests, etc...).
      
      [1] https://github.com/eventlet/eventlet/issues/526#issuecomment-482694279
      [2] https://github.com/eventlet/eventlet/issues/526
      
      Change-Id: Iacdde51d2d923bafa3263fa3dc12de8d501d471a
      Partial-Bug: #1482633
      ebc2d8a4
    • Hervé Beraud's avatar
      Fix some SSL tests for wsgi module under python 3 · bfc81729
      Hervé Beraud authored
      Previously some tests were ignored under python 3 environment, this was
      due to some design changes introduced by python 3.7 [1] in the SSL
      module of the stdlib. These changes reactivate some of them (some other
      are still skipped and needs further works).
      
      Indeed, when we try to use requests with SSL in a monkey patched
      environment we faced the following issue:
      
      ```
      TypeError: wrap_socket() got an unexpected keyword argument '_context'
      ```
      
      This is due to the fact that we are in a monkey patched environment
      where `requests` is monkey patched too.
      
      We don't need `request` for our needs. Indeed we can easily send
      http requests through low level socket. Our main goal is to test
      our wsgi server and not to test the `requests` library, and `requests`
      was just used to make the code more simpler.
      
      In our case we can implement a code dedicated to send request to our green
      server, unlock our tests and move away from this bug/side effect.
      
      These changes move away from `requests` which is badly monkey patched by
      eventlet [1]. Now we use monkey patched socket and ssl to
      request the green server which is executed in background. Low level
      (monkey patched) modules could help us to skirt layers that are possibly
      badly monkey patched on higher level modules (urllib, requests, etc...).
      
      [1] https://github.com/eventlet/eventlet/issues/526#issuecomment-482694279
      [2] https://github.com/eventlet/eventlet/issues/526
      
      Change-Id: Id44ad12a1cf3fd7090a67bb6e8e42bfdc47502cf
      Partial-Bug: #1482633
      bfc81729
  11. 15 Jun, 2020 1 commit
  12. 04 Jun, 2020 1 commit
  13. 02 Jun, 2020 1 commit
  14. 26 May, 2020 5 commits
  15. 22 May, 2020 2 commits
  16. 18 May, 2020 1 commit
    • Andreas Jaeger's avatar
      Switch to newer openstackdocstheme and reno versions · 3803ff29
      Andreas Jaeger authored
      Switch to openstackdocstheme 2.2.0 and reno 3.1.0 versions. Using
      these versions will allow especially:
      * Linking from HTML to PDF document
      * Allow parallel building of documents
      * Fix some rendering
      
      Update Sphinx version as well.
      
      Remove docs requirements from lower-constraints, they are not needed
      during install or test but only for docs building.
      
      openstackdocstheme renames some variables, so follow the renames
      before the next release removes them. A couple of variables are also
      not needed anymore, remove them.
      
      Set openstackdocs_auto_name to use 'project' as name.
      
      Depends-On: https://review.opendev.org/728938
      Change-Id: I4f21de08de3bfd89bf8e331b6c819932cde8ca2f
      3803ff29
  17. 15 May, 2020 2 commits
  18. 11 May, 2020 1 commit
    • Hervé Beraud's avatar
      Align tests with monkey patch original current_thread _active · b9f82240
      Hervé Beraud authored
      Recent changes [1] introduced an eventlet fix to monkey patch original
      current_thread _active.
      
      The goal was to monkey patch the original current_thread to use the
      up-to-date _active global variable. This solution is based on that
      documented at: eventlet/eventlet#592
      
      I think we need this patch on unit test too to ensure a consistent
      behavior, so these changes doing that.
      
      [1] https://review.opendev.org/#/c/725359/
      
      Change-Id: I7b6cca86e44261bf2f953be74e9738ac09507649
      b9f82240
  19. 07 May, 2020 1 commit
  20. 05 May, 2020 2 commits
  21. 04 May, 2020 1 commit
  22. 27 Apr, 2020 1 commit
  23. 24 Apr, 2020 2 commits
    • Sean McGinnis's avatar
      Bump default tox env from py37 to py38 · bdb2de86
      Sean McGinnis authored
      
      
      Python 3.8 is now our highest level supported python runtime.
      This updates the default tox target environments to swap out
      py37 for py38 to make sure local development testing is
      covering this version.
      
      This does not impact zuul jobs in any way, nor prevent local
      tests against py37. It just changes the default if none is
      explicitly provided.
      
      Change-Id: I416cb6db21410a2a341d3372357ffbf4fe2de96f
      Signed-off-by: default avatarSean McGinnis <sean.mcginnis@gmail.com>
      bdb2de86
    • Sean McGinnis's avatar
      Add py38 package metadata · 50306b50
      Sean McGinnis authored
      
      
      Now that we are running the Victoria tests that include a
      voting py38, we can now add the Python 3.8 metadata to the
      package information to reflect that support.
      
      Change-Id: I2fd048c0d9bf7d93d6c7c515056abe7287019974
      Signed-off-by: default avatarSean McGinnis <sean.mcginnis@gmail.com>
      50306b50