The goal here is to avoid conflicts between flake8 and hacking version each
2 days.

Inspired from nova's approach[1].

The flake8 version to install will be determined by hacking and
requirements[2] will stay aligned instead of relying on different versions.

[1] https://opendev.org/openstack/nova/src/branch/master/.pre-commit-config.yaml#L26-L35
[2] https://opendev.org/openstack/hacking/src/branch/master/requirements.txt#L1

Change-Id: I996bcc6952a80aaccf50bb8ade579ebd960f4292

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for xena.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: Ic8d89a2ba2d92bd892c892d269e20e1b143306d6

Add file to the reno documentation build to show release notes for
stable/wallaby.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/wallaby.

Sem-Ver: feature
Change-Id: Id0e5435b082b3079e98081adf59e7177675205ea

These were missed in change I3eafc92ba7c7305b1a73d3f96c427ed12c96dbf7.

Change-Id: Idf7148bcf588efbd20352bf2160ecee573156444
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

This is now maintained as a Jazzband project [1].

[1] https://github.com/jazzband/prettytable



Change-Id: Id484bf8fe017bf8f6784155462640840b2053677
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

There are only two uses of this. Oddly, we never specified this
dependency directly and were instead relying on it being included
indirectly.

Change-Id: I3229750f3c47689c6b8d9db80a962a755b5a5da9
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

We facing errors related to the new pip resolver, this
topic was discussed on the ML and QA team proposed to
to test lower-constraints [1].

I propose to drop this test because the complexity and recurring pain needed
to maintain that now exceeds the benefits provided by this mechanismes.

[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html

Change-Id: I3eafc92ba7c7305b1a73d3f96c427ed12c96dbf7

check_policy_json() common check need [oslo_policy].policy_file
config value and it is better to register those options explicitly
in check_policy_json() in case they are not register by services.

Currently it work as oslo.policy opts are registered via some import
in service side code path for upgradechecks which are not so safe
when these code import path change.

Change-Id: I16fcce119698c7375e4b58558fdce89e78a79a9b

oslotest 1.5.1 is restricted to pbr <1.0 which conflict
with other deps lower constarint for pbr.

Error:
The conflict is caused by:
    oslo-i18n 3.15.3 depends on pbr!=2.1.0 and >=2.0.0
    oslo-serialization 2.21.1 depends on pbr!=2.1.0 and >=2.0.0
    oslo-utils 4.5.0 depends on pbr!=2.1.0 and >=2.0.0
    oslotest 1.5.1 depends on pbr!=0.7, <1.0 and >=0.6

https: //zuul.opendev.org/t/openstack/build/cb2bce3b4e004601958b764dfd0737b8
Change-Id: I513262b85a57ce9f81a63bd778fdd7f7be27e485

As part of community goal[1] for migrating the policy file
from JSON format to YAML we need to add upgrade check to
detect any JSON formatted file. That check needs to be
done in each service side which are deprecating the JSON
format. So to avoid duplicate code, this commit add that
check in oslo_upgradechecks and that can be enabled from
service side during they migrate to YAML format.

Service will enable it like below:

    _upgrade_checks = (
        (_('Policy File JSON to YAML Migration'),
            (common_checks.check_policy_json, {'conf': CONF})),
    )

Also modify the check() method to accept the **kwargs for checks.

[1] https://governance.openstack.org/tc/goals/selected/wallaby/migrate-policy-format-from-json-to-yaml.html

Change-Id: Ifa71c20879c964f794a40b981744d95db4ab1602

UPPER_CONSTRAINTS_FILE is old name and deprecated
This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.

[1] https://review.opendev.org/#/c/722814/
[2] https://zuul-ci.org/docs/zuul-jobs/python-roles.html#rolevar-tox.tox_constraints_file

Change-Id: I6d07e0ed66edc95f4afec6829b46fca679cd5814

Moving on py3 as the default runtime for tox to avoid to update this at
each new cycle.

Wallaby support officially the following runtimes [1]:
- Python 3.6
- Python 3.8

During Victoria Python 3.7 was used as the default runtime [2] however this
version isn't longer officially supported.

[1] https://governance.openstack.org/tc/reference/runtimes/wallaby.html#python-runtimes-for-wallaby
[2] https://governance.openstack.org/tc/reference/runtimes/victoria.html#python-runtimes-for-victoria

Change-Id: I3a98d1c258389968a892d6ccd067d3b8fb78a29a

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for wallaby.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: Ib5ee719e065a5be67a64982dafc7c4cb14ff8f3e

Add file to the reno documentation build to show release notes for
stable/victoria.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.

Change-Id: Icf5ce9d7fa96131cd2ae66f8a3b0c57af58eb453
Sem-Ver: feature

Introduced changes:
- pre-commit config and rules
- Add pre-commit to pep8 gate, Flake8 is covered in the pre-commit hooks.
- Applying fixes for pre-commit compliance in all code.

Also commit hash will be used instead of version tags in pre-commit to
prevend arbitrary code from running in developer's machines.

pre-commit will be used to:
- trailing whitespace;
- Replaces or checks mixed line ending (mixed-line-ending);
- Forbid files which have a UTF-8 byte-order marker (check-byte-order-marker);
- Checks that non-binary executables have a proper
  shebang (check-executables-have-shebangs);
- Check for files that contain merge conflict strings (check-merge-conflict);
- Check for debugger imports and py37+ breakpoint()
  calls in python source (debug-statements);
- Attempts to load all yaml files to verify syntax (check-yaml);
- Run flake8 checks (flake8) (local)

For further details about tests please refer to:
https://github.com/pre-commit/pre-commit-hooks

Change-Id: I8d5290d62b12a78...

Switch to openstackdocstheme 2.2.0 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems

Update Sphinx version as well.

Remove docs requirements from lower-constraints, they are not needed
during install or test but only for docs building.

openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.

Depends-On: https://review.opendev.org/728938
Change-Id: Iec4e4b3ed18e36d8ee1942e45e290ce292e7f881

Related to:
- https://review.opendev.org/#/c/723044/
- https://governance.openstack.org/tc/goals/selected/ussuri/project-ptl-and-contrib-docs.html

Change-Id: I9802b21406359bb2e2a5c48bd6dd6f2d31cb4460

Python 3.8 is now our highest level supported python runtime.
This updates the default tox target environments to swap out
py37 for py38 to make sure local development testing is
covering this version.

This does not impact zuul jobs in any way, nor prevent local
tests against py37. It just changes the default if none is
explicitly provided.

Change-Id: I9513860cc02287ab987d22f3403bb19bd07c28a9
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

Now that we are running the Victoria tests that include a
voting py38, we can now add the Python 3.8 metadata to the
package information to reflect that support.

Change-Id: I2347b02a274ea901705010dbf4139fc6db2557bb
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

It's not a runtime dependency (and even oslo.i18n is dropping it).

Change-Id: I678338bda728c683a6cf37df2abb706c48a980e2

Change-Id: I0fb6aed29d034141db13ec11913b4f5f1f68d6d5

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for victoria.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: Ibd9b183f80dcde07cbe1714c6487303f0a2cf684

Add file to the reno documentation build to show release notes for
stable/ussuri.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/ussuri.

Change-Id: Ia423d51c7c8ba1da79bb4569f17f3523819be618
Sem-Ver: feature

The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.

Ignore W504 line break after binary operator

Change-Id: Ice5627d714bad308bcf2e467a553d2d2297ea337

Now that we don't need to support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.

Change-Id: I67b86898cb443dc02c6b41a78bfe54f43f8d6c74
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

Change-Id: I0de4e6a064fb8008f9cff61b96875909041dd14b

OpenStack is dropping the py2.7 support in Ussuri cycle.

Complete discussion & schedule can be found in
-
http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010142.html
- https://etherpad.openstack.org/p/drop-python2-support

Ussuri Communtiy-wide goal:
https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html

Change-Id: I99e49c84779439317a9f13307c7e7d2fc092d7fb
Sem-Ver: api-break