The tox_install.sh scripts are there to enable dealing with constraints
support. All of that can be accomplished directly, it turns out, by
simply adding the -c line to the requirements list.

Remove tox_install.sh and just set constraints directly.

Conflicts:
	tox.ini

NOTE(stephenfin): Conflicts are due to some additional changes
introduced to tox in stable/queens before this patch. This patch is
required because 'tox_install.sh' uses curl w/o -L switch so it fails to
account for redirects that are now in place for backward compat with
git.openstack.org.

Change-Id: I888ee148995c080f793f90e168613348283d0ff0
(cherry picked from commit d8cb8ca0)

This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.

This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.

Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.

Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: I05cf41a0d54330e45397081324acafa18e1b5b24
Story: #2002586
Task: #24320

In version 0.7.3, cmd2 moved the parsed method from class Cmd()
to class ParserManager().

Change-Id: Ie0c057ffaeaa05c4f5e0f3599aab850245c55066
Closes-Bug: #1751822

cmd2 released a python3 only versions of itself.  We need to update
requirements to handle it.  This updates requirements to match
requirements.  See https://review.openstack.org/570811

 for more details.

Depends-On: I568e649ec5fdd0bf875d7ac3ff630e9b6bae6426
Change-Id: I3d527ba30205c9f3b3b2e89f795ee5611422c013
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
(cherry picked from commit 5e4b3bed)

The Py2 version of the csv module cannot accept unicode text. In Py2
we replaced the csv module with the unicodecsv module which encodes
unicode text prior to calling the standard Py2 csv module. Thus when
the cvs formatted output is emitted on stdout it is presented as a
encoded byte stream. But stdout has been replaced with a StreamWriter
which encodes to the desired encoding. The problem is the StreamWriter
attempts to encode all objects passed to it's write function,
including str objects. Instead it should only encode unicode text objects
and allow bytes to pass through unmodified.

This patch adds an override of the codecs.getwriter function which
only encodes unicode text objects. In addtion we pass the encoding
value obtained from the stream to the unicodecsv writer.

The patch fixes the codec error when outputing csv formated text that
contains a non-ASCII character. The unicodecsv implmentation will emit
byte encoded str objects to the stream. When the core StreamWriter
attempts to encode a str object Python will first promote the str
object to a unicode object. The promotion of str to unicode requires
the str bytes to be decoded. However the encoding associated with the
str object is not known therefore Python applies the default-encoding
which is ASCII. In the case where the str object contains utf-8
encoded non-ASCII characters a decoding error is raised. By not
attempting to encode a byte stream we avoid this error.

A more complete discussion of the above issues can be found here:

https://github.com/fedora-infra/kitchen/blob/develop/kitchen2/docs/unicode-frustrations.rst#frustration-4-now-it-doesnt-take-byte-strings



Change-Id: I22b5ad8bf0e227ec75a2a36986f0487191f7cbc2
Closes-Bug: 1720115
Signed-off-by: John Dennis <jdennis@redhat.com>
(cherry picked from commit c61cc300)

Zuul openstack-tox-pep8 failed due to several errors [1]
- Use bare except.
- Use ambiguous variable name 'l'. As pycodestyle doc [2] mentioned,
'Never use the characters 'l', 'O', or 'I' as variable names.'.

[1] http://logs.openstack.org/96/477396/3/gate/openstack-tox-pep8/f851c2d/ara/result/57b145af-a103-4982-9e9c-7c93c21b32df/
[2] https://pep8.readthedocs.io/en/latest/_modules/pycodestyle.html

Change-Id: Iefdf10245a64e58fa6b5d8174a09fb90f18c81a8
(cherry picked from commit cc7179c9)

Change-Id: Idd79be5cd0e18304bbde29d5be9b887e76575ff9

Change-Id: Ib1553625332d9e38ca790d5eb7645abdc56cf0a2

Change-Id: I95bdd69e0d6a40c3efbf8635d49b4ea72d39fc9f

Change-Id: Icf17fbcedf3ea9481abef0fd9ebb435648693be3
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Command base class has provisions to run hooks for a command in
its run() method. We need to do the same for the
DisplayCommandBase class since it does not call super().run()

Change-Id: Ic5481523d4bd919fe7fb10e00330dea2ff688ec4

Change the table formatter to not fit the terminal width by default. Add
a new --fit-width option to turn on that behavior. Width fitting is
implied if the --max-width argument is used. The old behavior can be
restored by setting CLIFF_FIT_WIDTH=1 in the shell environment.

Change-Id: I7b41b38ed25def416605d38c962aea55de842529
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

In some cases, a single documentation build wants to handle multiple
cliff-based CLI. One possible example is openstack-manuals CLI ref.
In this case, the global setting 'autoprogram_cliff_application'
does not work. It is nice if we can specify an application name
per autoprogram-cliff directive.
This commit introduces a new option 'application' to
autoprogram-cliff directive to allow this.

Change-Id: Ie2d01920dc04f2a92031a641d809f7da8af8b395

Set some of the new config values and enable openstackdocstheme as an
extension so it will inject values into the page context as it writes
each documentation page. This ensures the pages link to the right bug
tracker, etc.

Change-Id: I0bc0f1c42e1e54af0dc29d7dfcb23293a3347723
Depends-On: Icf3a40ed104cfd828f532f6f2b112ed02f996ff5
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Change-Id: Ife54259642bd71b899d34fa8d18ccc90e6f35bc2
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Change-Id: Ib783800018444df7204f5971c96c7bd83079bd41

Set up the formatter to always use a width=80 so that the terminal width
of the developer's system does not cause the test to fail. Trying to
mock os.environ failed, but there is an arg to HelpFormatter to set the
width explicitly. Unfortunately, there is no way to do that through the
parser, so we have to replace the parser's formatter_class attribute
with a partial() that passes width to the original class.

Change-Id: I2ab035b5b188f1a028e1776ba9f09c71dc316c11
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

distribute is dead, long live setuptools

Change-Id: Iedf1fafeb1178aa9e7b74d67f87c10166026820d
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Add hooks that are called before and after the take_action() method of
the command.

Change-Id: Id6527dfe0946c0ab169fc165b84d40f3ff95e08c
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Change-Id: If3fe077522c156472a0213e8768470e0505c189d
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Update Commands to load a separate set of extensions to be used as
"hooks," triggered at different points in the processing of the
command. Start with a hook that is given access to the argument parser
for the command so it can modify it.

Change-Id: I0785548fd36a61cda616921a4a21be3f67701300
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Change-Id: Idf7bcc957a961e76ecb48537b379177996a4f476

When the help command instantiates another command class to get its help
text, it needs to pass the command's name if the class supports it.

Change-Id: I3507f723dc8b4e68db80d6da053be61026823457
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

cmd2 0.7.3 started to override Cmd.completenames with a function
taking additional parameters:

  Cmd2.completenames(self, text, line, begidx, endidx)

over the Cmd version:

  Cmd.completenames(self, text, *ignored)

With this change we adjust the override to the new signature.

Change-Id: I7b110502c20ec16c6032cce31021eee3f85255fc
Closes-Bug: #1700250

Change-Id: Ib923265aaab4c001e5313800002aae63b159ec0d
Depends-On: Ia750cb049c0f53a234ea70ce1f2bbbb7a2aa9454
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

The Sphinx 'option' directive only allows optional parameter arguments
to be surrounded by brackets - not positional arguments. As a result,
'cliff.sphinxext' will ignore 'action.metavar' for positional arguments
due to the proclivity of said metavars to include surrounding brackets.
However, 'action.metavar' is sometimes important like, for example, when
'action.metavar' is a singular form but 'action.dest' is a plural form.
This can prove very confusing to users.

Start using 'action.metavar' by stripping out these brackets when they
occur. This ensures we get a pretty good approximation of the intent
without breaking Sphinx.

Change-Id: I114fe551f2a249faa49b419e18a99228627a8e83