1. 15 Sep, 2021 1 commit
    • Douglas Mendizábal's avatar
      Fix Castellan Secret Store inconsistent encoding · b9daa100
      Douglas Mendizábal authored
      This patch fixes the Castellan secret store use of SecretDTO objects,
      which require that the "secret" member be base64 encoded. [1]
      
      Prior to this fix all secrets that were generated were stored in
      plaintext, but secrets coming in through the API were base64 encoded
      before being stored in the backend.
      
      On secret retreival the Castellan plugin wrongly assumed everything in
      the backend was encoded, so attempts to retrieve generated keys failed.
      
      This patch fixes this inconsistency by always storing data un-encoded in
      the backend.
      
      A helper method was added to sort out the inconsistent data stored prior
      to this fix.
      
      A "version" property was added to the Castellan plugin metadata that is
      stored in barbican to help differentiate secrets stored prior to this
      fix vs secrets stored after this fix.
      
      Story: 2008335
      Task: 41236
      
      [1]
      https://opendev.org/openstack/barbican/src/tag/12.0.0/barbican/plugin/interface/secret_store.py#L356
      
      Change-Id: I46fe77a471bf7927a24ca4d64dfccb385cd6402e
      b9daa100
  2. 03 Sep, 2021 1 commit
    • Douglas Mendizábal's avatar
      Return 403 instead of 500 when policy check fails · 200bff89
      Douglas Mendizábal authored
      This patch fixes an issue where a 500 response is sent instead of a 403
      when a request is made using the wrong scope.  e.g.  Using project
      scope instead of system scope.
      
      Story: 2009170
      Task: 43200
      
      Change-Id: Id399d2220118efe1033426c658d1834cbff02f94
      200bff89
  3. 06 Jul, 2021 1 commit
    • Takashi Kajinami's avatar
      Replace oslo_utils.fnmatch with fnmatch · aa7bf886
      Takashi Kajinami authored
      The oslo_utils.fnmatch module was added to solve an issue in py2.7 but
      it is no longer required because py2.7 is no longer supported.
      The module was deprecated since oslo.utils 4.9.1[1] and the stdlib's
      fnmatch module should be used instead.
      
      [1] 4c893c92f551c9dd2a7cfbe7ae8171ad8139df0b
      
      Change-Id: If6ea16bbad5a7454e3a0f190c5a5e8da17f01a89
      aa7bf886
  4. 18 Jun, 2021 1 commit
  5. 15 Jun, 2021 1 commit
    • Douglas Mendizábal's avatar
      Fix alembic migrations · 3a76ced8
      Douglas Mendizábal authored
      A change was introduced to SQL Alchemy 1.4.8 that breaks our Alembic
      migrations.  Specifically it breaks the "add_secret_consumers" migration
      because it attempts to check for a table using an object that is no
      longer allowed to call that function.
      
      This patch removes the bespoke validation, because alembic should take
      care of checking the schema.
      
      Story: 2008967
      Task:  42606
      
      Change-Id: I36fb10445413fb1ec4046ab6c2525eae47d85ea1
      3a76ced8
  6. 14 Jun, 2021 1 commit
    • Gorka Eguileor's avatar
      Fix unit tests and migration to unblock gate · 1ae4badb
      Gorka Eguileor authored
      Currently there are 2 failing unit tests:
      
      - test_soft_deleting_expired_secrets: Caused by passing a column instead
        of a table on the query creation.
      
      - test_should_raise_for_pycrypto_stored_key_no_private_key: Caused by
        the conjunction of Barbican using scoped sessions and SQLAlchemy's
        identity mapping.
      
      And a migration issue on add_secret_consumers.
      
      This patch fixes all those issues to unblock the gate.
      
      Story: 2008967
      
      Change-Id: I6dc7d2671f2ba9d97af42d3155ae2bf3a8e33453
      1ae4badb
  7. 10 Jun, 2021 1 commit
    • Ade Lee's avatar
      Add FIPS gate job · 94a45c1e
      Ade Lee authored
      Add a new FIPS enabled gate job  This job will be
      for Centos 8 with FIPS enabled, and will use a playbook in
      zuul-jobs to enable FIPS.
      
      The dogtag bindep dependencies are curently broken.  Lets
      temporarily remove them here until we can figure out how to
      fix them and thereby fix the dogtag gate.
      
      Change-Id: Ibcd8cb6fc356e27266ba04cd972834dcd97c1a9b
      Depends-On: https://review.opendev.org/c/zuul/zuul-jobs/+/788778
      94a45c1e
  8. 08 Jun, 2021 1 commit
  9. 11 May, 2021 1 commit
  10. 29 Apr, 2021 1 commit
  11. 27 Apr, 2021 2 commits
  12. 26 Apr, 2021 1 commit
    • Yandong Xuan's avatar
      setup.cfg: Replace dashes with underscores · 6662fc9e
      Yandong Xuan authored
      Resolves warnings like the following:
      
        UserWarning: Usage of dash-separated 'description-file' will not be
        supported in future versions. Please use the underscore name
        'description_file' instead
      
      Change-Id: I5f4746bc4d40b76c562c39c2254f3b8381b4b52f
      6662fc9e
  13. 16 Apr, 2021 1 commit
    • Mark Goddard's avatar
      Fix Vault functional test · 21661beb
      Mark Goddard authored
      It was previously using the wrong Devstack service name.
      
      Change-Id: I52838cfe63d5a0b81757c278b9bfad516a442274
      21661beb
  14. 13 Apr, 2021 2 commits
  15. 01 Apr, 2021 1 commit
    • Douglas Mendizábal's avatar
      Add secure-rbac gate · ced3e5c0
      Douglas Mendizábal authored
      Add the secure-rbac tempest tests as a new gate to barbican.  This
      will help ensure that new patches don't break the default
      secure-rbac policy.
      
      Change-Id: I91d50aa08574a2f8aeaaa2bf431266ee74c79ae3
      ced3e5c0
  16. 31 Mar, 2021 1 commit
  17. 30 Mar, 2021 1 commit
  18. 29 Mar, 2021 1 commit
  19. 26 Mar, 2021 3 commits
  20. 24 Mar, 2021 1 commit
  21. 19 Mar, 2021 1 commit
  22. 16 Mar, 2021 1 commit
  23. 11 Mar, 2021 8 commits
  24. 10 Mar, 2021 1 commit
    • Douglas Mendizábal's avatar
      Implement secure RBAC for ACLs API · 3be848d0
      Douglas Mendizábal authored
      This patch adds the new RBAC rules for secure RBAC to the ACL API.  The
      existing RBAC rules are not changed and should continue to work as
      expected.
      
      Change-Id: I175a4aa7e41b6ac88d1509dd85e0cb96ea6ee411
      3be848d0
  25. 09 Mar, 2021 5 commits
    • Ade Lee's avatar
      Implement secure RBAC for transport key API · 9a16e911
      Ade Lee authored
      Add new system scope specific RBAC rules for the transport key API.
      The new rules tighten the policy to only allow system admins to
      add or delete transport keys.
      
      Change-Id: Icbe81724fb8b4f28fc4b5d24afe2618e759fcbad
      9a16e911
    • Ade Lee's avatar
      Implement secure RBAC for secretmeta API · f02d81be
      Ade Lee authored
      Add new project scope specific RBAC rules for the secretmeta API.  The old
      rules still apply, but eventually will be deprecated.  The new
      rules do include some changes to default policy, which are documented in
      the release note.
      
      Change-Id: Ib771a4615c1aa5a9beb1dc036b79c6ed982ba4de
      f02d81be
    • Ade Lee's avatar
      Implement secure RBAC for orders API · 265908ec
      Ade Lee authored
      Add new project scope specific RBAC rules for the orders API.  The old
      rules still apply, but eventually will be deprecated.  The new
      rules do include some changes to default policy, which are documented in
      the release note.
      
      Change-Id: I8e6963d7ab788038102c7f4570b3f2c9a342eabf
      265908ec
    • Ade Lee's avatar
      Implement secure RBAC for consumers API · e2c8e537
      Ade Lee authored
      Add new project scope specific RBAC rules for the consumers API.  The old
      rules still apply, but eventually will be deprecated.  The new
      rules do include some changes to default policy, which are documented in
      the release note.
      
      Change-Id: I89ed0113238446ee96e486af0540b6b24336a29c
      e2c8e537
    • Ade Lee's avatar
      Implement secure RBAC for containers API · 0faf2246
      Ade Lee authored
      Add new project scope specific RBAC rules for the containers API.  The old
      rules still apply, but eventually will be deprecated.  The new
      rules do include some changes to default policy, which are documented in
      the release note.
      
      Change-Id: I992e32832fee258ffb7b6397710f42759f28083d
      0faf2246