SQLAlchemy latest (1.4.27) installed with docs job breaks it.

Change-Id: Ida63e1d865dc0b2ac6a13594455962f53068c931
(cherry picked from commit 7f15b14d)

OpenDev infra only keep around the latest two Fedora releases in their
mirrors.  Probe for the image from the local test mirror, but if not
found, fallback to upstream.  This will be much less reliable, but can
avoid gate breakage until new images can be used.

Depends-On: https://review.opendev.org/c/openstack/heat/+/816603
Cherry-Picked-From: f7574531d3dc3bbbf55fd7c17d55a10b5320c5ff
Change-Id: I96ab14871ee8c5d5b83cc0cd4abc840ef0218ca8

This reverts commit 7ef31c2b and makes the grenade jobs voting.

Reason for revert: The `grenade-heat-multinode` is already defined in same yaml file.
We should remove grenade-heat instead, as we already have `grenade-heat-multinode`

Change-Id: I9da08239fb9499b26483ebba141d1a01d94c92c3

Change-Id: Ia65dabd7e357ad4ed8076fef3a3134c87100d4ed
(cherry picked from commit 42b5f68b)

Earlier when changing software config transport we used to
create a dummy deployment to push the metadata. However
this would not work with convergence as we take
resource lock for the update which updates the config
transport (another engine would try to update the resource
metadata for deployment when one engine has locked it).

Currently it works when updating transport as we ignore
the error in creating dummy deployment, but if there are
any new depoyments for the server they would fail.

We don't need to push the metadata as it would be pushed
when the there is a new/updated deployment.

Few additional changes in the patch:

- We don't need to ignore the error as servers are now
not replaced if the resource is in ERROR when nova server
is good/ACTIVE.
- Delete the existing tempurls and zaqar queues when
  changing transport.

Task: 41744
Change-Id: Id592b29df36320d8697bd370252ada02612ba7d0
(cherry picked from commit 79fb6509)

os-hosts was deprecated in nova quite some time ago.  This patch updates
get_hosts to use the available os-hypervisors functions.

Change-Id: I36421e9859a266f0278c1b5f2acb4ebbacbfca82
Story: 2006584
Task: 36708
bz: 1740567
(cherry picked from commit aab68ced)

Block Storage API v2 was deprecated during Pike cycle and is being
removed during Xena cycle, and current v3 API should be used instead.
Unused volume_client and network_client in integration test code are
also removed by this change.

Note:
granade tests is made non-voting temporally until the same issue is
fixed in stable/victoria.

Depends-on: https://review.opendev.org/802150/
Change-Id: I6a2b5afa13480791971bbd8bba1f43b9f2db8294
(cherry picked from commit 1828df32)

Move testing to Fedora 33

Now that the gate is unblocked, we can also test F33 for gating purposes
here.

Change-Id: Ie1c9075623d85b27aaf1ac67a3063e219726bc6f
(cherry picked from commit 6a9c35d8)

Otherwise, this script fails to run on Enterprise Linux 8 distros.

Change-Id: I0168b380d0e201d9c8f8121b384d25a2412c2129
Signed-off-by: Luke Short <ekultails@gmail.com>
(cherry picked from commit 2d692e22)

Also, we should not modify a list when iterating
over it.

Task: 42359
Closes-Bug: #1925373
Change-Id: Iaa2c05b4155d93f44de60b6f98a69450c1512817
(cherry picked from commit a8f8528d)

Change-Id: Ie7898f025d028f6d511b7bb21c5681b9dce7b8ec

If the interface has been detached before we call
detach_interface, then we keep on calling it as we
get a 404 from nova. Let's assume it's being called
and check if the interface has been detached.

Task: 42195

Change-Id: I768eeb10c2c24a0c93749b11636ef3e003ecfcd9
(cherry picked from commit 6ff0dc2e)

With I04e7ad90944c2d03ce0e59ba16af9d60d6e01222 we allowed
update of previously-existing resource if replacement
creation has failed during last update. However, we force
update the status of the existing resource to 'COMPLETE'.
Therefore, in the next update if properties/type has not
changed for the resource it won't try to update/replace
the previously existing resource resulting in false positive
of stack updated successfully.

Task: 42194
Change-Id: Icc90a921ec67e49aec2c4acfad72235c57c78421
(cherry picked from commit bfbaab10)

Useing get_attr, pulling index 0 in the segments list
of a network to associate the a subnet with the "first"
segment is useful since the "first" segment is created
by neutron behind the scenes on network create. A resource
reference cannot be used since the "first" segment is'nt
a heat resource.

The issue is the order of the segments list is'nt reliable.

On stack update index 0 may be a different segment, and
we end up trying to update the segment_id for a subnet.
Changeing the segment association is not allowed, so
the stack update fails.

While not perfect, sorting the list so that segments where
name is None comes first will ensure that index 0 can be used.

The template author should ensure segments defined in the heat
template all have a names set, so that only the segment creted
implicitly by neutron have 'None' name.

Closes-Bug: #1894920
Change-Id: I097aba2a97144327bec188e6c71629d0f6c95901
(cherry picked from commit 539b2a4c)

Trove client is using the 'retries' as 'connect_retries' when instantiating
trove Client.

Ref:
https://github.com/openstack/python-troveclient/blob/master/troveclient/client.py#L469

Story: 2008422
Task: 41366

Change-Id: I58a6e235410e2ca28b3822400151621c18ad882d
(cherry picked from commit defb617c)

- Remove B322 bandit from exclusions
- Fix tests for db resource update exposed by SQLAlchemy>=1.3.21

Change-Id: I18efbbbe211a42325a946f5ca74b4e26bfb3316e
(cherry picked from commit f4ab9d0b)

New pip version is quite strict and does not allow conflicting
minimum version deps in lower-constraints.

Change-Id: Ie524c54e3b982bc6b0786c875d34d177444ec6fc
(cherry picked from commit 4370af15)

Fedora 31 was retired and the image is gone from mirrors.
heat-cfntools have been dropped from fedora images, disable
the test till that's resolved.

Also makes grenade job non-voting, till this is backported
to stable/victoria.

Change-Id: Id869f83a46454897c2fe7a532eebfa2863befe5e
(cherry picked from commit 61e53c4e)

Kevin Carter authored Oct 22, 2020 and Michal Nasiadka committed Nov 17, 2020

This change adds SOURCE_IP_PORT to lb_algorithm property of
OS::Octavia::Pool resource which is missing from the available options
and required when using the OVN provider driver.

[0] https://docs.openstack.org/ovn-octavia-provider/latest/admin/driver.html#limitations-of-the-ovn-provider-driver
[1] https://docs.openstack.org/releasenotes/octavia/train.html



Story: 2008361
Task: 41268

Change-Id: Ibed37eea817a5125c5751b2bc9f44acf3c016fe1
Signed-off-by: Kevin Carter <kecarter@redhat.com>
(cherry picked from commit 20b599cd)

The default value of domain caused the user to be unable to create
role which no domain.
The patch delete the default value of domain.

Change-Id: Ic67b22c435e29f67bafa8e14ab502ebec5b07ec5
Story: 2002671
Task: 22488
(cherry picked from commit e5b00ddf)

This patch returns a stack validation error if the nova microversion
is 2.57 or greater and the personality parameter is also specified
in the templates.

Change-Id: I0919150baa36112ccbd8bfd7ccebc7aab5735cf3
Task: 41229
(cherry picked from commit b068f45a)

https://review.opendev.org/750941 changed the default
swap to 1024MB for jobs and this seems to resulting in
high failure rate of the functional and grenade jobs.

Let's configure it back to what used to before i.e 8192MB.

Change-Id: I627f2df7f6135b3d194e7146ae45c3b7f8b6394d
(cherry picked from commit f419923a)

Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/victoria branch, tests will
continue to use the upper-constraints list on master.

Change-Id: Ie987f60222c1690fe3b180385f8ee891adea0fb1

Change-Id: I69ef54b773e870f0ecc345278835c88b6ccd824d

Ceilometer uses gnocchi as the default backend. Also we use
gnocchi based aodh alarms in tests.

gnocchi seems unmaintained with last commit a year or so ago and
does not look like the openstack telemetry team is involved in
that project.

It's better to disable the services and tests in heat to avoid
broken gate like last time, where we fixed it by banning latest
pecan release[1] that does not work with python-gnocchiclient.

[1] https://review.opendev.org/#/c/746261/

Change-Id: Id2ffdf6b9d342e800bab4a94ec46742228361ee8

This patch changes the lower-constraint requirements to make them
py3.8 compatible. See https://bugs.launchpad.net/nova/+bug/1886298

Markupsafe==1.1.1
PyMySQL==0.8.0
PyYAML==3.13
cffi==1.14.0
greenlet==0.4.15
kombu==5.0.1
lxml==4.5.0
oslo.db==6.0.0
paramiko==2.7.1
psycopg2==2.8
sqlalchemy-migrate==0.13.0
tenacity==6.1.0

Also update the test-setup.sh to work with recent version of mysql.

Change-Id: Ibe60d1e536f0e887eceea32b7cb4eec6318e96af
Partial-Bug: #1886298

Parsing the value of JSON parameters at the time we create them (or
update the default value) results in exceptions occurring while creating
the Stack object, that are then not caught and transformed. The result
is an HTTP 500 Internal Error reported by the API, with an unhelpful
error message.

By not parsing the JSON until it is needed, we ensure that any errors
will occur during validation, where errors are appropriately transformed
(to StackValidationFailed) and annotated with the necessary information
to help the user determine the source.

Depends-On: https://review.opendev.org/#/c/748359/

Change-Id: I70e341c344d6254173ad4519276626230087263a
Story: 2007957
Task: 40443

This commit bumps MANILACLIENT_VERSION to 2.13 and changes the used
service type to sharev2.

In order to support the value of "cephx" in property
'{"access_rules": [{"access_type": ""}]}' in ressource
OS::Manila::Share, manilaclient needs to use at least version 2.13 of
the manila API ([1]). The default minimum version in manilaclient, which
is used when only a mayor version is specified is 2.0.
Additionally the sharev2 service type endpoint has to be used to access
the manila v2 API.

The export_locations response was removed in version 2.9 of manila API
from the "Show share details" request ([2]) and moved to its own
endpoint in [3]. Thus it is requested from there now.
Additionally the new endpoint is more verbose, so only its path
attribute is returned, in order to match the previous behaviour.

[1]
https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html
[2]
https://docs.openstack.org/api-ref/shared-file-system/?expanded=show-single-export-location-detail,show-share-details-detail#show-share-details
[3]
https://docs.openstack.org/api-ref/shared-file-system/?expanded=show-single-export-location-detail,list-export-locations-detail#list-export-locations

Change-Id: I4c37be8fad1edb05d812fed260e97e9188fd23ce
Story: 2007986
Task: 40612