Currently, "Resize instance" widget is not working because it relies on
legacy Nova API v2.46, obsoleted in Pike release. Proposed patch make
Horizon use current Nova API (>=2.47).

Note: It also cherry-picks a7956cd0

 from the master branch
which avoids the extra call of flavor_get in resize server form.

Closes-Bug: #1940834
Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: Id2f38acfc27cdf93cc4341422873e512aaff716a

Previously, ToggleSuspend class checked 'os-rescue' policy for resuming
an instance. To align to resume operation, this fix changes to
'os-suspend-server:resume'.

Closes-Bug: #1963652
Change-Id: If6386ecdb81fb1f0d88dab447ee81c251b9857b7
(cherry picked from commit 29da8015)

Resize instance dialog should use proper calls for quota and usage.
This patch fixes that.

Change-Id: Ied6fd4ad69b38a721b23700c98344e0edf14771b
(cherry picked from commit e2bb7d83)

Troubleshooting an issue with Senlin documentation,

> RecursionError: maximum recursion depth exceeded in __instancecheck__

it turns out that attrs['base_options'] creates a recursive reference
when no base classes have 'base_options'.
This happens when BaseAction is created.

Closes-Bug: #1955773
Change-Id: I2724f07339134b3e06b7ea925939bf7072162106
(cherry picked from commit b8cc0043)

Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/xena branch, tests will
continue to use the upper-constraints list on master.

Change-Id: I78fd0ec6b339ea6d2702bc304de7ba35947fedbd

Change-Id: If9d89b8abf6320177c029f650ccef3e81bc413ef

Django 3.2 stored the field information as dict instead OrderedDict
because python 3.7+ ensure the field order of dict as the language spec.
We cannot touch dict itself during iteration. We need to pass a list
instead of a value from .items() itself to avoid the error.

Change-Id: Ie22865995d14fa60c16cf2cea582aa0eec46b65d
Closes-Bug: #1944548

We consider Django 3.2 support as experimental in Xena,
but it is worth documenting it.

Change-Id: Ibdaed0f4eafd18c61289e70e41584e97d6c60dd7

This patch update decorator version to 4.4.2 in
lower-constraints.txt to fix the lower-constraints job.

Change-Id: Ie1fa066a5b3615b88e808a99228ed7efd0c98678

In Django 3.2 CookieStorage stores messages in the RFC 6265 compliant
format [1][2]. This means that horizon messages pass through cookies are
encoded in a different way that messages are encrypted.

Previously horizon UT interpretes messages in cookies literally in its own way,
but the change on CookieStorage in Django 3.2 broke it. Horizon should not
depend on its own way. The suggested way I believe is to use a method defined
in django.contrib.messages.storage.cookie.CookieStorage.

[1] https://docs.djangoproject.com/en/3.2/releases/3.2/#miscellaneous
[2] https://github.com/django/django/commit/2d6179c819010f6a9d00835d5893c4593c0b85a0

Change-Id: I3e5e12265d0bc7b753bbe1f57acdd663b9dd3587

This commit adds a non-voting unit test job with Django 3.2.

Jobs with Django 3.0 and 3.1 are dropped now.
They were introduced before Django 3.2 was released.
Django 3.0 reached EOL and Django 3.1 will reach EOL this December.
Django 3.2 is an LTS version so testing with Django 3.2 is enough.

Change-Id: Ic6ba0ea281b287b7f4762f92e2e81a6fd654da8f

django-pyscss is not compatible with Django 3.0.
django_pyscss_fix is a temporary workaround for django.utils.six
used in django-pyscss. It also add six in requirements.txt
as we use six module for this workaround.
This is just to run horizon for testing with Django 3.0+.

six is re-added to requirements.txt as it is used in the workaround.
Note that other codes in the horizon repo should not depend on six.

Change-Id: If79289b7518dd8eaf292a90d6fb790beb154cb7c

In Django 3.2, assertQuerysetEqual started to compare querystes directly.
As the migration check it checks the first element of the compared items
have a same type. "values()" method of OrderedDict does not return an object
which allows the index access in Python3, so this change breaks our UT.
We need to ensure to pass a list to assertQuerysetEqual.
The commit changes the related codes to ensure a list for such cases.

[1] https://github.com/django/django/pull/13557/commits/3f7b3275627385f8f7531fca01cdda50d4ec6b6e

Change-Id: If0a9d17c30de73a9870d0ebf3b3a82a14179c23d

Django 3.2 defines the new header API for the response object [1].
This change dropped "_headers" attribute from the response object.
Instead of accesing a private attribute, we need to use the public APIs
for response headers [2].

[1] https://docs.djangoproject.com/en/3.2/releases/3.2/#requests-and-responses
[2] https://docs.djangoproject.com/en/3.2/ref/request-response/#httpresponse-objects

Change-Id: Ia13212fd231215e17f4bba2039e79874b676e634

assertFormErrors() now compares actual and expected messages
after parsing them as HTML. Similar to the previous commit,
after Django 3.0 escaped characters are handled differently
(decimal representation, hexdecimal representation and
unescaped representation) so we need an uniform way to compare
texts. Instead of comparing texts literally, this commit changes
assertFormErrors to compare texts after parsing them as HTML.

Change-Id: I4ff89cdcb27a2671c7d79fb2caec30585696a30f

The result of the encoded (i.e., escaped) text in HTML changed
between Django pre-3.0 and 3.0+. For example, decimal and hex encoding
are semantically same but they are different in literal texts.
While I don't know what triggers this change, I think it makes sense
to compare these texts after decoding as HTML.
Considering this, html=True is passed to self.assertContains().

When passing html=True, a text in an HTML element is not compared
partially and a full text as a value of the HTML element is compared,
so we need to pass the full text of an HTML element value now.

I believe the above change is caused by the change that django.test.html.Parser
is initialized with convert_charrefs=False previously. On the other hand,
it is not specified now in Django 3.0+ [1]. This leads to the situation that
escapes on unicode characters are handled differently.

[1] https://github.com/django/django/commit/48235ba807483fe349d2dc66aaeddc0d03f8b0d4

Change-Id: I0f26436eb384a95f8446d8fd447c9577d50a5c21

It seems Django 3.0+ does not allow to set an unknown attribute
to forms.Form.fields. "keyOrder" attribute has no meaning and
"field_order" of the Form class is the right way to configure
the order of fields.

Change-Id: Ib3a631a3626977a2e7114dac217aacd523354c53

Manage members dialog has a dropdown which lists all the role names.
If a role name is long enough, it pushes all the roles to the left
and hides them partially. This patch adds horizontal scrollbar for
such cases.

Closes-Bug: #1926511

Change-Id: I1bbf3b23717f9924974920d6569e018b94e3dbe8

* Django 3.0 dropped django.utils.decorators.available_attrs()
  in favor of functools.WRAPPER_ASSIGNMENTS.
* Django 3.0 dropped django.utils.functional.curry()
  in favor of functools.partial() or functools.partialmethod().

https://docs.djangoproject.com/en/3.1/releases/3.0/#removed-private-python-2-compatibility-apis

Change-Id: I4ab0e720a8ffe13a08f5e607a59e39f252338b90

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ic3d270ae69b9c7f9fb17ca7073eb388e9c09537b

Change-Id: Ic61a3958461a4a939acc40d1039881e2d4c3a1cd
Closes-bug: #1894801

The tacker-horizon integration test framework has been implemented[1]
While adding integration test cases a selenium exception [2] was
observed for test cases under directory [3].

Tacker-horizon UI Details:

* Most of the Horizon plugins, such as manila-ui and vitrage-dashboard
  support integration tests, these plugins reside under "Project" tab.
* Whereas, tacker-horizon, mistral-dashboard are horizon plugins which
  have their dashboard anchored directly at the top-level alongside
  "Project" tab.
* The tacker-horizon has two-panel groups,
   * VNF Management
   * NFV Orchestration
* The "VNF Management" is a default panel and remains expanded in NFV
  dashboard, whereas "NFV Orchestration" is collapsed initially.

Selenium Exception Details:

* The horizon framework reports an exception
  ElementNotInteractableException, while opening pages under
  "NFV Orchestration" panel group.
* This error occurs when an element is not clicked or it is not visible
  yet.
* The menu item expansion code in the horizon integration framework
  expands only those menu items (level first, second or third) if only
  the previous menu item at the same level was expanded earlier.
* For example, in order to open a page[4] under NVF Orchestration panel
  group, the framework collapses "Project" tab and clicks "NFV"
  dashboard.
  But it never expands "NFV Orchestration" panel as in second-level no
  such transition occured hence it remains collapsed. So test case fails
  to find desired page.
  On the other hand, test cases for pages under "VNF Management" succeed
  as the panel group by default remains open.

This patch adds functionality to detect collapsed menu items and expand
the items.

[1] https://review.opendev.org/c/openstack/tacker-horizon/+/790958
[2] https://zuul.opendev.org/t/openstack/build/b8bd1618206945b68ebdbcdc7f1bdf10/console
[3] tacker_horizon/test/integration/pages/nfv/nfv_orchestration/
[4] tacker_horizon/test/integration/pages/nfv/nfv_orchestration/vimmanagementpage.py

Change-Id: I8fec54eb5f2a9bf218ee36e9c0a1ce9c15c97a26

At Launch Instance dialog, Source tab, for boot sources Image and
Instance Snapshot there's Format table column. However the title for
it is Type, which is confusing since there is a different property
Type for an image/instance snapshot.

Change-Id: I8f1d3338c58ae4e25bc8437c2a11fd053b2952c1

Admin-Compute-Instances dashboard shows "-" as image name for every
instance. Despite, Project-Compute-Instances dashboard displays image
name correctly. Admin dashboard just lacks code to resolve image name

Also, reverted commit deb55b84 which functionality is not needed anymore

Closes-Bug: #1932341
Change-Id: Ieb19e66dc51165d9935424b2e9ab5cdae757b07f

Enabled Network QoS panel and added a button for
creating a new network qos policy with parameters
name(string), description(maxlen-255), and
shared(checkbox)

Partially-Implements: https://blueprints.launchpad.net/horizon/+spec/create-network-qos-policy

Change-Id: Ifabfac7553ddbb65fe387187da5dd2fafad31351