As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.

Replaced methods:
	* setup_clients

Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup

[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0

Change-Id: Idcfa1d5495ed68484cdc869bcd27fa8413a479ba

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.

Replaced methods:
	* _create_network
	* _get_server_port_id_and_ip4

Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup

[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0

Change-Id: I424cf6f3547eeb229f888e4ad9f9cb09f635ec31

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.

Replaced methods:
	* _get_router
	* _create_router

Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup

[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0

Change-Id: I3dc123bea822a2c430a7fe4b714ca2bb9e5a5494

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.

Ironic tempest plugin still uses nova-network old interface for floating ip related methods, this patch removes them and use tempests's ones which already use neutron's interface.[2]

Replaced methods:
	* create_floating_ip
	* get_server_ip

Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup

[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
[2] https://opendev.org/openstack/tempest/commit/6428139de18291c916852ae48130fb8a7b4db318

Change-Id: I963fe7478c0f3a46c1daa44c4eeff69714cf3ba0

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.

Replaced methods:
	* create_timestamp

Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup

[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0

Change-Id: Ic4bc853edf7283cbf1c4d2b17431a051f5309a02

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.

Replaced methods:
	* get_remote_client
	* check_vm_connectivity

Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup

[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0

Change-Id: I41f2a17f924e4f555f176564d365aa7119e1fd5b

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.

There is no need to have create_server definition in ironic scenario manager

Replaced methods:
	* create_server

Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup

[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0

Change-Id: I781cbf90e283bd8a3be4ad3e6aa7c13f280444e0

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.

Replaced methods:
	* _log_console_output
	* ping_ip_address

Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup

[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0

Change-Id: I1533a2aae3139aa0e81f783049d7fce60931efbe

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.

Replaced methods:
	* create_server
	* rebuild_server

Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup

[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0

Change-Id: Ifbb3691d2588f09e56218780ef79045f074bab5e

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.

Replaced methods:
	* _create_port
	* create_keypair

Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup

[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0

Change-Id: I413f5314502da2bfde1846e5d4afeaee54422097

This fixes verification of introspected data.

For physical baremetal introspection scenario, specification of the
physical server may differ with existing flavor data, whereas for
virtualised baremetal server, it can be matched.

When the introspection is performed on physical baremetal server,
the introspected data does not match with flavor data causing failure
in verification of introspected data. Hence, current fix is verifying
introspected data if greater than 0.

[1] https://docs.openstack.org/ironic/latest/install/configure-nova-flavors.html

Change-Id: I9ff1364e1baf99579a3d7b8cb5fc2ab012030173

We seem to be using the Nova's defaults instead. Also verify that the
resulting image type in instance_info is correct.

Depends-On: https://review.opendev.org/c/openstack/ironic/+/827882
Change-Id: Iaba563a2ecbca029889bc6894b2a7f0754d27b88

Change-Id: Id6c16e3bb6157966fa59015db1a7da58bf0e479d

Remove ussuri jobs from gate.
Add xena jobs instead.

Change-Id: I4af815dc3f1922c07e0c0aa2fe000d49f92c9807

Change-Id: Iba4503a329f65641f7521f67aa11b3ac5fda8da1

Originally ironic was entirely pruely just an admin API,
but this has changed, and we need to add additional non-admin
tests, so it makes sense to re-use to the base and share it
amongst the tests.

Change-Id: I0fe3e326e4a25dc0928080fd1111ca4c46d8134a

Per review feedback on
https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/798143
it is believe the setting is no longer required for Wallaby branches.

Change-Id: I9face242ac4501a37a36534dd05eba66466fcccc

At this point, it is relatively safe to remove the
train jobs for ironic-tempest-plugin. The branches
are EOL, and we're unlikely to make any changes which
testing against Train, that can't be identified or
revealed in later community supported stable branches.

Change-Id: I069a9ec15d94871c7b610e130b13e9403110f728

The min version of tox is updated to 3.18.0 to replace whitelist_externals
with allowist_externals option [1]

[1] https://github.com/tox-dev/tox/blob/master/docs/changelog.rst#v3180-2020-07-23

Change-Id: I3715bdc7079d6a8754be514a2131a3dae06769c2

Change-Id: Id0d91c09f3d9f6cb5207b02ec7ebf3d2075f366d

The ironic tempest plugin was an early plugin and manually
invoked override plugin clients and then attached them in
the setup_clients method. However, the newer format is to
use get_service_clients, which creates and attach client
classes using the prepared credentials supplied by the
credentials attribute on the test classes.

In order to support even the most basic testing handling
and testing of Scope Enforcement as part of Secure RBAC,
then the we need to leverage the newer (last 3-4 years)
model of instantiating and leveraging clients in tempest.
This is because we need to be able to get a system scoped
admin token to be able to test actions as a system scoped
admin user. Not to be confused with "admin", which is
project scoped.

This newer style of client support does necessitate some
legacy style or direct client invocations to be retooled
so they do not attempt to directly invoke without the
required context.

Additionally, to support even the most basic handling of
the Secure RBAC's effort, we need to be able to know
when to leverage *and* then leverage that client.
We do that through the enforce_scope parameter
in upstream tempest.

Depends-On: https://review.opendev.org/c/openstack/tempest/+/798130
Change-Id: I5188fc756f1b524e9d1b32ef0474e29a9cf90b57

Setuptools v54.1.0 introduces a warning that the use of dash-separated
options in 'setup.cfg' will not be supported in a future version [1].
Get ahead of the issue by replacing the dashes with underscores. Without
this, we see 'UserWarning' messages like the following on new enough
versions of setuptools:

  UserWarning: Usage of dash-separated 'description-file' will not be
  supported in future versions. Please use the underscore name
  'description_file' instead

[1] https://github.com/pypa/setuptools/commit/a2e9ae4cb

Change-Id: I651339c8103cb46f7d4eb0107bb300a6da29dbb1

A long time ago, in a galaxy far far away, the use of
/extra/vif_port_id was deprecated in favor of vif attachment and
detachment. This change updates a test which was using the
/extra/vif_port_id field value to bind a vif, and then list/detach
it using the vif attach/detach/list API interfaces.

Since the action is to add/list/detach, this seems appropriate and
should be widely supported going back 4+ years.

Change-Id: I0b0cd0aaf9a87803386e096ab768638476f9ca52

Update minversion of tox to 3.9.0 to support inline comments [1]

Move pep8 and coverage requirements to tox.ini

Fix typo in coverage job

[1] https://tox.readthedocs.io/en/latest/changelog.html#v3-9-0-2019-04-17

Change-Id: I3f39b25ee0fd44c1bc51f94a7fbee74de8cba65d

Different implementations of ping behave slightly differently
in order to ensure the packet payload is transmitted across
the wire because some mediums have a minimum packet size.

Typically this results in a frame size of 64 bytes, but
the client may report 56 when the header is removed and only
the packet payload is examined.

But the point of the check is that we got something back.

The below edited for example purposes:

$ ping -c1 -w4 192.168.133.92
PING 192.168.65.92 (192.168.133.92) 56(84) bytes of data.
From 192.168.65.249 icmp_seq=1 Destination Host Unreachable

--- 192.168.65.92 ping statistics ---
1 packets transmitted, 0 received, 0 errors, 100% packet loss, time 3075ms
$ ping -c1 -w4 192.168.65.1
PING 192.168.65.1 (192.168.65.1) 56(84) bytes of data.
64 bytes from 192.168.65.1: icmp_seq=1 ttl=64 time=12.4 ms

And then in CI, we're able to see this be 56 bytes returned
becasue the underlying medium may not have been ethernet or
the client has stripped the header. Which, doesn't matter,
we get A reply from the expected address and we can validate
the test on that alone.

Change-Id: If0d51b52e96f280336d0d92135681db75a6fbd65

The ironic-standalone-redfish-victoria job is using latest tinyipa
based on tinycore 11.x, but still running on bionic.
That causes issues during the ipa-ramdisk build because of kernel
too old in bionic, so setting nodeset to focal.

Change-Id: Ia0fbc97184a4098635085edbdd6d7be5dfd2218c

We need to explicitly tear down the raid sets and not just
remove the hint because the code will try to use the raid
set if it is there.

Depends-On: https://review.opendev.org/#/c/759906
Change-Id: I4c6829833889e03588d5723dadb94338696c9122

Versions of hacking from 3.1.0 until 4.0.0 NOT included are supposed
to require a safe version of flake8, so besides normale issues related
to minor version upgrades, we can safely use those versions.
Also forcing pycodestyle versions to be compatible with flake8 installed
by hacking.

Change-Id: Idb66f2ae0105308747cdf3046b09a22bdf691ea3

This commit adds test case to support UEFI-HTTPS
boot using ilo5 driver with standalone ironic.

Change-Id: Ib54fa2e79800bb56ff14699e8ce4fbc460615670

Stop testing stein in wallaby and adjust other jobs to start
testing explicitely victoria branch.

Change-Id: I3c8be006e0ea136690abb70df7c5e4e561fdff20

There is a race sometimes when power off persists after the allocation
query, causing it to fail[1].

[1] https://zuul.opendev.org/t/openstack/build/aab3ecc1f63f4a52b1015f726fd8d229

Change-Id: I2b854a3a6b0f40f46dfa030b84d58715572f3ad4