Add get metadata item for share metadata testcase

Change-Id: Ib3b3148a99812c69476e51cf0609c08fc9c4a9ef

Supported stable branches in maintenance state
(ussuri, victoria, wallaby) use the Tempest and
plugin's master version for their testing.

To make sure master version (new tests or any changes)
are compatible with stable branch testing, we need to
add the stable branches job on the plugins master gate.
Tempest and many other plugins are already testing the
stable branches in same way [1].

Ussuri onwards, Tempest or plugins are py3 only, so we
are running only python3 version of stable jobs

Tempest plugins guide for stable branch testing:
- https://docs.openstack.org/tempest/latest/stable_branch_testing_policy.html

[1] https://opendev.org/openstack/tempest/src/commit/e8f1876aa6772077f85f380677b30251c2454505/.zuul.yaml#L646



Change-Id: Ib1067db3771bacb287517e370c83a13d8bea89b5
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Change of inheritance to "BaseSharesMixedTest" class since it
requires admin privileges.
This change will allow removal of duplicate code.

Beyond that, "create_share_type" method is under "BaseSharesTest",
which is incorrect since it requires admin privileges.

Change-Id: Idd2c2285e266f0b733301ccfae5c423340de2511

This patch validates that share has been deleted after
deletion of share instance.

Change-Id: I14db6e04d9635229e4554582268ba8c5f745b57a

For legacy reasons we always included snapshot_support
and create_share_from_snapshot_support in all the
share types the tests created. These extra-specs are
no different from any other optional extra-specs in
manila, atleast since API version 2.24 (snapshot_support
was "implied"/"required" until API version 2.23). 2.24
is a really old version to support for tempest testing.

Since we always use the latest API version to create the
share types necessary, we only ever need 1 required
extra spec (driver_handles_share_servers) - lets supply
the rest only within tests that need to test snapshots
and shares from snapshots.

This patch also adds missing skip decorators for share
group tests that were testing snapshots.

Change-Id: Ifaceab574e3242e44a9cf1bea77a4be9e505d8b8
Related-Bug: #1922784
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

API tests must be evaluated by min and max
versions, however, we've multiple places
where we don't seem to evaluate the min_version;
this leads to incorrect behavior when test
runners set a different min_version in their
test configuration.

We can also consolidate the decorators and
callables that we have. We attempted this in
the recent past [1], however, we replaced the
callables with calling a decorator method, which
resulted in many tests not being skipped.

This bugfix is currently necessary to get
tests working against stable/ussuri and
stable/train branches.

[1] I0c35aff993e67c1ef44c27580f8c2c829a6275f7
Change-Id: I2eceb1d5fe42b1b779e115a0144a5d9639d3753f
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

System-wide installation via the tempest plugin's
devstack-plugin is unnecessary since we set the
"TEMPEST_PLUGINS" devstack localrc variable with
manila-tempest-plugin, and that should handle installing
the plugin alongside other tempest requirements within
a test virtual environment.

Change-Id: Id312005dc0cc9e039a9c6a8a58476965e8d6954d
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Setuptools v54.1.0 introduces a warning that the use of dash-separated
options in 'setup.cfg' will not be supported in a future version [1].
Get ahead of the issue by replacing the dashes with underscores. Without
this, we see 'UserWarning' messages like the following on new enough
versions of setuptools:

  UserWarning: Usage of dash-separated 'description-file' will not be
  supported in future versions. Please use the underscore name
  'description_file' instead

[1] https://github.com/pypa/setuptools/commit/a2e9ae4cb

Change-Id: I6e9d570f6d2ddbe0c09cd84784808708e503dd74

When unmounting a share with the kernel
client, the target directory must be what
we used during the mount operation.

This patch adds a create-share-from-snapshot
scenario test for the ceph-fuse client, and
drops the redundant 'ip_version' attribute
to test classes that was added in the
test reorganization patch earlier [1]

[1] I7e63434e745cc1c2a5e8aaccc20f7c31404742d9
Change-Id: I9e373c658bf8aefa5763b7bb58637969e5253312
Closes-Bug: #1921369
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Create protocol specific manager classes
where we can abstract away common code
to handle access rules and mount operations
and re-use these in the tests to get adequate
coverage to the three protocols we support
in these tests currently.

Change-Id: I7e63434e745cc1c2a5e8aaccc20f7c31404742d9
Closes-Bug: #1921369
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Remove capability_create_share_from_snapshot_support = False
from tempest config for both CephFS Native and CephFS NFS

Partially-Implements: blueprint create-share-from-snapshot-cephfs
Change-Id: Ifb984a3cee219fa97a9768495f80ff0c8349830b

This test case validates the fix to CVE-2020-27781.

The test will create a share and allow access to "admin" user.
This step should return success, but the access rule for
"admin" will be set to "error".

Related-Bug: #1904015
Depends-On: I1edd5a50079f325fa143a7e0d51b3aa3bb5ed45d
Change-Id: I01157147e749ae6068e9878bffe322cb3993fb60

We attempt to manage a share with a fake/invalid
path in some tests and expect asynchronous
failures. So as long as there's only one of these
fake/invalid exports known to manila at a time,
there's no issue. However, when tests are run in
parallel, we see failures because manila validates
that the export path provided isn't known so far.

Change-Id: Ic1ed8c559221417347eeb71441ed8e941d70b8f1
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Depends-on: I5ce0fabf59bfca5ebaf0be5ffe9986e2b0480295
Partially implements: blueprint share-size-limited-by-share-type

Change-Id: I14e71ccb5f8f4f1851bc023586d6c96841ad68f9

Getting "share_server_id" parameter requires an admin client.
Therefore it should be placed whithin the admin test suite.

Change-Id: I17c64b8ffe0538309bdd823c723dbf1176a92754

In some tests where we'd like to test role based
access control, and specifically the impact of user
roles (admin vs member vs reader), we create a user
on the fly and assign the necessary roles to this
user.

Recently devstack stopped setting a tempest conf
option that gave us a default role to assign to
regular non-privileged "member" users. [1].

This made the tests that used such users fail
with "401 Unauthenticated" errors.

So we'll need to explicitly request this regular
user role (aka "member") even when not configured
in tempest.conf.

[1] https://review.opendev.org/774524



Change-Id: I103ccda367123bc2429d1d840c0201b01ac61b4d
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

The RBAC policy defaults to create
a public share or to update an existing
share to public have changed since the
Stein release. [1]

Let's stop assuming that regular users
can perform these actions, so that manila
can safely remove the policy rule deprecation
support for these APIs.

[1] https://review.opendev.org/634864


Change-Id: I2a647fd5871ef6bb7d1ab45db893a44a560bed72
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

"skip_if_microversion_lt" and "skip_if_microversion_not_supported"
functions already exist under utils module.

Change-Id: I0c35aff993e67c1ef44c27580f8c2c829a6275f7

Currently, for each resource there is a waiter method.
The code is almost the same in all waiter methods.
This patch suggests proposes to consolidate these methods.

Change-Id: I92f4628051731a9f7e05404b48a96d2ed27a855b

In case the backends don't have the same capabilities
share creation can fail. For instance, if one of the
backend has the ability to create share from snapshot
and the other does not.
In case "capability_create_share_from_snapshot_support"
parameter is defined in tempest.conf and it is also
specified in extra specs one of the share will fail to
create.

Change-Id: Iade5b2658df59b7d6cdc9f69418afb16a0108353

In 3.1.1, tox had fixed:

mishandling the basepython directive [1]
ignoring PYTHONDONTWRITEBYTECODE [2]
More details in [3]

[1] tox-dev/tox#477
[2] tox-dev/tox@336f4f6
[3] http://lists.openstack.org/pipermail/openstack-dev/2018-July/thread.html#132075

Change-Id: I37ab7fd16ca3125870a1201fb3b2e86c61564f47

I don't see the need for a base class only for alt user.
We have already 'BaseSharesTest' class that initializes
'primary' user with the same role as 'alt' user.
If 'alt' user is necessary it can be initialzed at the test
class level.

Change-Id: Ie980a130c1996e0e97de25218fedd509cead4afb

The test verifies that user cannot find out if a share
exists in another project.

Related-Bug: #1914363
Change-Id: I82eba46b72ff656f00c9ecc94d47589d8292bf5f

Added the prefix, '-share-protocol' to 'export_path' resulting in
a unique export path value per share protocol.

Change-Id: I57fbfb0199a38235efaa6b1c2a08e0318180318f

This patch fixes security service conflict errors when security
service tests are executed. In these tests, no security services
should be automatically created during share network creation,
or the test may fail due conflicting types.
This issue can be seen when 'security_service' config option
is set to use a 'kerberos' or 'ldap' security service.

Change-Id: I4585fa8349a98f0ac6ec7ec23fb7b26ab61d65af
Signed-off-by: Douglas Viroel <viroel@gmail.com>