As suggested on the PR this removes the remaining debhelper calls for
our system services and sockets.

The remaining little bit it did for us in postinst/postrm is
added directly to these maintainer script now in the non-restart
way that we need.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

It turns out also nowadays restarting the sockets is dangerous.
  $ deb-systemd-invoke restart 'virtlogd.socket'
or
  $ systemctl restart virtlogd.socket
no more complain about being unable to restart for the service being running.
Instead they do restart the service, which makes our restarting of sockets
again kill virtlogd for example.

Therefore we also can not leave the system-services sockets to debhelper
as they would be restarted despite --no-stop-on-upgrade and thereby
restart the related services breaking guests.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

The initial version of this was based on the dbus handling of it, but
it turns out that --no-stop-on-upgrade --no-start leaves a stop command
in prerm and thereby we'd have them stopped twice.

Auto added section is identical:
if [ -z "${DPKG_ROOT:-}" ] && [ "$1" = remove ] && [ -d /run/systemd/system ] ; then
        deb-systemd-invoke stop 'libvirt-guests.service' 'virtlockd.service' 'virtlogd.service' >/dev/null || true
fi

Remove that duplicate that we added before following dbus.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Due to debhelper bug 994204 on upgrades guests are shut down
(libvirt-guests.service) or even crash (virtlogd.service) because those
services are restarted.

Until that bug is resolved in debhelper we need to take over the
handling of those services ourselves.

References:
- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994204
- https://bugs.launchpad.net/ubuntu/+source/debhelper/+bug/1959054
- utopia-team/dbus@4c5195a1



Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Use a glob to reduce repetition and add an explanation for
why it's needed in the first place.

Gbp-Dch: Ignore

Lintian insists that we need this, but given our backport
targets we know that's not the case.

Gbp-Dch: Ignore

This was necessary because, while the libvirt_guest NSS module
had a proper SONAME, the libvirt NSS module was missing it ever
since switching to meson.

The issue has now been addressed upstream, so the override is
no longer needed.

Gbp-Dch: Ignore

Only the library needs to be available at build time.

libvirt only needed radvd together with old dnsmasq versions,
but the minimum dnsmasq version is now new enough for the
dependency to no longer be necessary.

Gbp-Dch: Ignore

This will make future changes easier.

Gbp-Dch: Ignore

Gbp-Dch: Ignore

Gbp-Dch: Ignore

Symbols introduced in libvirt 8.0.0:

  * virDomainSetLaunchSecurityState

Gbp-Dch: Ignore

Gbp-Dch: Ignore

Update to upstream version '8.0.0'
with Debian dir 5319648ab168d398919fd8e05cc610efba8946ad

The ones in libvirt0 and libnss-libvirt were added when
introducing multiarch support, and the current implementation
no longer requires them so they always end up being empty.

The ones in libvirt-daemon-* expand to

  Pre-Depends: init-system-helpers (>= 1.54~)

which is guaranteed to be satisfied on any of the reasonable
backport targets, namely Debian 11 bullseye and Ubuntu 20.04
LTS focal.

All of these are guaranteed to be satisfied on any of the
reasonable backport targets, namely Debian 11 bullseye and
Ubuntu 20.04 LTS focal.

In a few cases, we can drop the relationship altogether
instead of just the version constraint.

All uploads in the last couple of years have been handled by
either Guido or me; Laurent, on the other hand, doesn't seem to
have touched the libvirt package in about a decade.

Update the Uploaders field so that it reflects reality.

These are not actually checked at build time, so we can avoid
installing them.

Gbp-Dch: Ignore

All of these packages got dragged in indirectly, so there is
no change in terms of features enabled in the package, but
it's still better to spell out our direct dependencies.

Gbp-Dch: Ignore

It's used by the storage driver, not the client library.

The changes made to -doc, -daemon-system-systemd and -wireshark
are those suggested by the multiarch hinter. The hinter also
suggests to make the various drivers Multi-Arch: same, but that
can't work because they all depend on -daemon, which is not
co-installable. Hopefully making them explicitly Multi-Arch: no
will make the hinter stop suggesting those changes; even if
not, there's no harm in spelling out the status quo.

As a bonus, Linux architectures that don't have systemtap
support yet will no longer end up with an empty
/usr/share/systemtap directory in the package.

Gbp-Dch: Ignore

Gbp-Dch: Ignore

debhelper supports this, and it's better than wildcards
because it's more explicit.

Gbp-Dch: Ignore

This ensures that new files introduced upstream will not slip
into a binary package without dh_missing notifying us.

There are only three remaining cases in which wildcards are
still used:

  * the version part of the filename for the library itself
    changes every release, and it would be annoying to have to
    keep up. The wildcard is still modified so that unexpected
    incompatible soname bumps would be caught;

  * the Wireshark inspector is installed in a path that is
    versioned according to the Wireshark package libvirt is
    built against, and which we have no control over;

  * libraries, plugins and other files that are installed under
    arch-qualified paths.

We're going to get rid of the last one in the next commit.

Gbp-Dch: Ignore

Gbp-Dch: Ignore

This stops them from triggering the patch-not-forwarded-upstream
Lintian tag.

Gbp-Dch: Ignore

We can skip recommends and install just python3-debian, which
is the only optional dependency that the wrap-and-sort script
needs.

Gbp-Dch: Ignore

Gbp-Dch: Ignore

It's not actually used by libvirt, and it's currently broken
in sid which makes it impossible to build libvirt.

Gbp-Dch: Ignore

There's some trivial conflict resolution involved.