Skip to content
GitLab
Switch branch/tag
  1. 12 Aug, 2021 1 commit
  3. 11 Aug, 2021 1 commit
  5. 09 Aug, 2021 1 commit
    • Andrea Bolognani's avatar
      symbols: Bump symbol versions · e419a38a
      Andrea Bolognani authored 
      libvirt 7.6.0 doesn't introduce any new public symbols.

Two small existing issue are fixed in the process:

  * since libvirt 7.4.0 didn't introduce any new public symbols
    either, the entry for @LIBVIRT_7.4.0 should not exist;

  * instead of @LIBVIRT_ADMIN_PRIVATE_7.4.0, the entry should
    have been created for @LIBVIRT_ADMIN_PRIVATE_7.5.0.

Gbp-Dch: Ignore
      e419a38a
  7. 08 Aug, 2021 4 commits
  9. 05 Jul, 2021 13 commits
  11. 03 Jul, 2021 2 commits
  13. 26 Feb, 2021 3 commits
  15. 15 Feb, 2021 4 commits
    • Andrea Bolognani's avatar
      libvirtd: Move default for start_libvirtd · ef2d11a1
      Andrea Bolognani authored 
      Store the default (yes) in the sysv init script itself rather
than in the default file, and turn the corresponding line in
the latter into a comment; additionally, discourage users from
using this option to prevent libvirtd from starting at boot
and recommend disabling the sysv service instead.

Gbp-Dch: Ignore
      ef2d11a1
    • Andrea Bolognani's avatar
      sysv: Refactor sysv init scripts · 84228588
      Andrea Bolognani authored 
      There are a few cases in which hardcoded values are used when a
suitable variable already exists; some conditionals in the script
for libvirtd are also tweaked so that a diff between the two
scripts will only highlight the actual functional differences,
without additional noise.

This commit is better viewed with 'git show -w'.

Gbp-Dch: Ignore
      84228588
    • Andrea Bolognani's avatar
      virtlogd: Fix some bugs in the sysv init script · b11d3c37
      Andrea Bolognani authored 
      When the script was created by copying the one for libvirtd, a
few references were not updated correctly.
      b11d3c37
    • Andrea Bolognani's avatar
      libvirtd: Improve default file · 5ae74e05
      Andrea Bolognani authored 
      Several changes:

  * use $LIBVIRTD_ARGS, which is consistent with upstream and
    other daemons, instead of $libvirtd_opts;

  * drop mentions of $KRB5_KTNAME, same as upstream has done
    with commit 68d08cf2f200;

  * list all sysv-only options together, and make it very clear
    that they don't apply when systemd is in use.

Note that, unlike upstream, we don't enable a timeout for
libvirtd by default: this is because we need the default file
to work both for systemd, which has socket activation, and for
sysv, which doesn't.

During upgrades, if the default file had not been modified by
the user then the transition will happen quietly; however, if
local modifications had been made, then the admin will be left
dealing with a nasty-looking diff: highlighting the change in
a NEWS entry will hopefully mitigate the confusion.
      5ae74e05
  17. 14 Feb, 2021 5 commits
    • Andrea Bolognani's avatar
      libvirtd: Patch upstream default file · 7237af0c
      Andrea Bolognani authored 
      Right now we're ignoring the upstream-provided default file and
installing our own that we keep in debian/ instead, but that
means that a) we might not realize upstream has made some
changes that our default file should adapt to and b) we have to
treat this one default file differently from the other ones we
install.

Since we can't just install the upstream default file directly,
settle for the next best thing: tweak it via a patch before the
upstream build system installs it.

For now, the patch replaces the upstream file completely with
our version, but later we're going to aim for a more
maintainable hybrid approach.

Gbp-Dch: Ignore
      7237af0c
    • Andrea Bolognani's avatar
      rules: Install default files in a simpler way · 1fb33e27
      Andrea Bolognani authored 
      Currently, we're installing the upstream-provided default files
in a rather roundabout way: we copy them from the source
directory to the debian/ directory, then we ask dh_installinit
to to install them, and we clean up the copy at dh_auto_clean
time.

The upstream build system already installs all these files
under $(DESTDIR), and all we need to do is rename the directory
they are installed into so that it matches Debian conventions
and pick up the files from there.

Gbp-Dch: Ignore
      1fb33e27
    • Andrea Bolognani's avatar
      patches: Patch all systemd services in one go · debc1b91
      Andrea Bolognani authored 
      We apply pretty much the same changes to all services, so it
makes sense to have a single patch instead of three.

Gbp-Dch: Ignore
      debc1b91
    • Andrea Bolognani's avatar
      libvirt-guests: Don't patch quite as heavily · 1fbed741
      Andrea Bolognani authored 
      Simple text replacement for things like @sbindir@ is already
handled by the upstream build system, so we don't really need
to patch the script as much as we currently do.

Gbp-Dch: Ignore
      1fbed741
    • Andrea Bolognani's avatar
      libvirt-guests: Add wrapper script for sysv init · 2b705f6e
      Andrea Bolognani authored 
      Instead of patching the libvirt-guests.sh script to add sysv
init information and then installing two copies of it, one
under /usr/lib/libvirt and one under /etc/init.d, create a
tiny wrapper script for the latter location.

This is the same approach that was used upstream before sysv
init support was dropped in commit 912fe2df9d86.

We still need to patch libvirt-guest.sh to make it work on
Debian.

Gbp-Dch: Ignore
      2b705f6e
  19. 10 Feb, 2021 2 commits
  21. 08 Feb, 2021 2 commits
    • Christian Ehrhardt's avatar
      systemd: do not restart sockets · ddbad4b4
      Christian Ehrhardt authored 
      

Sockets need to be started on install to be ready (drop --no-start), but not
stopped/restarted (add --no-stop-on-upgrade, drop --no-restart-after-upgrade)
later on to prevent issues on upgrade (on running services) or reinstall
(breaking the .sockets state)

Details:
- drop --no-start:
   .socket removed without being stopped will enter a faulty state that can only
   be recovered with a restart of the socket. We restart the service (libvirtd)
   backing the sockets anyway, the sockets can and should stay up as-is.
- drop --no-restart-after-upgrade:
   `--no-restart-after-upgrade` does not prevent restarts. It only controls
   when the restart happens, but we want no restart at-all so drop it.
- add --no-stop-on-upgrade:
   This needs to be added to not touch the .sockets state at all on
   upgrades.

LIBVIRT_NOSTART_UNITS nowadays only includes SOCKETS and their handling is
rather special, so this changes the name to LIBVIRT_SOCKETS to be more obvious
when touching d/rules

Signed-off-by: Christian Ehrhardt's avatarChristian Ehrhardt <christian.ehrhardt@canonical.com>
      ddbad4b4
    • Christian Ehrhardt's avatar
      systemd: start, but do not restart libvirt-guests.service · 295944dc
      Christian Ehrhardt authored 
      

Due to various changes libvirt-guests.service is no more started at all.
This all started when trying to not restart it on upgrades which we
now do properly for LIBVIRT_SYSTEM_SERVICES, so move libvirt-guests.service
to this group.

Not doing so would stop and start VMs on package upgrades.

Signed-off-by: Christian Ehrhardt's avatarChristian Ehrhardt <christian.ehrhardt@canonical.com>
      295944dc
  23. 04 Feb, 2021 1 commit
    • Christian Ehrhardt's avatar
      d/control: avoid libvirt-clients to pull in libvirt-daemon · 3cbe8f96
      Christian Ehrhardt authored 
      

As of today `libvirt-clients` pulls in too much due to the
split of `libvirt-login-shell` and the dependencies it has now.
Not everyone using `libvirt-clients` (I'd think only a very small
fraction) uses `libvirt-login-shell`, but it is a Recommends and therefore
often installed as dependency.

Further down `libvirt-login-shell` depends on `libvirt-daemon-driver-lxc`
(reasonable), but than in turn depends on `libvirt-daemon`.
That latter one is reasonable for `libvirt-daemon-driver-lxc` itself, but
looking at the full chain it means that anyone using `libvirt-clients` (which
could quite often be to manage a remote system) will also get `libvirt-daemon`
installed.

Cut this dependency chain by reducing `libvirt-clients` -> `libvirt-login-shell`
to a suggests.

Signed-off-by: Christian Ehrhardt's avatarChristian Ehrhardt <christian.ehrhardt@canonical.com>
      3cbe8f96
  25. 31 Jan, 2021 1 commit
    • Andrea Bolognani's avatar
      control: Always explicitly depend on libvirt0 · effe0cd5
      Andrea Bolognani authored 
      dpkg-shlibdeps will figure out these dependencies exist and
include them in ${shlib:Depends}, but they will look like

  Depends: libvirt0 (>= 7.0.0)

which can sometimes end up not being strict enough.

In order to ensure that all parts of libvirt that are tightly
coupled are always upgraded at the same time, make these
dependencies explicit.
      effe0cd5