Without this on continaer based testing the services (and all other
follow on tests) fail like:

× ovs-vswitchd.service - Open vSwitch Forwarding Unit
236     Loaded: loaded (/lib/systemd/system/ovs-vswitchd.service; static)
237     Active: failed (Result: exit-code) since Mon 2022-07-04 07:18:04 UTC; 1s ago
238    Process: 2297 ExecStart=/usr/share/openvswitch/scripts/ovs-ctl --no-ovsdb-server --no-monitor --system-id=random --no-record-hostname start $OVS_CTL_OPTS (code=exited, status=1/FAILURE)
239        CPU: 42ms
240Jul 04 07:18:03 ci-185-36e1640d ovs-ctl[2326]: removing bridge module ... failed!
241Jul 04 07:18:03 ci-185-36e1640d systemd[1]: ovs-vswitchd.service: Control process exited, code=exited, status=1/FAILURE
242Jul 04 07:18:03 ci-185-36e1640d systemd[1]: ovs-vswitchd.service: Failed with result 'exit-code'.
243Jul 04 07:18:03 ci-185-36e1640d systemd[1]: Failed to start Open vSwitch Forwarding Unit.
244Jul 04 07:18:04 ci-185-36e1640d systemd[1]: ovs-vswitchd.service: Scheduled restart job, restart counter is at 5.
245Jul 04 07:18:04 ci-185-36e1640d systemd[1]: Stopped Open vSwitch Forwarding Unit.
246Jul 04 07:18:04 ci-185-36e1640d systemd[1]: ovs-vswitchd.service: Start request repeated too quickly.
247Jul 04 07:18:04 ci-185-36e1640d systemd[1]: ovs-vswitchd.service: Failed with result 'exit-code'.
248Jul 04 07:18:04 ci-185-36e1640d systemd[1]: Failed to start Open vSwitch Forwarding Unit.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

W: openvswitch-switch: systemd-service-file-refers-to-obsolete-target syslog.target [lib/systemd/system/ovsdb-server.service]

E: openvswitch-testcontroller: init.d-script-needs-depends-on-lsb-base [etc/init.d/openvswitch-testcontroller:45]
E: openvswitch-vtep: init.d-script-needs-depends-on-lsb-base [etc/init.d/openvswitch-vtep:15]

Not very helpful, if it's included it's needed

It's default, and version 6 is not in any archive any longer

No longer needed anywhere

The kernel module was removed

Cannot be used until git-buildpackage supports it:
https://bugs.debian.org/1009163

E: openvswitch source: missing-notice-file-for-apache-license

W: openvswitch-ipsec: skip-systemd-native-flag-missing-pre-depends (does not satisfy init-system-helpers:any)

openvswitch-ipsec: python3-script-but-no-python3-dep

Not only Testsuite is a known field, but also it is no longer
necessary to manually specify that the package has autopkgtest,
the presence of debian/tests/control is enough

It does not exist anymore in any Debian or Ubuntu archive

P: openvswitch source: trailing-whitespace

It is completely pointless and just adds noise

Unpacking openvswitch-switch (2.17.2-1+salsaci) over (2.15.0+ds1-10+b1) ...
dpkg: error processing archive /tmp/apt-dpkg-install-3Y5v8C/1-openvswitch-switch_2.17.2-1+salsaci_amd64.deb (--unpack):
  trying to overwrite '/usr/bin/ovs-dpctl', which is also in package openvswitch-common 2.15.0+ds1-10+b1

Unpacking openvswitch-ipsec (2.17.2-1+salsaci) over (2.15.0+ds1-10+b1) ...
dpkg: error processing archive /var/lib/local-apt-repository/../../..//srv/local-apt-repository/openvswitch-ipsec_2.17.2-1+salsaci_amd64.deb (--unpack):
  trying to overwrite '/usr/share/openvswitch/scripts/ovs-monitor-ipsec', which is also in package openvswitch-common 2.15.0+ds1-10+b1

Frode Nordahl authored Jun 29, 2022 and Luca Boccassi committed Jun 30, 2022

Patches for the upstream OVS repository needs to pass the
utilities/checkpatch.py script.  I will attempt to add debian/*
to the ignore-list for some of the checks but these are easy to
fix.

Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>

Frode Nordahl authored Jun 28, 2022 and Luca Boccassi committed Jun 30, 2022

This allows building the package by calling debian/rules directly.

Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>

Frode Nordahl authored Jun 28, 2022 and Luca Boccassi committed Jun 30, 2022

Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>

Frode Nordahl authored Jun 28, 2022 and Luca Boccassi committed Jun 30, 2022

Also use inclusing naming of variable for ports in bond.

Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>

Frode Nordahl authored Jun 28, 2022 and Luca Boccassi committed Jun 30, 2022

Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>

Frode Nordahl authored Jun 28, 2022 and Luca Boccassi committed Jun 30, 2022

The package tests currently fail with:
../debian/tests/dpdk:43:echo -n "running openflow tests using mininet"
../debian/tests/vanilla:26:echo -n "running openflow tests using mininet"
See above for uses for "echo -n", which is non-POSIX
and does not work with all shells.  Use "printf" instead.

Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>

Frode Nordahl authored Jun 28, 2022 and Luca Boccassi committed Jun 30, 2022

The building of the out of tree kernel driver was dropped
back in 2014.

Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>

Until the migration is completed we need to build on experimental

Gbp-Dch: ignore

Christian Ehrhardt authored Jun 28, 2022 and Luca Boccassi committed Jun 30, 2022

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Christian Ehrhardt authored Jun 28, 2022 and Luca Boccassi committed Jun 30, 2022

This was present in Debian for a while but isn't used by anyone so far.
build-rdeps openvswitch-dev and apt-cache rdepends openvswitch-dev show
nothing.

But a heads up we've got from upstream indicate that there will be
backward incompatible changes without too much care. It seems it just
isn't meant for too serious external usage.

We can add it back once stabilized and once having a use-case that makes
it really beenficial to have it.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Christian Ehrhardt authored Jun 28, 2022 and Luca Boccassi committed Jun 30, 2022

This is case #7 https://wiki.debian.org/PackageTransition



Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>