1. 02 Apr, 2019 3 commits
  2. 26 Mar, 2019 1 commit
  3. 25 Mar, 2019 2 commits
  4. 24 Mar, 2019 3 commits
  5. 23 Mar, 2019 2 commits
  6. 15 Mar, 2019 5 commits
  7. 14 Mar, 2019 2 commits
  8. 13 Mar, 2019 4 commits
  9. 11 Mar, 2019 2 commits
  10. 08 Mar, 2019 1 commit
    • Marcin Sulikowski's avatar
      buildpackage-funcs: Fix whitespace handling in .dsc paths · 1440f3cb
      Marcin Sulikowski authored
      We've noticed that pbuilder fails to build source packages located in
      directories which contain spaces within their names. For example, the
      following:
      
          $ pbuilder build "/tmp/source packages/pbuilder_0.230.2.dsc"
      
      fails with an error like this:
      
          I: Building the build Environment
          I: extracting base tarball [/var/cache/pbuilder/base.tgz]
          I: copying local configuration
          I: mounting /proc filesystem
          I: mounting /sys filesystem
          I: creating /{dev,run}/shm
          I: mounting /dev/pts filesystem
          I: redirecting /dev/ptmx to /dev/pts/ptmx
          I: policy-rc.d already exists
          I: Obtaining the cached apt archive contents
          I: Copying source file
          awk: cmd. line:5:              /^ / {if (p){print "/tmp/source
          awk: cmd. line:5:                                 ^ unterminated string
          awk: cmd. line:5:              /^ / {if (p){print "/tmp/source
          awk: cmd. line:5:                                 ^ syntax error
          I: copying [/tmp/source]
          cp: cannot stat '/tmp/source': No such file or directory
          I: unmounting dev/ptmx filesystem
          I: unmounting dev/pts filesystem
          (...)
      
      Those problems are caused by the fact that:
      
      * The `get822files` function incorrectly concatenates strings in:
      
            awk '(...) {print "'$(dirname "$input")'/" $'${field}'}'
      
        When `$(dirname "$input")` contains whitespace, the awk script is
        divided by `bash` into multiple arguments for `awk` which causes
        the errors mentioned in the output above.
      * The `get822files` function is designed to return a list of paths
        separated by a single space character, which makes it impossible
        to parse its output when it looks like this:
      
            source packages/pbuilder_0.230.2.dsc source packages/pbuilder_0.230.2.tar.xz
      
      These issues make it impossible for pbuilder to copy the given source
      package to its chroot environment even though the rest of pbuilder's
      code is designed to handle whitespace in file names.
      
      We fix this by changing how the `get822files` function is supposed to
      work -- instead of listing paths separated by a single space, it now
      lists paths separated by LF characters which, although still allowed in
      paths, are almost never used in directory names. As a by-product, path
      of the source package may now contain any characters except for LF,
      including `'` and `"` which were not handled correctly before this fix
      as well.
      Signed-off-by: Marcin Sulikowski's avatarMarcin Sulikowski <marcin.sulikowski@editshare.com>
      1440f3cb
  11. 28 Feb, 2019 2 commits
  12. 21 Feb, 2019 2 commits
  13. 19 Feb, 2019 1 commit
  14. 18 Feb, 2019 1 commit
    • Helmut Grohne's avatar
      allow pbuilder --login on tarballs that lack dpkg-dev · 64ecd6ce
      Helmut Grohne authored
      Beyond building packages, pbuilder can be used to quickly unpack a chroot
      tarball and spawn a shell inside. Before this commit, pbuilder would abort
      on chroots that lack dpkg-dev, because its call to dpkg-architecture would
      fail. The build architecture always is dpkg's native architecture.
      64ecd6ce
  15. 07 Jan, 2019 1 commit
  16. 12 Nov, 2018 1 commit
  17. 11 Nov, 2018 4 commits
  18. 10 Nov, 2018 3 commits