Skip to content

Changes to resolve issues identified in 2nd review

Jan Gru requested to merge jgru/regripper:add-changes-for-2nd-review into debian/master

Dear team,

this merge requests addresses the issues identified by Raphaël Hertzog in his review of regripper's packaging [0]. Thank you again for this, @hertzog.

I hope, that all problematic parts have been improved and that I could resolve the issues. The following changes were made:

  • Add space in front of the long description of patches
  • Remove "Origin"-field from patches
  • Change testcase named "listplugins" to avoid failure on the addition of new plugins
  • Modify installation location of Base.pm, File.pm and Key.pm
  • Modify debian/patches/10_modify-paths-in-srcs.patch, so that the include path is created in a way, that the a/m files (Base.pm, File.pm and Key.pm) are used

If there are still open issues, please get back to me. (I did not squash the commits at this stage of the review, but they should get squashed on an eventual merge.)

Thanks for your review and help.

Best regards,
Jan

[0] https://lists.debian.org/debian-security-tools/2021/06/msg00004.html

Edited by Jan Gru

Merge request reports