reproducible trbo system health check: detect a bunch of problems when updating meta pkg sets

Signed-off-by: Holger Levsen <holger@layer-acht.org>

bin/reproducible_system_health.sh

@@ -135,8 +135,20 @@ for JOB_NAME in reproducible_* ; do
 		echo "unstable job: $JOB_NAME"
 		let SCORE+=1 || SCORE=0
 		prepare_log
+		if [ "$JOB_NAME" = "reproducible_create_meta_pkg_sets" ] ; then
+			if $(grep -q " cp " $LOG) ; then
+				small_note " (outdated pkg set(s), manual intervention required)"
+			elif $(grep -q "could not download tail's latest packages file" $LOG) ; then
+				small_note " (problem with tails pkg set)"
+			elif $(grep -q "could not download cloud-image package list" $LOG) ; then
+				small_note " (problem with cloud-image pkg set)"
+			elif $(grep -q "could not download grml's latest dpkg.selections file" $LOG) ; then
+				small_note " (problem with grml  pkg set)"
+			elif $(grep -E -q "could not (download|determine) PureOS" $LOG) ; then
+				small_note " (problem with PureOS pkg set)"
+			fi
 		# only show the most severe problem, don't aggregate them
-		if $(grep -q "failed Squid Web Proxy Server" $LOG) ; then
+		elif $(grep -q "failed Squid Web Proxy Server" $LOG) ; then
 			small_note " (squid.service failed)"
 		elif $(grep -q "Kernel needs upgrade" $LOG) ; then
 			small_note " (reboot needed for kernel upgrade)"
@@ -289,9 +301,9 @@ conditional_paragraph() {
 			local MODIFIER=$(echo $LINE | cut -d '|' -f1)
 			local NAME=$(echo $LINE | cut -d '|' -f2)
 			local URL=$(echo $LINE | cut -d '|' -f3)
-			local JOB_GROUP=$(echo $NAME |rev | cut -d '_' -f2-|rev)
 			if [ "${2:0:12}" = "Ignored jobs" ] ; then
 				# we group ignored jobs so that they take up less visual space in the output
+				local JOB_GROUP=$(echo $NAME |rev | cut -d '_' -f2-|rev)
 				GROUP_MEMBERS=$(grep -c "${JOB_GROUP}_" $1)
 				if [ $GROUP_MEMBERS -gt 1 ] ; then
 					let GROUP_COUNTER+=1