1. 23 Aug, 2018 1 commit
  2. 22 Aug, 2018 1 commit
  3. 06 Aug, 2018 1 commit
  4. 03 Aug, 2018 1 commit
  5. 02 Aug, 2018 2 commits
  6. 31 Jul, 2018 6 commits
  7. 03 Mar, 2016 1 commit
  8. 09 Oct, 2015 3 commits
  9. 21 Sep, 2015 1 commit
  10. 15 Sep, 2015 2 commits
  11. 30 Apr, 2015 2 commits
  12. 28 Oct, 2014 1 commit
  13. 20 Sep, 2014 1 commit
  14. 10 Jun, 2014 1 commit
  15. 26 May, 2014 2 commits
    • Michael Tokarev's avatar
      libcacard: remove useless initializers · b85dd1fe
      Michael Tokarev authored
      libcacard has many functions which initializes local variables
      at declaration time, which are always assigned some values later
      (often right after declaration).  Clean up these initializers.
      Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
      b85dd1fe
    • Michael Tokarev's avatar
      libcacard: fix wrong array expansion logic · 0b25d4b5
      Michael Tokarev authored
      The currrent code in libcacard/vcard_emul_nss.c:vcard_emul_options()
      has a weird bug in variable usage around expanding opts->vreader
      array.
      
      There's a helper variable, vreaderOpt, which is first needlessly
      initialized to NULL, next, conditionally, only we have to expand
      opts->vreader, receives array expansion from g_renew(), and next,
      even if we don't actually perform expansion, the value of this
      variable is assigned to the actual array, opts->vreader, which
      was supposed to be expanded.
      
      So, since we expand the array by READER_STEP increments, only
      once in READER_STEP (=4) the code will work, in other 3/4 times
      it will fail badly.
      
      Fix this by not using this temp variable when expanding the
      array, and by dropping the useless =NULL initializer too -
      if it wasn't in place initially, compiler would have warned
      us about this problem at the beginning.
      Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
      Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
      0b25d4b5
  16. 23 May, 2014 4 commits
  17. 07 May, 2014 1 commit
    • Michael Tokarev's avatar
      libcacard: replace pstrcpy() with memcpy() · 9fd7072a
      Michael Tokarev authored
      Commit 2e679780ae86c6ca8 replaced strncpy() with pstrcpy()
      in one place in libcacard.  This is a qemu-specific function,
      while libcacard is a stand-alone library (or tries to be).
      But since we know the exact length of the string to copy,
      and know that it definitely will fit in the destination
      buffer, use memcpy() instead, and null-terminate the string
      after that.
      
      An alternative is to use g_strlcpy() or strncpy(), but memcpy()
      is more than adequate in this place.
      Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
      Cc: qemu-trivial@nongnu.org
      Cc: Alon Levy <alevy@redhat.com>
      9fd7072a
  18. 02 Dec, 2013 1 commit
  19. 21 Jun, 2013 1 commit
  20. 24 Apr, 2013 4 commits
  21. 30 Jan, 2013 1 commit
  22. 05 Oct, 2012 2 commits