Commits (10)
-
This (strives to) implement the same algorithm that rpm uses [1]. All strings are accepted, and the answer is always -1, 0, or +1. This should be also compatible with Debian rules: Debian doesn't allow ^ in versions, but otherwise follows similar rules. The addition of ~ in rpm was modelled after Debian. If Debian adds support for ^ in the future, hopefully it'll be in a way that is compatible. (rpm and deb have different rules how to split the package name version parts, but this shouldn't matter for us, since we're only looking at the version part here.) For all not overly complicated strings this should generally return the result that people expect. For some of the corner cases the results might be nonobvious, but I think it's better to follow one established standard than to try to come up with something fresh. [1] So… I should put a link to some docs here. But I don't think the are is any reference for this. Oh, rpm :---[ https://github.com/rpm-software-management/rpm/blob/master/rpmio/rpmvercmp.c#L12 [2] https://www.debian.org/doc/debian-policy/ch-controlfields.html#version Note on the copyright: I wrote this from scratch based on my understanding of the rules and examples online and the (scant) documentation that is online. The example list is copied from rpm tests, but the way that the examples are structured and invoked is completely different. The only part that was carried over are the version strings to test, so I think it's reasonable to treat this as an indepedent work.fce00cf6 -
distutils is deprecated and slated for removal. Every import of the module raises a warning with python3.10. PEP 632 says to use shutil.which instead.
fef2375b -
E.g. Fedora has "OpenSSH_8.7p1, OpenSSL 1.1.1l FIPS 24 Aug 2021", which would give "8.7p1," as the version.
beebe3fd -
Every import of distuils now raises a warning, and the module is slated for removal. The recommended replacement is packaging.version. It has Version and LegacyVersion. LegacyVersion documents itself as "This class implements the previous de facto sorting algorithm used by setuptools". (Comparisons of packaging.LegacyVersion and packaging.Version are intentionally borked, so packaging.LegacyVersion should not be mixed with packaging.Version or packaging.parse(), which can return packaging.Version.) But use of LegacyVersion also raises a deprecation warning, with removal slated for the next release. The runtime requirement on 'distutils' is dropped, since it is not needed any more.
953a599c -
String comparisons don't really work for version strings.
4c3109cb -
With llvm-13.0.0~rc1, we get the following error: Command `'llvm-objdump --arch-name x86_64 --section __TEXT,__text --macho --demangle --no-leading-addr --no-show-raw-insn {}'` failed with exit code 1. Standard output: │┄ llvm-objdump: error: unknown argument '--arch-name' --arch-name=… works with both the new llvm and older ones. I thought this would fix #275, but it turns out it's not enough.b2b1f731 -
It seems the output changes a bit. Fixes #275.
258d09a4 -
Chris Lamb authorede6024b3b -
Chris Lamb authoreda33cf81e
-
Chris Lamb authored2fae7e85
tests/test_versions.py
0 → 100644
tests/utils/versions.py
0 → 100644