Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • diffoscope diffoscope
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 145
    • Issues 145
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Reproducible BuildsReproducible Builds
  • diffoscopediffoscope
  • Issues
  • #331
Closed
Open
Issue created Jan 26, 2023 by Vagrant Cascadian@vagrantOwner

tests fail with pypdf2 1.x versions

I suspect 6aed2e53 broke support for older pypdf2 versions, as when I upgraded to diffoscope 233 in guix, it caused test suite failures. The fix for guix was to switch to pypdf 3.x (not to be confused with pypdf2 3.x), as guix had an older pypdf2 1.x version, so in a sense the issue is settled at least for guix.

That said, seems like it would be good to either make the tests backwards compatible with older pypdf2 again (older pypdf2 1.x worked with diffoscope 224 fine), or mark the tests as requiring a newer version.

I will dig up more details, just wanted to get this reported before I forget...

p.s. If you like being confused by versioning/naming discrepancies, check out https://pypi.org/search/?q=pypdf ... fork early, fork often, fork confusingly

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking