Skip to content

fit test fails with uboot-tools 2023.07.02 (file 5.45 regression?)

It seems that the output order changed:

For nested_symlink:

nested_differences = [<Difference file list -- file list []>, <Difference filetype from file(1) -- filetype from file(1) []>, <Difference dir/link -- dir/link []>, <Difference dir/text -- dir/
text []>]

For nested_compressed_files:

nested_differences = [<Difference file list -- file list []>, <Difference filetype from file(1) -- filetype from file(1) []>, <Difference dir/link -- dir/link []>, <Difference dir/text -- dir/text []>]

pytest output

tests/comparators/test_fit.py ....F[<Difference file list -- file list []>, <Difference filetype from file(1) -- filetype from file(1) []>, <Difference dir/link -- dir/link []>, <Difference dir/text -- dir/text []>]
F.

=========================================================================================== FAILURES ===========================================================================================
_____________________________________________________________________________________ test_nested_symlink ______________________________________________________________________________________

nested_differences = [<Difference file list -- file list []>, <Difference filetype from file(1) -- filetype from file(1) []>, <Difference dir/link -- dir/link []>, <Difference dir/text -- dir/text []>]

    @skip_unless_tools_exist("cpio")
    @skip_unless_tool_is_at_least("dumpimage", dumpimage_version, "2021.01")
    @skip_unless_tools_exist("fdtdump")
    def test_nested_symlink(nested_differences):
>       assert nested_differences[1].source1 == "dir/link"
E       AssertionError: assert 'filetype from file(1)' == 'dir/link'
E         - dir/link
E         + filetype from file(1)

tests/comparators/test_fit.py:128: AssertionError
_________________________________________________________________________________ test_nested_compressed_files _________________________________________________________________________________

nested_differences = [<Difference file list -- file list []>, <Difference filetype from file(1) -- filetype from file(1) []>, <Difference dir/link -- dir/link []>, <Difference dir/text -- dir/text []>]

    @skip_unless_tools_exist("cpio")
    @skip_unless_tool_is_at_least("dumpimage", dumpimage_version, "2021.01")
    @skip_unless_tools_exist("fdtdump")
    def test_nested_compressed_files(nested_differences):
        print(nested_differences)
>       assert nested_differences[2].source1 == "dir/text"
E       AssertionError: assert 'dir/link' == 'dir/text'
E         - dir/text
E         + dir/link

tests/comparators/test_fit.py:138: AssertionError
=================================================================================== short test summary info ====================================================================================
FAILED tests/comparators/test_fit.py::test_nested_symlink - AssertionError: assert 'filetype from file(1)' == 'dir/link'
FAILED tests/comparators/test_fit.py::test_nested_compressed_files - AssertionError: assert 'dir/link' == 'dir/text'
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information