Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
diffoscope
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Reproducible Builds
diffoscope
Commits
25fee28c
Commit
25fee28c
authored
7 years ago
by
Ximin Luo
Browse files
Options
Downloads
Patches
Plain Diff
Run zipinfo on /dev/stdin instead of a variable path. (Closes: #879011)
parent
40fd9f56
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
diffoscope/comparators/zip.py
+4
-1
4 additions, 1 deletion
diffoscope/comparators/zip.py
with
4 additions
and
1 deletion
diffoscope/comparators/zip.py
+
4
−
1
View file @
25fee28c
...
...
@@ -35,7 +35,10 @@ from .utils.command import Command
class
Zipinfo
(
Command
):
@tool_required
(
'
zipinfo
'
)
def
cmdline
(
self
):
return
[
'
zipinfo
'
,
self
.
path
]
# zipinfo (without -v) puts warning messages (some of which contain
# $path) into stdin when stderr is not a tty, see #879011 for details.
# to work around it, we run it on /dev/stdin instead, seems to work ok.
return
[
'
sh
'
,
'
-ec
'
,
'
zipinfo /dev/stdin <
"
$1
"'
,
'
-
'
,
self
.
path
]
def
filter
(
self
,
line
):
# we don't care about the archive file path
...
...
This diff is collapsed.
Click to expand it.
Michael Osipov
@michael-o-guest
mentioned in issue
#97 (closed)
·
5 years ago
mentioned in issue
#97 (closed)
mentioned in issue #97
Toggle commit list
Chris Lamb
@lamby
mentioned in commit
125b1406
·
5 years ago
mentioned in commit
125b1406
mentioned in commit 125b140617c54b27d0d786cd093b796c882ab686
Toggle commit list
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment